diff options
| author | Yan, Zheng <zheng.z.yan@intel.com> | 2013-09-12 10:36:39 +0800 |
|---|---|---|
| committer | Sage Weil <sage@inktank.com> | 2013-09-18 13:26:30 -0700 |
| commit | b66ac77fa7aa3ff37804918c4308a348f239af09 (patch) | |
| tree | 73f2eed702e4c10753a5dcd7219ce2731b337785 | |
| parent | ce723b5ad6884fa337b3b66123e798a5b602e49b (diff) | |
| download | ceph-b66ac77fa7aa3ff37804918c4308a348f239af09.tar.gz | |
osdc/ObjectCacher: finish contexts after dropping object reference
The context to finish can be class C_Client_PutInode, which may drop
inode's last reference. So we should first drop object's reference,
then finish contexts.
Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
| -rw-r--r-- | src/osdc/ObjectCacher.cc | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/osdc/ObjectCacher.cc b/src/osdc/ObjectCacher.cc index 01eeccc03be..590b5d473a8 100644 --- a/src/osdc/ObjectCacher.cc +++ b/src/osdc/ObjectCacher.cc @@ -899,11 +899,10 @@ void ObjectCacher::bh_write_commit(int64_t poolid, sobject_t oid, loff_t start, ob->last_commit_tid = tid; // waiters? + list<Context*> ls; if (ob->waitfor_commit.count(tid)) { - list<Context*> ls; ls.splice(ls.begin(), ob->waitfor_commit[tid]); ob->waitfor_commit.erase(tid); - finish_contexts(cct, ls, r); } // is the entire object set now clean and fully committed? @@ -915,6 +914,9 @@ void ObjectCacher::bh_write_commit(int64_t poolid, sobject_t oid, loff_t start, oset->dirty_or_tx == 0) { // nothing dirty/tx flush_set_callback(flush_set_callback_arg, oset); } + + if (!ls.empty()) + finish_contexts(cct, ls, r); } } |