diff options
| author | Sage Weil <sage@inktank.com> | 2013-05-15 23:02:10 -0700 |
|---|---|---|
| committer | Sage Weil <sage@inktank.com> | 2013-05-20 15:09:01 -0700 |
| commit | 57a6a54db4020debd826a493cccca4695934f693 (patch) | |
| tree | 6cd3ad619f76af3b1c629e560ca0109da045ae03 | |
| parent | 85fb422a084785176af3b694882964841e02195d (diff) | |
| download | ceph-57a6a54db4020debd826a493cccca4695934f693.tar.gz | |
Makefle: force char to be signed
On an armv7l build, we see errors like
warning: rgw/rgw_common.cc:626:16: comparison is always false due to limited range of data type [-Wtype-limits]
from code
char c1 = hex_to_num(*src++);
...
if (c1 < 0)
Force char to be signed (regardless of any weird architecture's default)
to avoid risk of this leading to misbehavior.
Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Dan Mick <dan.mick@inktank.com>
(cherry picked from commit 769a16d6674122f3b537f03e17514ad974bf2a2f)
| -rw-r--r-- | src/Makefile.am | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/Makefile.am b/src/Makefile.am index cb8dbb810c2..bbd38e61843 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1144,7 +1144,8 @@ CLEANFILES += ceph_ver.h sample.fetch_config AM_COMMON_FLAGS = -Wall -D__CEPH__ -D_FILE_OFFSET_BITS=64 -D_REENTRANT \ -D_THREAD_SAFE -D__STDC_FORMAT_MACROS -D_GNU_SOURCE -rdynamic \ ${WARN_TYPE_LIMITS} ${WARN_IGNORED_QUALIFIERS} -Winit-self -Wpointer-arith \ --fno-strict-aliasing +-fno-strict-aliasing \ +-fsigned-char AM_CFLAGS = $(AM_COMMON_FLAGS) AM_CXXFLAGS = \ |