diff options
| author | Sage Weil <sage@inktank.com> | 2013-07-26 21:42:25 -0700 |
|---|---|---|
| committer | Sage Weil <sage@inktank.com> | 2013-07-26 21:47:33 -0700 |
| commit | 2aa9afa5c542914a5ab679070ef6500e74a42770 (patch) | |
| tree | e466910b8330bc435479677b1f51fcdc1f09166c | |
| parent | a8c1a2a28be426f030a50822d8b335d8a3bbb3a0 (diff) | |
| download | ceph-2aa9afa5c542914a5ab679070ef6500e74a42770.tar.gz | |
common/perf_counters: fix missing decimal in time, quoting
We shouldn't quote integer or float values. Also easier to use
dump_unsigned.
Signed-off-by: Sage Weil <sage@inktank.com>
| -rw-r--r-- | src/common/perf_counters.cc | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/src/common/perf_counters.cc b/src/common/perf_counters.cc index 86fb531f737..1dd4cdabd9d 100644 --- a/src/common/perf_counters.cc +++ b/src/common/perf_counters.cc @@ -223,24 +223,24 @@ void PerfCounters::dump_formatted(Formatter *f, bool schema) if (d->type & PERFCOUNTER_LONGRUNAVG) { f->open_object_section(d->name); if (d->type & PERFCOUNTER_U64) { - f->dump_format("avgcount", "%"PRId64, d->avgcount); - f->dump_format("sum", "%"PRId64, d->u64); + f->dump_unsigned("avgcount", d->avgcount); + f->dump_unsigned("sum", d->u64); } else if (d->type & PERFCOUNTER_TIME) { - f->dump_format("avgcount", "%"PRId64, d->avgcount); - f->dump_format("sum", "%"PRId64"%09"PRId64, - d->u64 / 1000000000ull, - d->u64 % 1000000000ull); + f->dump_unsigned("avgcount", d->avgcount); + f->dump_format_unquoted("sum", "%"PRId64".%09"PRId64, + d->u64 / 1000000000ull, + d->u64 % 1000000000ull); } else { assert(0); } f->close_section(); } else { if (d->type & PERFCOUNTER_U64) { - f->dump_format(d->name, "%"PRId64, d->u64); + f->dump_unsigned(d->name, d->u64); } else if (d->type & PERFCOUNTER_TIME) { - f->dump_format(d->name, "%"PRId64"%09"PRId64, - d->u64 / 1000000000ull, - d->u64 % 1000000000ull); + f->dump_format_unquoted(d->name, "%"PRId64".%09"PRId64, + d->u64 / 1000000000ull, + d->u64 % 1000000000ull); } else { assert(0); } |