diff options
| author | Sage Weil <sage@inktank.com> | 2013-05-09 09:40:00 -0700 |
|---|---|---|
| committer | Sage Weil <sage@inktank.com> | 2013-05-09 10:49:00 -0700 |
| commit | 2bc088307220d2ed0858009e189ebdae3364ddeb (patch) | |
| tree | 945fad604ec6115261af4d5954c36a2bdeeb4974 | |
| parent | 4a90af8dfaa50275d7e4fd135d103620392f4796 (diff) | |
| download | ceph-2bc088307220d2ed0858009e189ebdae3364ddeb.tar.gz | |
librbd: fix possible use-after-free
(of the pointer)
CID 966634 (#1 of 1): Use after free (USE_AFTER_FREE)
2. use_after_free: Using freed pointer "ictx".
Signed-off-by: Sage Weil <sage@inktank.com>
| -rw-r--r-- | src/librbd/librbd.cc | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/librbd/librbd.cc b/src/librbd/librbd.cc index 9513e1e5f2c..89bbe595752 100644 --- a/src/librbd/librbd.cc +++ b/src/librbd/librbd.cc @@ -692,7 +692,8 @@ extern "C" int rbd_open(rados_ioctx_t p, const char *name, rbd_image_t *image, librbd::ImageCtx *ictx = new librbd::ImageCtx(name, "", snap_name, io_ctx, false); int r = librbd::open_image(ictx); - *image = (rbd_image_t)ictx; + if (r >= 0) + *image = (rbd_image_t)ictx; return r; } @@ -704,7 +705,8 @@ extern "C" int rbd_open_read_only(rados_ioctx_t p, const char *name, librbd::ImageCtx *ictx = new librbd::ImageCtx(name, "", snap_name, io_ctx, true); int r = librbd::open_image(ictx); - *image = (rbd_image_t)ictx; + if (r >= 0) + *image = (rbd_image_t)ictx; return r; } |