diff options
| author | Sage Weil <sage@inktank.com> | 2013-06-17 20:32:15 -0700 |
|---|---|---|
| committer | Sage Weil <sage@inktank.com> | 2013-06-18 10:03:03 -0700 |
| commit | ce7b5ea7d5c30be32e4448ab0e7e6bb6147af548 (patch) | |
| tree | 6ad5664ec9cdf3b05314bb13fbf4d033c2048218 | |
| parent | 8bd936f077530dfeb2e699164e4492b1c0973088 (diff) | |
| download | ceph-ce7b5ea7d5c30be32e4448ab0e7e6bb6147af548.tar.gz | |
common/Preforker: fix warning
common/Preforker.h: In member function ‘int Preforker::signal_exit(int)’:
warning: common/Preforker.h:82:45: ignoring return value of ‘ssize_t safe_write(int, const void*, size_t)’, declared with attribute warn_unused_result [-Wunused-result]
This is harder than it should be to fix. :(
http://stackoverflow.com/questions/3614691/casting-to-void-doesnt-remove-warn-unused-result-error
Whatever, I guess we can do something useful with this return value.
Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: David Zafman <david.zafman@inktank.com>
| -rw-r--r-- | src/common/Preforker.h | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/common/Preforker.h b/src/common/Preforker.h index 2c1d4fd6795..98304c632b7 100644 --- a/src/common/Preforker.h +++ b/src/common/Preforker.h @@ -78,8 +78,11 @@ public: int signal_exit(int r) { if (forked) { - // tell parent - (void)safe_write(fd[1], &r, sizeof(r)); + // tell parent. this shouldn't fail, but if it does, pass the + // error back to the parent. + int ret = safe_write(fd[1], &r, sizeof(r)); + if (ret <= 0) + return ret; } return r; } |