summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* tools: ceph-monstore-tool: add 'getmonmap' commandwip-monstoretool-fooJoao Eduardo Luis2013-05-211-0/+21
| | | | Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
* debian: stop sysvinit on ceph.prermSage Weil2013-05-201-0/+1
| | | | Signed-off-by: Sage Weil <sage@inktank.com>
* ceph df: fix si units for 'global' statsMike Kelly2013-05-201-3/+3
| | | | | | | si_t expects bytes, but it was being given kilobytes. Signed-off-by: Mike Kelly <pioto@pioto.org> (cherry picked from commit 0c2b738d8d07994fee4c73dd076ac9364a64bdb2)
* Merge pull request #295 from ceph/wip-5077Sage Weil2013-05-174-0/+18
|\ | | | | Reviewed-by: Joao Luis <joao.luis@inktank.com>
| * mon: clear pg delta after some periodSage Weil2013-05-164-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | If we have not pg_map updates, the delta doesn't update, and can get stuck with the velocity right before activity stopped. This is confusing, and can cause incorrect health warnings about in-progress recovery. To fix this, zero the delta if there is no activity for 'mon delta reset interval' seconds. Fixes: #5077 Signed-off-by: Sage Weil <sage@inktank.com>
* | sysvinit: fix enumeration of local daemons when specifying type onlySage Weil2013-05-162-21/+12
| | | | | | | | | | | | | | | | | | | | | | | | - prepend $local to the $allconf list at the top - remove $local special case for all case - fix the type prefix checks to explicitly check for prefixes Fugly bash, but works! Backport: cuttlefish, bobtail Signed-off-by: Sage Weil <sage@inktank.com> Reviewed-by: Dan Mick <dan.mick@inktank.com>
* | udev: install disk/by-partuuid rulesSage Weil2013-05-164-0/+37
|/ | | | | | | | | | Wheezy's udev (175-7.2) has broken rules for the /dev/disk/by-partuuid/ symlinks that ceph-disk relies on. Install parallel rules that work. On new udev, this is harmless; old older udev, this will make life better. Fixes: #4865 Backport: cuttlefish Signed-off-by: Sage Weil <sage@inktank.com>
* test_filestore_idempotent_sequence: unmount prior to deleting storeSamuel Just2013-05-161-8/+10
| | | | | | | | | | | FileStoreDiff umounts the stores in its destructor. Also, DeterministicOpSequence handles deletes its passed object store. Fixes: #5076 Signed-off-by: Samuel Just <sam.just@inktank.com> Reviewed-by: David Zafman <david.zafman@inktank.com>
* Revert "test_filejournal.cc: cleanup memory in destructor"Samuel Just2013-05-161-2/+0
| | | | | | | | | | The finish() method for Contexts calls delete this. This reverts commit 36028916c4630ea66007760efed8fc6c441e7af5. Fixes: #5075 Signed-off-by: Samuel Just <sam.just@inktank.com> Reviewed-by: David Zafman <david.zafman@inktank.com>
* debian: make radosgw require matching version of librados2Sage Weil2013-05-161-1/+1
| | | | | | | | | | ...indirectly via ceph-common. We get bad behavior when they diverge, I think because of libcommon.la being linked both statically and dynamically. Fixes: #4997 Backport: cuttlefish, bobtail Signed-off-by: Sage Weil <sage@inktank.com> Reviewed-by: Gary Lowell <gary.lowell@inktank.com>
* FileJournal: adjust write_pos prior to unlocking write_lockSamuel Just2013-05-161-10/+13
| | | | | | | | | | | | | | | | In committed_thru, we use write_pos to reset the header.start value in cases where seq is past the end of our journalq. It is therefore important that the journalq be updated atomically with write_pos (that is, under the write_lock). The call to align_bl() is moved into do_write in order to ensure that write_pos is adjusted correctly prior to write_bl(). Also, we adjust pos at the end of write_bl() such that pos \in [get_top(), header.max_size) after write_bl(). Fixes: #5020 Signed-off-by: Samuel Just <sam.just@inktank.com> Reviewed-by: Sage Weil <sage@inktank.com>
* mds: avoid assert after suicide()Sage Weil2013-05-161-2/+4
| | | | | Fixes: #5079 Signed-off-by: Sage Weil <sage@inktank.com>
* Merge branch 'next'Gary Lowell2013-05-142-1/+7
|\
| * v0.62v0.62Gary Lowell2013-05-142-1/+7
| |
* | Merge pull request #283 from dachary/wip-5058athanatos2013-05-143-28/+35
|\ \ | | | | | | | | | | | | internal documentation proofreading Reviewed-by: Sam Just <sam.just@inktank.com>
| * | reflect recent changes in the pg deletion logicLoic Dachary2013-05-141-8/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | No need to wait on DeletingStateRef for flush https://github.com/ceph/ceph/commit/d3dd99b725afaa026fe6f700ddc14a7f657f2170 Fix typos http://tracker.ceph.com/issues/5058 refs #5058 Signed-off-by: Loic Dachary <loic@dachary.org>
| * | fix typos and add hyperlink to peeringLoic Dachary2013-05-141-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | s/;/:/ s/up_acting_affected/acting_up_affected/ Add relative link to ../../peering http://tracker.ceph.com/issues/5058 refs #5058 Signed-off-by: Loic Dachary <loic@dachary.org>
| * | typo s/come/some/Loic Dachary2013-05-141-1/+1
| | | | | | | | | | | | | | | | | | http://tracker.ceph.com/issues/5058 refs #5058 Signed-off-by: Loic Dachary <loic@dachary.org>
| * | update op added to a waiting queue or discardedLoic Dachary2013-05-141-16/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The decision to discard an op happens either in OSD or in PG. The operation queue goes to a single OpWQ object if waiting_map does not impose a delay op_queue. The decision to add an op to a waiting queue regardless of its type is updated. The decision to add a CEPH_MSG_OSD_OP to a waiting queue is described in full. http://tracker.ceph.com/issues/5058 refs #5058 Signed-off-by: Loic Dachary <loic@dachary.org>
* | | doc/rados/configuration: fix [mon] osd min down report* config docsSage Weil2013-05-141-9/+11
| | | | | | | | | | | | | | | | | | | | | | | | Fix other osd -> mon section name, and note the old config value name prior to v0.62. Fixes: #5044. Signed-off-by: Sage Weil <sage@inktank.com>
* | | md/Sever.cc: fix straydn assertSage Weil2013-05-141-2/+3
| | | | | | | | | | | | | | | | | | | | | From fb222a0a1c98a4141b6d0e79eac7a41c208f7147, we only know straydn is non-null if oldin is non-null. Signed-off-by: Sage Weil <sage@inktank.com>
* | | Merge pull request #285 from dalgaaf/wip-da-CID-fixes-2-v3Sage Weil2013-05-1416-32/+84
|\ \ \ | |/ / |/| | Reviewed-by: Sage Weil <sage@inktank.com>
| * | rgw/rgw_user.cc: fix possible NULL pointer dereferenceDanny Al-Gaaf2013-05-141-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | CID 1019559 (#1 of 1): Dereference after null check (FORWARD_NULL) var_deref_model: Passing null pointer "usr" to function "RGWUser::get_store()", which dereferences it. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | mds/Server.cc: fix possible NULL pointer dereferenceDanny Al-Gaaf2013-05-141-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Assert if straydn is NULL. CID 1019554 (#2 of 2): Dereference after null check (FORWARD_NULL) var_deref_model: Passing null pointer "straydn" to function "MDSCacheObject::is_auth() const", which dereferences it. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | mds/Server.cc: fix possible NULL pointer dereferenceDanny Al-Gaaf2013-05-141-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Assert of straydn is NULL here. CID 1019558 (#1 of 1): Dereference after null check (FORWARD_NULL) var_deref_model: Passing null pointer "straydn" to function "CDentry::get_dir() const", which dereferences it. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | mds/Server.cc: fix possible NULL pointer dereferenceDanny Al-Gaaf2013-05-141-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Assert if destdn == NULL. CID 1019557 (#1 of 1): Dereference after null check (FORWARD_NULL) var_deref_model: Passing null pointer "destdn" to function "CDentry::get_dir() const", which dereferences it. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | librados/AioCompletionImpl.h: add missing LockDanny Al-Gaaf2013-05-141-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add missing Lock around code changing AioCompletionImpl::rval/ack and safe in C_AioCompleteAndSafe::finish(). CID 1019565 (#1 of 1): Data race condition (MISSING_LOCK) missing_lock: Accessing "this->c->rval" ("_ZN8librados17AioCompletionImplE.rval") requires the "Mutex._m" lock. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | src/dupstore.cc: check return value of list_collections()Danny Al-Gaaf2013-05-141-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | CID 1019545 (#1 of 1): Unchecked return value (CHECKED_RETURN) check_return: Calling function "ObjectStore::list_collections (std::vector<coll_t, std::allocator<coll_t> > &)" without checking return value (as is done elsewhere 5 out of 6 times). Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | mds/Server.cc: fix possible NULL pointer dereferenceDanny Al-Gaaf2013-05-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | CID 1019555 (#1 of 1): Dereference after null check (FORWARD_NULL) var_deref_model: Passing null pointer "in" to function "Server::_need_force_journal(CInode *, bool)", which dereferences it. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | src/rbd.cc: use 64-bits to shift 'order'Danny Al-Gaaf2013-05-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CID 1019568 (#1 of 1): Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) overflow_before_widen: Potentially overflowing expression "1 << *order" with type "int" (32 bits, signed) is evaluated using 32-bit arithmetic before being used in a context which expects an expression of type "uint64_t" (64 bits, unsigned). To avoid overflow, cast the left operand to "uint64_t" before performing the left shift. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | mon/Monitor.cc: init 'timecheck_acks' with '0' in constructorDanny Al-Gaaf2013-05-141-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | CID 1019623 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR) uninit_member: Non-static class member "timecheck_acks" is not initialized in this constructor nor in any functions that it calls. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | mon/Monitor.h: init 'crc' in constructor with '0'Danny Al-Gaaf2013-05-141-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | CID 1019624 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR) uninit_member: Non-static class member "crc" is not initialized in this constructor nor in any functions that it calls. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | mon/QuorumService.h: remove unused QuorumService::flagsDanny Al-Gaaf2013-05-141-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | CID 1019626 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR) uninit_member: Non-static class member "flags" is not initialized in this constructor nor in any functions that it calls. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | test/test_cors.cc: initialize key_type in constructorDanny Al-Gaaf2013-05-141-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | CID 1019635 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR) uninit_member: Non-static class member "kt" is not initialized in this constructor nor in any functions that it calls. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | tools/ceph.cc: cleanup memory allocated for 'buf'Danny Al-Gaaf2013-05-141-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | CID 717123 (#1-2 of 2): Resource leak (RESOURCE_LEAK) leaked_storage: Variable "buf" going out of scope leaks the storage it points to. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | tools/ceph.cc: close file descriptor in error caseDanny Al-Gaaf2013-05-141-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | CID 717122 (#1 of 1): Resource leak (RESOURCE_LEAK) leaked_handle: Handle variable "fd" going out of scope leaks the handle. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | tools/ceph.cc: close file descriptor in error caseDanny Al-Gaaf2013-05-141-0/+1
| | | | | | | | | | | | | | | | | | | | | CID 717121 (#1 of 1): Resource leak (RESOURCE_LEAK) leaked_handle: Handle variable "fd" going out of scope leaks the handle. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | test_filejournal.cc: cleanup memory in destructorDanny Al-Gaaf2013-05-141-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CID 716885 (#1 of 1): Resource leak in object (CTOR_DTOR_LEAK) alloc_new: Allocating memory by calling "new C_SafeCond(&this->lock, &this->cond, &this->done, NULL)". ctor_dtor_leak: The constructor allocates field "c" of "C_Sync" but the destructor and whatever functions it calls do not free it. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | librbd/test_librbd.cc: free memory in test_list_children()Danny Al-Gaaf2013-05-141-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CID 719581 (#7 of 7): Resource leak (RESOURCE_LEAK) CID 719581 (#6 of 7): Resource leak (RESOURCE_LEAK) leaked_storage: Variable "pools" going out of scope leaks the storage it points to. CID 719582 (#6-7 of 7): Resource leak (RESOURCE_LEAK) leaked_storage: Variable "children" going out of scope leaks the storage it points to. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | scratchtool.c: cleanup rados_t on errorDanny Al-Gaaf2013-05-141-17/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure rados_shutdown() get called also in error case. CID 717106 (#1 of 1): Resource leak (RESOURCE_LEAK) leaked_storage: Variable "cl" going out of scope leaks the storage it points to. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | test/kv_store_bench.cc: fix resource leakDanny Al-Gaaf2013-05-141-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | CID 727984 (#5 of 5): Resource leak (RESOURCE_LEAK) leaked_storage: Variable "cb_args" going out of scope leaks the storage it points to. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | filestore/test_idempotent_sequence.cc: fix FileStore leaksDanny Al-Gaaf2013-05-141-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | CID 717107 (#1 of 1): Resource leak (RESOURCE_LEAK) leaked_storage: Variable "store" going out of scope leaks the storage it points to. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | ceph-filestore-dump.cc: cleanup on error caseDanny Al-Gaaf2013-05-141-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | CID 1019589 (#1 of 1): Resource leak (RESOURCE_LEAK) leaked_storage: Variable "t" going out of scope leaks the storage it points to. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
| * | ceph-filestore-dump.cc: cleanup resource in error caseDanny Al-Gaaf2013-05-141-0/+1
|/ / | | | | | | | | | | | | | | CID 1019590 (#1 of 1): Resource leak (RESOURCE_LEAK): leaked_storage: Variable "rmt" going out of scope leaks the storage it points to. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
* | doc/release-notes: v0.61.2Sage Weil2013-05-132-0/+42
| | | | | | | | Signed-off-by: Sage Weil <sage@inktank.com>
* | Merge remote-tracking branch 'gh/next'Sage Weil2013-05-139-70/+153
|\ \ | |/
| * PG: subset_last_update must be at least log.tailSamuel Just2013-05-131-1/+1
| | | | | | | | | | | | | | Fixes: 5020 Backport: bobtail, cuttlefish Signed-off-by: Samuel Just <sam.just@inktank.com> Reviewed-by: David Zafman <david.zafman@inktank.com>
| * Merge pull request #280 from ceph/wip-4996Sage Weil2013-05-132-15/+41
| |\ | | | | | | Reviewed-by: Joao Luis <joao.luis@inktank.com>
| | * mon: fix validatation of mds ids in mon commandsSage Weil2013-05-132-15/+41
| |/ | | | | | | | | Fixes: #4996 Signed-off-by: Sage Weil <sage@inktank.com>
| * Merge pull request #278 from ceph/wip-4974Sage Weil2013-05-132-3/+36
| |\ | | | | | | | | | Reviewed-by: Greg Farnum <greg@inktank.com> Reviewed-by: Sage Weil <sage@inktank.com>
View Lorry Controller Status