summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* ReplicatedPG: copy: use aggregate return code instead of individual Op returnwip-rvalGreg Farnum2013-10-071-4/+3
| | | | | | | | | | It appears that the OSD is not filling in the individual return codes, and they should be equivalent for all purposes we care about here (the only Op we are doing is the copy-get, and if it fails we are getting its failure code). Reported-by: Sage Weil <sage@inktank.com> Signed-off-by: Greg Farnum <greg@inktank.com> Reviewed-by: Samuel Just <sam.just@inktank.com>
* os/FileStore: fix ENOENT error code for getattrs()Sage Weil2013-10-071-0/+4
| | | | | | | | | | | | In commit dc0dfb9e01d593afdd430ca776cf4da2c2240a20 the omap xattrs code moved up a block and r was no longer local to the block. Translate ENOENT -> 0 to compensate. Fix the same error in _rmattrs(). Signed-off-by: Sage Weil <sage@inktank.com> Reviewed-by: Greg Farnum <greg@inktank.com> Reviewed-by: Samuel Just <sam.just@inktank.com>
* Merge pull request #695 from ceph/wip-mon-authJoão Eduardo Luís2013-10-071-2/+2
|\ | | | | | | | | fix mon double-free when dropping unhandled messages, and allow "get monmap" messages to go through without authenticating for MonCliente::get_monmap_privately() Reviewed-by: Joao Eduardo Luis <joao.luis@inktank.com>
| * mon: allow MMonGetMap without authenticationSage Weil2013-10-061-1/+2
| | | | | | | | | | | | This is used by the MonClient::get_monmap_privately() helper. Signed-off-by: Sage Weil <sage@inktank.com>
| * mon: do not put() unhandle messageSage Weil2013-10-061-1/+0
|/ | | | | | | If we return false because we aren't handling a message, we should not put the ref. This fixes a double-free. Signed-off-by: Sage Weil <sage@inktank.com>
* mon/PGMap: make generated test instances obey new invariantSage Weil2013-10-041-0/+2
| | | | | | | As of 091809b8149c7595cbcca439c5b8b75a0c42efe1 we keep an osd_map epoch for any osd_stat update, and assert as much. Signed-off-by: Sage Weil <sage@inktank.com>
* Merge branch 'next'Gary Lowell2013-10-052-1/+7
|\
| * v0.70v0.70mark-v0.70-wipGary Lowell2013-10-042-1/+7
| |
* | doc/release-notes: v0.67.4Sage Weil2013-10-042-0/+584
| | | | | | | | Signed-off-by: Sage Weil <sage@inktank.com>
* | Merge pull request #676 from ceph/wip-start-copyGregory Farnum2013-10-042-77/+167
|\ \ | | | | | | Reviewed-by: Samuel Just <sam.just@inktank.com>
| * | ReplicatedPG: copy: add op progression outputGreg Farnum2013-10-041-0/+1
| | | | | | | | | | | | Signed-off-by: Greg Farnum <greg@inktank.com>
| * | ReplicatedPG: copy: don't leak a ctx on failed copy opsGreg Farnum2013-10-041-3/+2
| | | | | | | | | | | | Signed-off-by: Greg Farnum <greg@inktank.com>
| * | ReplicatedPG: assert that we have succeeded in do_osd_ops on copyfrom repeatsGreg Farnum2013-10-041-4/+2
| | | | | | | | | | | | | | | | | | Our callback is handling errors on its own at this point. Signed-off-by: Greg Farnum <greg@inktank.com>
| * | ReplicatedPG: copy: switch CopyCallback to use a GenContextGreg Farnum2013-10-042-48/+42
| | | | | | | | | | | | Signed-off-by: Greg Farnum <greg@inktank.com>
| * | ReplicatedPG: rename finish_copy -> finish_copyfromGreg Farnum2013-10-012-3/+3
| | | | | | | | | | | | Signed-off-by: Greg Farnum <greg@inktank.com>
| * | ReplicatedPG: copy: use CopyCallback instead of CopyOp in OpContextGreg Farnum2013-10-012-21/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In order to make this happen, we make the switch to generate the complete transaction in the generic copy code and save it into the Callback. Then in finish_copy() we just take that transaction and prepend it to the existing transaction. With that change, and by making use of the existing CopyCallback data, we no longer need to access the CopyOp from the OpContext, so we can remove it. Hurray, the pipelines are now independent! Signed-off-by: Greg Farnum <greg@inktank.com>
| * | ReplicatedPG: copy: implement CopyFromCallback::finish, remove CopyOp::ctxGreg Farnum2013-10-012-12/+26
| | | | | | | | | | | | | | | | | | | | | | | | We implement enough of the CopyFromCallback that CopyOp no longer needs a direct reference to the OpContext, so we remove it and replace all references with calls to cop->cb->complete(). Signed-off-by: Greg Farnum <greg@inktank.com>
| * | ReplicatedPG: copy: add CopyCallback pointer to CopyOp, and set it upGreg Farnum2013-10-012-7/+9
| | | | | | | | | | | | | | | | | | | | | We'll start using it in the next commit; eventually we can use the interfaces we're putting their to replace our link to the OpContext. Signed-off-by: Greg Farnum <greg@inktank.com>
| * | ReplicatedPG: copy: start defining CopyCallback structuresGreg Farnum2013-10-011-0/+57
| | | | | | | | | | | | | | | | | | | | | Outline the basic interfaces we're going to use, and implement the more obvious ones. Signed-off-by: Greg Farnum <greg@inktank.com>
| * | ReplicatedPG: copy: split up the transaction generation from the PG managementGreg Farnum2013-10-012-8/+22
| | | | | | | | | | | | Signed-off-by: Greg Farnum <greg@inktank.com>
| * | ReplicatedPG: copy: specify the temp_oid in the callerGreg Farnum2013-10-012-7/+13
| | | | | | | | | | | | Signed-off-by: Greg Farnum <greg@inktank.com>
| * | ReplicatedPG: copy: take an ObjectContextRef in start_copy and use thatGreg Farnum2013-10-012-6/+6
| | | | | | | | | | | | Signed-off-by: Greg Farnum <greg@inktank.com>
| * | ReplicatedPG: copy: add an ObjectContextRef to CopyOpGreg Farnum2013-10-012-10/+10
| | | | | | | | | | | | | | | | | | Use that instead of the OpContext::obc in copy codepaths. Signed-off-by: Greg Farnum <greg@inktank.com>
| * | ReplicatedPG: follow the same finish path for failed copy opsGreg Farnum2013-10-011-30/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't necessarily want to respond to clients with a failure if a copy got an error code. Instead, conditionally execute the success path and always launch back into execute_ctx() when the copy has stopped (either due to completion or failure). Update the COPY_FROM section so it returns the CopyOp::rval (instead of always zero) and only launches finish_copy() on success. Signed-off-by: Greg Farnum <greg@inktank.com>
| * | ReplicatedPG: copy: remove most references to OpContext from process_copy_chunkGreg Farnum2013-10-011-9/+10
| | | | | | | | | | | | Signed-off-by: Greg Farnum <greg@inktank.com>
| * | ReplicatedPG: copy: do not use an OpContext in _copy_someGreg Farnum2013-10-012-6/+6
| | | | | | | | | | | | Signed-off-by: Greg Farnum <greg@inktank.com>
| * | ReplicatedPG: update pg stats correctly when doing a copyGreg Farnum2013-10-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | The obs.oi.size needs to updated in the middle so that we actually change the stats -- this got set backwards by mistake during one of the refactors to support large objects! (See 4e29e362e7981634d751ee982144fbf602782a9a) Signed-off-by: Greg Farnum <greg@inktank.com>
* | | Merge pull request #667 from ceph/wip-6143David Zafman2013-10-043-74/+141
|\ \ \ | | | | | | | | Reviewed-by: Sage Weil <sage@inktank.com>
| * | | common, os: Perform xattr handling based on detected fs typeDavid Zafman2013-10-043-5/+86
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In FileStore::_detect_fs() store discovered filesystem type in m_fs_type Add per-filesystem filestore_max_inline_xattr_size_* variants Add per-filesystem filestore_max_inline_xattrs_* variants New function set_xattr_limits_via_conf() Set m_filestore_max_inline_xattr_size based on override or fs type Set m_filestore_max_inline_xattrs based on override or fs type Handle conf change of any relevant value by calling set_xattr_limits_via_conf() Change filestore_max_inline_xattr_size to override if non-zero Change filestore_max_inline_xattrs to override if non-zero Fixes: #6143 Signed-off-by: David Zafman <david.zafman@inktank.com>
| * | | common,os: Remove filestore_xattr_use_omap optionDavid Zafman2013-10-042-70/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now we operate just like when this was set to true Fixes: #6143 Signed-off-by: David Zafman <david.zafman@inktank.com>
* | | | Merge pull request #692 from ceph/wip-5992-2athanatos2013-10-0413-83/+375
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | Wip 5992 2 Reviewed-by: Sage Weil <sage@inktank.com>
| * | | | ReplicatedPG: lock snapdir obc during writeSamuel Just2013-10-042-4/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Otherwise, we won't block properly in prep_push_backfill_object. Signed-off-by: Samuel Just <sam.just@inktank.com>
| * | | | PGLog: on split, leave log head aloneSamuel Just2013-10-042-7/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This way last_update doesn't go backwards. Fixes: 6447 Signed-off-by: Samuel Just <sam.just@inktank.com>
| * | | | FileStore: make _setattrs not return -ENOENT most of the timeSamuel Just2013-10-041-0/+2
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Samuel Just <sam.just@inktank.com>
| * | | | ReplicatedPG: add debugging in recover_replicas for objects added for backfillSamuel Just2013-10-041-0/+11
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Samuel Just <sam.just@inktank.com>
| * | | | ReplicatedPG,PG: use PGBackend methods for getattrSamuel Just2013-10-042-16/+28
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Samuel Just <sam.just@inktank.com>
| * | | | ReplicatedPG,PG: adapt collection_list* users to PGBackend interfaceSamuel Just2013-10-042-20/+20
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Samuel Just <sam.just@inktank.com>
| * | | | PG,ReplicatedPG: expose PGBackend to PGSamuel Just2013-10-042-0/+6
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Samuel Just <sam.just@inktank.com>
| * | | | PG.cc: remove leading empty spaceSamuel Just2013-10-041-1/+0
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Samuel Just <sam.just@inktank.com>
| * | | | PGBackend,ReplicatedBackend: add interfaces for scanning the pgSamuel Just2013-10-043-0/+112
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will be important since the erasure coded pg will have a different on-disk format than the replicated backend. Signed-off-by: Samuel Just <sam.just@inktank.com>
| * | | | ReplicatedPG: don't rescan the local collection if we can avoid itSamuel Just2013-10-043-17/+78
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Samuel Just <sam.just@inktank.com>
| * | | | common/hobject: add is_degenerate methodSamuel Just2013-10-041-0/+4
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Samuel Just <sam.just@inktank.com>
| * | | | PGMap: calc_min_last_epoch_clean() will now also use osd_epochsSamuel Just2013-10-041-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't want to trim past the current osd map for any up osd. osd_epochs provides a lower bound for that epoch for each osd. Fixes: 5869 Signed-off-by: Samuel Just <sam.just@inktank.com>
| * | | | PGMap,PGMonitor: maintain mapping of osd to recent stat epochSamuel Just2013-10-043-19/+87
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also, osd_stat will be empty for out osd. When an osd is marked out, rather than remove it from osd_stat, we instead 0 out the structure. This patch also makes osd_stat_updates and osd_stat_rm private. This should make it simpler to enforce invariants on these mappings. Each up osd will have a mapping since out osds are now included as empty stats. Signed-off-by: Samuel Just <sam.just@inktank.com>
* | | | | Merge pull request #690 from ceph/wip-fuseSage Weil2013-10-045-22/+128
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | a few ceph-fuse fixes Reviewed-by: Sage Weil <sage@inktank.com> Reviewed-by: Yan, Zheng <zheng.z.yan@intel.com>
| * | | | client: remove requests from closed MetaSessionSage Weil2013-10-022-16/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we get a CLOSED message on a session, remove/kick any requests on that session before tearing it down. Otherwise, we get a crash like 2013-09-26 03:51:44.704446 7f4d35a46700 10 client.4111 kick_requests for mds.0 2013-09-26 03:51:45.014156 7f4d35a46700 -1 ./include/xlist.h: In function 'xlist<T>::~xlist() [with T = MetaRequest*]' thread 7f4d35a46700 time 2013-09-26 03:51:44.751908 ./include/xlist.h: 69: FAILED assert(_size == 0) ceph version 0.61.5 (8ee10dc4bb73bdd918873f29c70eedc3c7ef1979) 1: (MetaSession::~MetaSession()+0x425) [0x4e0105] 2: (Client::_closed_mds_session(MetaSession*)+0x116) [0x48a696] 3: (Client::handle_client_session(MClientSession*)+0x2bb) [0x48bf5b] 4: (Client::ms_dispatch(Message*)+0x56b) [0x4bfa0b] 5: (DispatchQueue::entry()+0x3f1) [0x621b31] 6: (DispatchQueue::DispatchThread::entry()+0xd) [0x6191bd] 7: (()+0x7851) [0x7f4d3c168851] 8: (clone()+0x6d) [0x7f4d3b09d90d] Note that this can happen if we fail to reconnect do an MDS during its reconnect interval. If that happens, we probably have inodes in our cache with no caps and things are generally not going to work very well. This is but one step in improving the situation. Separate out the two methods since they share little/no behavior. Signed-off-by: Sage Weil <sage@inktank.com>
| * | | | ceph: Update FUSE_USE_VERSION from 26 to 30.majianpeng2013-10-023-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When compiling, it met this error: >In file included from /usr/local/include/fuse/fuse.h:19:0, > from client/fuse_ll.cc:17: >/usr/local/include/fuse/fuse_common.h:474:4: error: #error only API >version 30 or greater is supported Update FUSE_USE_VERSION from 26 to 30. Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
| * | | | client: trim deleted inodeYan, Zheng2013-10-023-3/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previous patch makes MDS send notification to clients when an inode is deleted. When receiving a such notification, we invalidate any dentry link to the deleted inode. If there is no other reference to the inode, the inode gets trimmed. For cephfs fuse client, we use fuse_lowlevel_notify_inval_entry() or fuse_lowlevel_notify_delete() to notify the kernel to trim the deleted inode. (this is not completely reliable because we play unlink/link tricks when handle MDS replies. it's difficult to keep the user space cache and kernel dcache in sync) Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com>
* | | | | Merge pull request #689 from ceph/wip-6254-modelathanatos2013-10-042-3/+11
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | ceph_test_rados: notice read error; do not race rollback with snap_delete Reviewed-by: Samuel Just <sam.just@inktank.com>
| * | | | | ceph_test_rados: do not let rollback race with snap deletewip-6254-modelSage Weil2013-10-032-3/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Note that the OSD behaves in a weird way when you rollback to a non- existent snap, so the test probably isn't the only party at fault here. Fixes (test half of): #6254 Backport: dumpling, cuttlefish Signed-off-by: Sage Weil <sage@inktank.com>