summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* msg/Message.h: fix C-style pointer castingwip.cppcheckerDanny Al-Gaaf2013-02-051-2/+2
| | | | | | Replace C-style pointer casting with correct static_cast<>(). Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
* messages/MOSDRepScrub.h: initialize member variable in constructorDanny Al-Gaaf2013-02-051-1/+1
| | | | | | | Initialize chunky and deep bool member variables in the constructor with false. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
* include/xlist.h: fix C-style pointer castingDanny Al-Gaaf2013-02-051-3/+3
| | | | | | Replace C-style pointer casting with correct static_cast<>(). Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
* include/types.h: change operator<< function parameterDanny Al-Gaaf2013-02-051-1/+1
| | | | | | | Fix "Function parameter 'v' should be passed by reference." from cppchecker. Use 'const pair<A,B>& v' similar to the other operator<< in this file. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
* include/buffer.h: fix operator=Danny Al-Gaaf2013-02-051-3/+7
| | | | | | | Fix operator=: return "iterator&" instead of 'iterator'. Also set last_p and other.append_buffer and check if 'this' equals 'other' before set anything. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
* obj_bencher.cc: use vector instead of VLA'sDanny Al-Gaaf2013-02-051-6/+7
| | | | | | Fix "variable length array of non-POD element type" error. (-Wvla) Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
* ceph_crypto.cc: remove unused shutdown() outside crypto ifdef'sDanny Al-Gaaf2013-02-051-1/+0
| | | | | | | | | Fix "out-of-line declaration of a member must be a definition [-Wout-of-line-declaration]". Remove ceph::crypto::shutdown() outside the crypto related ifdef's. Without nss or cryptopp configure will fail anyways. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
* WorkQueue.h: fix castDanny Al-Gaaf2013-02-051-2/+2
| | | | | | Replace C-style pointer casting with correct static_cast<>(). Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
* Merge remote-tracking branch 'gh/wip-osd-commands'Sage Weil2013-02-058-5/+275
|\ | | | | | | | | Reviewed-by: Dan Mick <dan.mick@inktank.com> Reviewed-by: Joao Luis <joao.luis@inktank.com>
| * mon: move list_rules into CrushWrapper methodSage Weil2013-02-051-5/+1
| | | | | | | | Signed-off-by: Sage Weil <sage@inktank.com>
| * crush: add list_rules() methodSage Weil2013-02-052-0/+10
| | | | | | | | Signed-off-by: Sage Weil <sage@inktank.com>
| * qa: add workunits/mon/crush_ops.shSage Weil2013-02-051-0/+23
| | | | | | | | | | | | Test creating, listing, removing crush rules via the mon. Signed-off-by: Sage Weil <sage@inktank.com>
| * mon: 'osd crush rule rm <name>'Sage Weil2013-02-051-0/+46
| | | | | | | | Signed-off-by: Sage Weil <sage@inktank.com>
| * osdmap: method to check if a crush ruleset is in useSage Weil2013-02-052-0/+10
| | | | | | | | Signed-off-by: Sage Weil <sage@inktank.com>
| * crush: remove_rule() methodSage Weil2013-02-052-0/+15
| | | | | | | | Signed-off-by: Sage Weil <sage@inktank.com>
| * crush: factor out (trivial) crush_destroy_rule()Sage Weil2013-02-052-1/+7
| | | | | | | | Signed-off-by: Sage Weil <sage@inktank.com>
| * mon: 'osd crush rules list|ls'Sage Weil2013-02-051-0/+27
| | | | | | | | Signed-off-by: Sage Weil <sage@inktank.com>
| * mon: 'osd crush dump'Sage Weil2013-02-051-0/+11
| | | | | | | | Signed-off-by: Sage Weil <sage@inktank.com>
| * crush: factor out dump_rules from dumpSage Weil2013-02-052-1/+7
| | | | | | | | Signed-off-by: Sage Weil <sage@inktank.com>
| * mon: 'osd crush rule create-simple <name> <root> <failure_domain_type>'Sage Weil2013-02-051-0/+42
| | | | | | | | | | | | Simple command to create simple rules. Signed-off-by: Sage Weil <sage@inktank.com>
| * crush: add_simple_rule() commandSage Weil2013-02-052-0/+43
| | | | | | | | | | | | | | Method to create a very generic rule the distributes objects across the specified failure domain type underneath the given root. Signed-off-by: Sage Weil <sage@inktank.com>
| * crush: fix get_rule_id() return valueSage Weil2013-02-051-1/+1
| | | | | | | | | | | | There are 0 callers, yay! Signed-off-by: Sage Weil <sage@inktank.com>
| * crush: add rule_exists()Sage Weil2013-02-051-2/+5
| | | | | | | | Signed-off-by: Sage Weil <sage@inktank.com>
| * mon: 'osd find <osd-id>' commandSage Weil2013-02-051-0/+32
| | | | | | | | | | | | | | Simple command to find the ip, host, rack, etc. for an OSD. This is better than 'ceph osd dump | grep ^osd.NNN\ '. Signed-off-by: Sage Weil <sage@inktank.com>
* | Merge branch 'wip-2753-fsync-errors'Greg Farnum2013-02-052-14/+53
|\ \ | |/ |/| | | Reviewed-by: Sage Weil <sage@inktank.com>
| * client: return errors to the user if fsync failsGreg Farnum2013-01-292-14/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To do so, we allow callers of _flush(Inode) to pass in a Context as well. This Context is then given to the ObjectCacher as the completion callback instead of the C_Client_PutInode that it uses by default. _fsync() passes in a SafeCond which is pointing to its return code, and presto! The return code gets a failure if the Objecter returns any. To preserve existing semantics, _fsync() (and any similar caller) is now required to take a reference to the inode. However, this is a behavioral change: previously, a call to fsync in the userspace code would simply spin as it waited for all the data to flush out. That obviously wasn't desirable, but now a user can call fsync, ignore the return value, and think that everything is hunky-dory when in fact the client is repeatedly trying to flush out the dirty data. Hrm... This fixes the fsync case of #2753 for ceph-fuse. Signed-off-by: Greg Farnum <greg@inktank.com>
| * client: Wait for caps to flush when flushing metadata.Greg Farnum2013-01-291-1/+1
| | | | | | | | | | | | | | | | | | | | Embarrassingly, this conditional has been backwards since I committed it in 818e7939. But we want to do the wait when we did do the flush and are syncing metadata. As the code previously stood, we only did the wait when we didn't care, and it didn't wait anyway since it was waiting for 0. So, bad all around. Signed-off-by: Greg Farnum <greg@inktank.com>
* | Merge pull request #39 from dachary/masterGregory Farnum2013-02-055-1/+267
|\ \ | | | | | | Relax Throttle::_reset_max conditions and associated unit tests
| * | Relax Throttle::_reset_max conditions and associated unit testsLoic Dachary2013-02-055-1/+267
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removes a condition in Throttle::_reset_max by which the waiting queue is only Signal()ed if the new maximum is lower than the current maximum. There is no evidence of a use case where such a restriction would be useful. In addition waking up a thread when the maximum increases gives it a chance to immediately continue the suspended process instead of waiting for the next put(). Create a new test file covering 100% of src/Throttle.{cc,h} lines of code. The following methods are tested: * Throttle::Throttle with and without a maximum * Throttle::~Throttle when each pending Cond is deleted * Throttle::take * Throttle::get when updating the maximum ( lower or higher ), when going to sleep waiting for the count to lower under the maximum, when going to sleep because another thread is already asleep waiting * Throttle::get_or_fail when there is no maximum, when requesting a count that is larger than the maximum, either when the current value is under the maximum or above the maximum. * Throttle::wait when used to reset the maximum and wake up another thread asleep waiting All asserts checking the arguments sanity are exercised ( negative argument for Throttle::take etc. ). Adds the LGPLv2+ licensing terms to COPYING along with the others. Adds a Contributors section to the AUTHORS file. Notes: Testing asserts outputs verbose error messages that should be silenced but it does not seem possible. Signed-off-by: Loic Dachary <loic@dachary.org>
* | | os: default to 'journal aio = true'Sage Weil2013-02-051-1/+1
| | | | | | | | | | | | | | | | | | Hooray, testing indicates this is a win! Signed-off-by: Sage Weil <sage@inktank.com>
* | | Merge pull request #36 from cmello/masterGregory Farnum2013-02-051-2/+2
|\ \ \ | | | | | | | | libexpat dependency
| * | | Added libexpat dependencyCesar Mello2013-01-261-2/+2
| | | |
* | | | Merge pull request #38 from alram/masterJohn Wilkins2013-02-051-2/+4
|\ \ \ \ | |_|/ / |/| | | Fixes in ./docs/radosgw/config.rst
| * | | Edit endpoint-create in ./doc/radosgw/config.rstAlexandre Marangone2013-02-041-1/+2
| | | | | | | | | | | | internalurl and adminurl are mandatory. Typo in publicurl.
| * | | Edit rgw keystone url in ./doc/radosgw/config.rstAlexandre Marangone2013-02-041-1/+1
| | | | | | | | | | | | Won't work with the public port, it needs to be the admin port.
| * | | Note on host in ./doc/radosgw/config.rstAlexandre Marangone2013-02-041-0/+1
|/ / / | | | | | | | | | Some people have configured host with a FQDN or an IP which prevents /etc/init.d/radosgw start to launch the daemon.
* | | doc: Updated to note bobtail supports RGW + Keystone.John Wilkins2013-02-041-4/+3
| | | | | | | | | | | | Signed-off-by: John Wilkins <john.wilkins@inktank.com>
* | | cli test: add pg deep-scrub option to testGary Lowell2013-02-041-0/+1
| | | | | | | | | | | | Signed-off-by: Gary Lowell <gary.lowell@inktank.com>
* | | Add "pg deep-scrub..." missing from ceph usage outputDavid Zafman2013-02-041-0/+1
| | | | | | | | | | | | | | | Signed-off-by: David Zafman <david.zafman@inktank.com> Reviewed-by: Samuel Just <sam.just@inktank.com>
* | | rgw: fix setting of NULL to stringYehuda Sadeh2013-02-042-37/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes: #3777 s->env->get() returns char * and not string and can return NULL. Also, remove some old unused code. Signed-off-by: Yehuda Sadeh <yehuda@inktank.com> Reviewed-by: Greg Farnum <greg@inktank.com>
* | | xattr_bench.cc: remove twice included <time.h>Danny Al-Gaaf2013-02-041-1/+0
| | | | | | | | | | | | | | | | | | Cleanup includes, remove twice included <time.h>. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
* | | ceph-filestore-dump.cc: remove twice included <iostream>Danny Al-Gaaf2013-02-041-1/+0
| | | | | | | | | | | | | | | | | | Cleanup includes, remove twice included <iostream>. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
* | | testmsgr.cc: remove twice included <sys/stat.h>Danny Al-Gaaf2013-02-041-1/+0
| | | | | | | | | | | | | | | | | | Cleanup includes, remove twice included <sys/stat.h>. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
* | | perf_counters.cc: remove twice included header filesDanny Al-Gaaf2013-02-041-2/+0
| | | | | | | | | | | | | | | | | | | | | Cleanup includes, remove twice included "global/global_init.h" and "common/ceph_context.h". Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
* | | testxattr.cc: remove twice included <iostream>Danny Al-Gaaf2013-02-041-1/+0
| | | | | | | | | | | | | | | | | | Cleanup includes, remove twice included <iostream>. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
* | | workload_generator.cc: remove twice included "common/debug.h"Danny Al-Gaaf2013-02-041-1/+0
| | | | | | | | | | | | | | | | | | Cleanup includes, remove twice included "common/debug.h" Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
* | | test_idempotent.cc: remove twice included "os/FileStore.h"Danny Al-Gaaf2013-02-041-1/+0
| | | | | | | | | | | | | | | | | | Cleanup includes, remove twice included "os/FileStore.h". Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
* | | tp_bench.cc: remove twice included <iostream>Danny Al-Gaaf2013-02-041-1/+0
| | | | | | | | | | | | | | | | | | Cleanup includes, remove twice included <iostream>. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
* | | small_io_bench*.cc: remove twice included <iostream>Danny Al-Gaaf2013-02-044-4/+0
| | | | | | | | | | | | | | | | | | Cleanup includes, remove twice included <iostream>. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
* | | MDS.cc: remove twice included common/errno.hDanny Al-Gaaf2013-02-041-1/+0
| | | | | | | | | | | | | | | | | | Cleanup includes, remove twice included common/errno.h. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>