delta/classpath.git/java, branch master git.savannah.gnu.org: git/classpath.git Cleanup warnings in java.util.Collections. 2016-03-18T20:29:35+00:00 Andrew John Hughes gnu_andrew@member.fsf.org 2016-03-18T20:29:35+00:00 5a1dcb13eaa6040be54cf3bc6772470a397b2c79 2016-03-18 Andrew John Hughes <gnu_andrew@member.fsf.org> Cleanup warnings in java.util.Collections. * java/util/Collections.java: (EMPTY_SET): Suppress warnings generated by this legacy raw type. (EMPTY_LIST): Likewise. (EMPTY_MAP): Likewise. (compare(T, T, Comparator): Suppress warning generated by casting to Comparable. (binarySearch(List, Comparator)): Remove unneeded casts. (reverse(List)): Suppress warnings when casting to ListIterator<Object>. Cast is necessary as lists are modified. (reverseOrder(Comparator)): Return reverseOrder() rather than rcInstance. (reverseOrder()): Create appropriately typed ReverseComparator rather than using set instance. (rcInstance): Removed. (ReverseComparator.compare(T,T)): Suppress warnings from casting to Comparable<T>. (rotate(List,int)): Suppress warnings when casting to List<Object>. Cast is necessary to modify list. (shuffle(List,Random)): Likewise. (disjoint(Collection,Collection)): Remove unnecessary casting. (sort(List,Comparator)): Suppress warnings when casting the returned array. Arrays of a generic type can not be created. (swap(List,int,int)): Suppress warnings when casting list to List<Object>. This is necessary to use the set method. (entrySet().SynchronizedMapEntry): Type should not have its own type parameters which hide those of the map. (entrySet().SynchronizedSet.iterator()): Remove type parameters from SynchronizedMapEntry creation. (UnmodifiableList.list): Retain input type parameter so as to avoid casting. (UnmodifiableList.UnmodifiableList): Remove cast. (UnmodifiableList.li): Retain input type parameter so as to avoid casting. (UnmodifiableListIterator(ListIterator)): Likewise. (UnmodifiableMap(Map)): Suppress warnings from casting down to Map<K,V>. (UnmodifiableMap.entrySet()): Remove type parameters from UnmodifiableEntrySet creation. (UnmodifiableMap.UnmodifiableEntrySet): Remove type parameters and make instance-specific so we can use the UnmodifiableMap's type parameters. (UnmodifiableMap.UnmodifiableEntrySet.UnmodifiableMapEntry): Likewise. (UnmodifiableMap.UnmodifiableEntrySet.UnmodifiableMapEntry.e): Retain input type parameters so as to avoid casting. (UnmodifiableMap.UnmodifiableEntrySet.UnmodifiableMapEntry.UnmodifiableMapEntry(Map.Entry)): Likewise. (UnmodifiableMap.UnmodifiableEntrySet.UnmodifiableEntrySet(Set)): Likewise. (UnmodifiableMap.UnmodifiableEntrySet.UnmodifiableIterator.next()): Remove type parameters from UnmodifiableMapEntry creation. (UnmodifiableMap.toArray()): Likewise and improve method structure. (UnmodifiableMap.toArray(S[])): Remove type parameters from UnmodifiableMapEntry and suppress warnings from casting array members. (UnmodifiableSortedMap.sm): Retain input type parameters so as to avoid casting. (UnmodifiableSortedMap.UnmodifiableSortedMap(SortedMap)): Remove cast. (CheckedList.addAll(int,Collection)): Replace iterator with for-each loop, removing the need for casting. (CheckedMap.entrySet()): Remove type parameters from CheckedEntrySet creation and klass argument. (CheckedMap.CheckedEntrySet): Don't create additional type parameters, use those of the containing map as a instance class, not a static class. (keyType): Type should be K to match enclosing CheckedMap. (valueType): Type should be V to match enclosing CheckedMap. (CheckedMap.CheckedEntrySet.CheckedEntrySet(Set,Class,Class)): Suppress warnings when casting Map.Entry class. (CheckedMap.CheckedEntrySet.iterator()): Make return type Map.Entry<K,V> and create corresponding CheckedIterator instance. (CheckedMap.CheckedEntrySet.CheckedIterator.next()): Likewise with Map.Entry instance. (CheckedMap.CheckedEntrySet.CheckedIterator.Map.Entry.getKey()): Make return type K. (CheckedMap.CheckedEntrySet.CheckedIterator.Map.Entry.getValue()): Make return type V. (CheckedMap.CheckedEntrySet.CheckedIterator.Map.Entry.setValue(Object)): Likewise. (CheckedMap.putAll(Map)): Use for-each loop instead of Iterator, avoiding casting. 
2016-03-18  Andrew John Hughes  <gnu_andrew@member.fsf.org>

	Cleanup warnings in java.util.Collections.
	* java/util/Collections.java:
	(EMPTY_SET): Suppress warnings generated by this
	legacy raw type.
	(EMPTY_LIST): Likewise.
	(EMPTY_MAP): Likewise.
	(compare(T, T, Comparator): Suppress warning
	generated by casting to Comparable.
	(binarySearch(List, Comparator)): Remove unneeded
	casts.
	(reverse(List)): Suppress warnings when casting
	to ListIterator<Object>. Cast is necessary as
	lists are modified.
	(reverseOrder(Comparator)): Return reverseOrder()
	rather than rcInstance.
	(reverseOrder()): Create appropriately typed
	ReverseComparator rather than using set instance.
	(rcInstance): Removed.
	(ReverseComparator.compare(T,T)): Suppress warnings
	from casting to Comparable<T>.
	(rotate(List,int)): Suppress warnings when casting
	to List<Object>. Cast is necessary to modify list.
	(shuffle(List,Random)): Likewise.
	(disjoint(Collection,Collection)): Remove unnecessary
	casting.
	(sort(List,Comparator)): Suppress warnings when casting
	the returned array. Arrays of a generic type can not
	be created.
	(swap(List,int,int)): Suppress warnings when casting
	list to List<Object>. This is necessary to use the
	set method.
	(entrySet().SynchronizedMapEntry): Type should not have its
	own type parameters which hide those of the map.
	(entrySet().SynchronizedSet.iterator()): Remove type
	parameters from SynchronizedMapEntry creation.
	(UnmodifiableList.list): Retain input type parameter
	so as to avoid casting.
	(UnmodifiableList.UnmodifiableList): Remove cast.
	(UnmodifiableList.li): Retain input type parameter
	so as to avoid casting.
	(UnmodifiableListIterator(ListIterator)): Likewise.
	(UnmodifiableMap(Map)): Suppress warnings from casting
	down to Map<K,V>.
	(UnmodifiableMap.entrySet()): Remove type parameters
	from UnmodifiableEntrySet creation.
	(UnmodifiableMap.UnmodifiableEntrySet): Remove type
	parameters and make instance-specific so we can
	use the UnmodifiableMap's type parameters.
	(UnmodifiableMap.UnmodifiableEntrySet.UnmodifiableMapEntry):
	Likewise.
	(UnmodifiableMap.UnmodifiableEntrySet.UnmodifiableMapEntry.e):
	Retain input type parameters so as to avoid casting.
	(UnmodifiableMap.UnmodifiableEntrySet.UnmodifiableMapEntry.UnmodifiableMapEntry(Map.Entry)):
	Likewise.
	(UnmodifiableMap.UnmodifiableEntrySet.UnmodifiableEntrySet(Set)):
	Likewise.
	(UnmodifiableMap.UnmodifiableEntrySet.UnmodifiableIterator.next()):
	Remove type parameters from UnmodifiableMapEntry creation.
	(UnmodifiableMap.toArray()): Likewise and improve method
	structure.
	(UnmodifiableMap.toArray(S[])): Remove type parameters from
	UnmodifiableMapEntry and suppress warnings from casting
	array members.
	(UnmodifiableSortedMap.sm): Retain input type parameters
	so as to avoid casting.
	(UnmodifiableSortedMap.UnmodifiableSortedMap(SortedMap)):
	Remove cast.
	(CheckedList.addAll(int,Collection)): Replace iterator with for-each
	loop, removing the need for casting.
	(CheckedMap.entrySet()): Remove type parameters from CheckedEntrySet
	creation and klass argument.
	(CheckedMap.CheckedEntrySet): Don't create additional
	type parameters, use those of the containing map as
	a instance class, not a static class.
	(keyType): Type should be K to match enclosing CheckedMap.
	(valueType): Type should be V to match enclosing CheckedMap.
	(CheckedMap.CheckedEntrySet.CheckedEntrySet(Set,Class,Class)):
	Suppress warnings when casting Map.Entry class.
	(CheckedMap.CheckedEntrySet.iterator()): Make return type
	Map.Entry<K,V> and create corresponding CheckedIterator instance.
	(CheckedMap.CheckedEntrySet.CheckedIterator.next()): Likewise
	with Map.Entry instance.
	(CheckedMap.CheckedEntrySet.CheckedIterator.Map.Entry.getKey()):
	Make return type K.
	(CheckedMap.CheckedEntrySet.CheckedIterator.Map.Entry.getValue()):
	Make return type V.
	(CheckedMap.CheckedEntrySet.CheckedIterator.Map.Entry.setValue(Object)):
	Likewise.
	(CheckedMap.putAll(Map)): Use for-each loop instead of Iterator,
	avoiding casting.
Revert undocumented changes accidentally included with last commit. 2016-02-16T02:00:13+00:00 Andrew John Hughes gnu_andrew@member.fsf.org 2015-08-13T02:00:30+00:00 515871961ff934601b190bb32bf4fc42ddcf7e4d 






Mention PR66376.
2015-06-19T15:04:59+00:00

Andrew John Hughes
gnu_andrew@member.fsf.org

2015-06-19T15:04:59+00:00

6bc8d84e4b0527f680b78a9a0c808cda74d4933d

2015-06-19  Andrew John Hughes  <gnu_andrew@member.fsf.org>

	* NEWS: Mention PR66376.





2015-06-19  Andrew John Hughes  <gnu_andrew@member.fsf.org>

	* NEWS: Mention PR66376.







Cleanup the majority of the warnings in the gnu.java.security, java.security, javax.security and gnu.javax.security classes.
2015-03-11T21:18:20+00:00

Andrew John Hughes
gnu_andrew@member.fsf.org

2015-03-11T21:16:43+00:00

229a0915fbb027f0bbb4ce9b0981bc4cd2d5472e

2015-03-11  Andrew John Hughes  <gnu_andrew@member.fsf.org>

	* configure.ac:
	(ECJ_WARNINGS): Turn off parameter assignment,
	autoboxing and overridding without a super method
	call warnings for now.
	* gnu/java/security/OID.java:
	(OID(int[],boolean)): Remove unnecessary cast on clone() call.
	(getIDs()): Likewise.
	(getDER()): Likewise.
	(clone()): Add @Override.
	(toString()): Add @Override. Remove unncessary else clause.
	(hashCode()): Add @Override.
	(equals(Object)): Likewise.
	(compareTo(OID)): Likewise.
	* gnu/java/security/PolicyFile.java:
	(getPermissions(CodeSource)): Add @Override.
	(refresh()): Likewise and on anonymous inner class run() method.
	(toString()): Add @Override.
	(parse(URL)): Throw exception if p is null, and suppress associated
	warning, as exception is thrown via error method. Add default
	empty case to switch method. Call error method with the exception,
	not the result of its toString() method. Remove unneeded else block.
	(expand(String)): Avoid shadowing the prop variable.
	(error(URL,StreamTokenizer,Throwable)): Add new variant that allows
	the cause to be included.
	* gnu/java/security/Properties.java:
	(init()): Avoid unnecessary casts.
	(handleBooleanProperty(String)): Make static.
	* gnu/java/security/action/GetPropertyAction.java:
	(run()): Add @Override.
	* gnu/java/security/action/GetSecurityPropertyAction.java:
	(run()): Add @Override.
	* gnu/java/security/ber/BERReader.java:
	(read()): Add @Override. Remove unnecessary else clause.
	* gnu/java/security/ber/BERValue.java:
	(getLength()): Add @Override.
	* gnu/java/security/der/BitString.java:
	(toByteArray()): Remove unnecessary cast on clone() call.
	(getShiftedByteArray()): Likewise.
	(toBooleanArray()): Likewise.
	(clone(): Add @Override.
	(hashCode()): Likewise.
	(equals(Object)): Likewise.
	(toString()): Likewise.
	* gnu/java/security/der/DERReader.java:
	(makeTime(int,byte[])): Make static. Mark fall-through
	cases in switch statement. Add default case which throws
	an exception.
	* gnu/java/security/der/DERValue.java:
	(DERValue(int,int,Object,byte[])): Remove unnecessary cast on clone() call.
	(getValueAs(int)): Avoid shadowing of encoded variable.
	(getEncoded()): Remove unnecessary cast on clone() call.
	(toString()): Add @Override.
	* gnu/java/security/hash/BaseHash.java:
	(name()): Add @Override.
	(hashSize()): Likewise.
	(blockSize()): Likewise.
	(update(byte)): Likewise.
	(update(byte[])): Likewise.
	(update(byte[],int,int)): Likewise.
	(digest()): Likewise.
	(reset()): Likewise.
	(clone()): Likewise.
	(selfTest()): Likewise.
	* gnu/java/security/hash/Haval.java:
	(Haval(Haval)): Remove unnecessary cast on clone() call.
	(clone()): Add @Override.
	(transform(byte[],int)): Likewise.
	(padBuffer()): Likewise.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(selfTest()): Likewise.
	(tailorDigestBits()): Add empty default case to switch statement.
	(FF5(int,int,int,int,int,int,int,int,int,int)): Make static.
	(f1(int,int,int,int,int,int,int)): Likewise.
	(f2(int,int,int,int,int,int,int)): Likewise.
	(f3(int,int,int,int,int,int,int)): Likewise.
	(f4(int,int,int,int,int,int,int)): Likewise.
	(f5(int,int,int,int,int,int,int)): Likewise.
	* gnu/java/security/hash/MD2.java:
	(MD2(MD2)): Remove unnecessary casts on clone() call.
	(clone()): Add @Override.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(selfTest())): Likewise.
	(padBuffer()): Likewise.
	(transform(byte[],int)): LIkewise.
	* gnu/java/security/hash/MD4.java:
	(MD4(MD4)): Remove unncessary casts on clone() call.
	(clone()): Add @Override.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(selfTest())): Likewise. Avoid shadowing d variable.
	(padBuffer()): Likewise.
	(transform(byte[],int)): LIkewise.
	* gnu/java/security/hash/MD5.java:
	(MD5(MD5)): Remove unnecessary casts on clone() call.
	(clone()): Add @Override.
	(transform(byte[],int)): LIkewise.
	(padBuffer()): Likewise.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(selfTest())): Likewise.
	* gnu/java/security/hash/RipeMD128.java:
	(RipeMD128(RipeMD128)): Remove unnecessary casts on clone() call.
	(clone()): Add @Override.
	(transform(byte[],int)): LIkewise.
	(padBuffer()): Likewise.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(selfTest())): Likewise.
	* gnu/java/security/hash/RipeMD160.java:
	(RipeMD160(RipeMD160)): Remove unnecessary casts on clone() call.
	(clone()): Add @Override.
	(transform(byte[],int)): LIkewise.
	(padBuffer()): Likewise.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(selfTest())): Likewise.
	* gnu/java/security/hash/Sha160.java:
	(Sha160(Sha160)): Remove unnecessary casts on clone() call.
	(clone()): Add @Override.
	(transform(byte[],int)): LIkewise.
	(padBuffer()): Likewise.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(selfTest())): Likewise.
	* gnu/java/security/hash/Sha256.java:
	(Sha256(Sha256)): Remove unnecessary casts on clone() call.
	(clone()): Add @Override.
	(transform(byte[],int)): LIkewise.
	(padBuffer()): Likewise.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(selfTest())): Likewise.
	* gnu/java/security/hash/Sha384.java:
	(Sha384(Sha384)): Remove unnecessary casts on clone() call.
	(clone()): Add @Override.
	(transform(byte[],int)): LIkewise.
	(padBuffer()): Likewise.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(selfTest())): Likewise.
	* gnu/java/security/hash/Sha512.java:
	(Sha512(Sha512)): Remove unnecessary casts on clone() call.
	(clone()): Add @Override.
	(transform(byte[],int)): LIkewise.
	(padBuffer()): Likewise.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(selfTest())): Likewise.
	* gnu/java/security/hash/Tiger.java:
	(Tiger(Tiger)): Remove unnecessary casts on clone() call.
	(clone()): Add @Override.
	(selfTest())): Likewise.
	(padBuffer()): Likewise.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(transform(byte[],int)): LIkewise.
	* gnu/java/security/hash/Whirlpool.java,
	(Whirlpool(Whirlpool)): Remove unnecessary casts on clone() call.
	(clone()): Add @Override.
	(transform(byte[],int)): LIkewise.
	(padBuffer()): Likewise.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(selfTest())): Likewise.
	* gnu/java/security/jce/hash/MessageDigestAdapter.java:
	(clone()): Add @Override.
	(engineGetDigestLength()): Likewise.
	(engineUpdate(byte)): Likewise.
	(engineUpdate(byte[],int,int)): Likewise.
	(engineDigest()): Likewise.
	(engineDigest(byte[],int,int)): Likewise.
	(engineReset()): Likewise.
	* gnu/java/security/jce/sig/DSSKeyPairGeneratorSpi.java:
	(initialize(int,SecureRandom)): Add @Override.
	(initialize(AlgorithmParameterSpec,SecureRandom)): Likewise.
	* gnu/java/security/jce/sig/DSSParametersGenerator.java:
	(engineInit(int,SecureRandom)): Add @Override.
	(engineInit(AlgorithmParameterSpec,SecureRandom)): Likewise.
	(engineGenerateParameters()): Likewise.
	* gnu/java/security/jce/sig/EncodedKeyFactory.java:
	(decodeDSSPublicKey(DSAPublicKeySpec)): Make static.
	(decodeRSAPublicKey(RSAPublicKeySpec)): Likewise.
	(decodeDHPublicKey(DHPublicKeySpec)): Likewise.
	(decodeDHPublicKey(byte[]]): Likewise.
	(decodeDSSPrivateKey(DSAPrivateKeySpec)): Likewise.
	(decodeRSAPrivateKey(RSAPrivateCrtKeySpec)): Likewise.
	(decodeDHPrivateKey(DHPrivateKeySpec)): Likewise.
	(decodeDHPrivateKey(byte[])): Likewise.
	* gnu/java/security/jce/sig/KeyPairGeneratorAdapter.java:
	(initialize(int,SecureRandom)): Add Override.
	(initialize(AlgorithmParameterSpec,SecureRandom)): Likewise.
	(generateKeyPair()): Likewise.
	(localiseName(String)): Uncomment conversion.
	* gnu/java/security/jce/sig/RSAKeyPairGeneratorSpi.java:
	(initialize(int,SecureRandom)): Add Override.
	(initialize(AlgorithmParameterSpec,SecureRandom)): Likewise.
	* gnu/java/security/jce/sig/SignatureAdapter.java:
	Drop unneeded import of BaseSignature.
	(clone()): Add @Override.
	(engineInitVerify(PublicKey)): Reference VERIFIER_KEY via
	interface ISignature where it is defined.
	(engineInitSign(PrivateKey)): Likewise for SIGNER_KEY.
	(engineInitSign(PrivateKey,SecureRandom)): Likewise for
	SIGNER_KEY and SOURCE_OF_RANDOMNESS.
	* gnu/java/security/key/KeyPairCodecFactory.java:
	(getInstance(String,int)): Add default case which returns null.
	(getInstance(Key)): Likewise and fix typo in documentation.
	* gnu/java/security/key/dss/DSSKey.java:
	(getParams()): Add @Override.
	(getAlgorithm()): Likewise.
	(getEncoded()): Likewise.
	(getFormat()): LIkewise.
	(equals(Object)): Likewise.
	(hashCode()): Add implementation using java.util.Objects.hash
	(toString()): Remove unneeded cast.
	* gnu/java/security/key/dss/DSSKeyPairGenerator.java:
	(setup(MAp)): Remove unnecessary else clause.
	(generate()): Remove left-over debug statement.
	* gnu/java/security/key/dss/DSSKeyPairRawCodec.java:
	(getFormatID()): Add @Override.
	(encodePublicKey(PublicKey)): Likewise.
	(decodePublicKey(byte[])): Likewise.
	(encodePrivateKey(PrivateKey)): Likewise.
	(decodePrivateKey(byte[])): Likewise.
	* gnu/java/security/key/dss/DSSKeyPairX509Codec.java:
	(getFormatID()): Add @Override.
	(encodePublicKey(PublicKey)): Likewise.
	(encodePrivateKey(PrivateKey)): Likewise.
	(decodePublicKey(byte[])): Likewise.
	(decodePrivateKey(byte[])): Likewise.
	* gnu/java/security/key/dss/DSSPrivateKey.java:
	Drop unneeded reference to PrivateKey.
	(getX()): Add @Override.
	(getEncoded(int)): Likewise.
	(equals(Object)): Likewise.
	(hashCode()): Implemented.
	(toString()): Add @Override and remove unneeded cast.
	* gnu/java/security/key/dss/DSSPublicKey.java:
	Drop unneeded reference to PublicKey.
	(getY()): Add @Override.
	(getEncoded(int)): Likewise.
	(equals(Object)): Likewise.
	(hashCode()): Implemented.
	(toString()): Add @Override and remove unneeded cast.
	* gnu/java/security/key/rsa/GnuRSAKey.java:
	(getModulus()): Add @Override.
	(getAlgorithm()): Likewise.
	(getEncoded()): Likewise.
	(getFormat()): Likewise.
	(equals(Object)): Likewise.
	(hashCode()): Implemented using java.util.Objects.hash
	(toString()): Add @Override and remove unneeded cast.
	* gnu/java/security/key/rsa/GnuRSAPrivateKey.java:
	Drop unneeded reference to PrivateKey.
	(getPrimeP()): Add @Override.
	(getPrimeQ()): Likewise.
	(getPrimeExponentP()): Likewise.
	(getPrimeExponentQ()): Likewise.
	(getCrtCoefficient()): Likewise.
	(getPrivateExponent()): Likewise.
	(getEncoded(int)): Likewise.
	(equals(Object)): Likewise.
	(hashCode()): Implemented using java.util.Objects.hash.
	(toString()): Add @Override and remove unneeded cast.
	* gnu/java/security/key/rsa/GnuRSAPublicKey.java:
	Drop unneeded reference to PublicKey.
	(getEncoded()): Add @Override.
	(equals(Object)): Likewise.
	(hashCode()): Implemented.
	(toString()): Add @Override and remove unneeded cast.
	* gnu/java/security/key/rsa/RSAKeyPairPKCS8Codec.java:
	(getFormatID()): Add @Override.
	(encodePublicKey(PublicKey)): Likewise.
	(encodePrivateKey(PrivateKey)): Likewise.
	(decodePublicKey(byte[])): Likewise.
	(decodePrivateKey(byte[])): Likewise.
	* gnu/java/security/key/rsa/RSAKeyPairRawCodec.java:
	(getFormatID()): Add @Override.
	(encodePublicKey(PublicKey)): Likewise.
	(decodePublicKey(byte[])): Likewise.
	(encodePrivateKey(PrivateKey)): Likewise.
	(decodePrivateKey(byte[])): Likewise.
	* gnu/java/security/pkcs/PKCS7SignedData.java:
	(PKCS7SignedData(BERReader)): Refer to constants by
	the interface where they are defined. Rename crls
	to avoid shadowing the class variable.
	* gnu/java/security/pkcs/SignerInfo.java:
	(SignerInfo(BERReader)): Refer to constants by the
	interface where they are defined.
	* gnu/java/security/prng/BasePRNG.java:
	(addRandomBytes(byte[])): Add @Override.
	(addRandomBytes(byte[],int,int)): Likewise. Rename
	buffer to buf to avoid shadowing.
	(clone()): Remove unnecessary cast and this references.
	* gnu/java/security/prng/MDGenerator.java:
	Remove unneeded reference to Cloneable.
	* gnu/java/security/prng/RandomEvent.java:
	(RandomEvent(Object,byte,byte,byte[])): Remove unnecessary cast.
	* gnu/java/security/provider/DefaultPolicy.java:
	(getPermissions(CodeSource)): Add @Override.
	(refresh()): Likewise.
	* gnu/java/security/provider/Gnu.java:
	(Gnu()): Add @Override to run implementation in anonymous inner
	class.
	* gnu/java/security/provider/PKIXCertPathValidatorImpl.java:
	(engineValidate(CertPath,CertPathParameters)): Add @Override. Remove
	unneeded cast and else clause.
	(checkExplicitPolicy(int,List)): Make static.
	* gnu/java/security/provider/X509CertificateFactory.java:
	(generateCert(InputStream)): Make static. Remove unnecessary
	else clause.
	(generateCRL(InputStream)): Likewise.
	* gnu/java/security/sig/SignatureCodecFactory.java:
	(getInstance(String,int)): Add default case to switch statement.
	* gnu/java/security/sig/dss/DSSSignature.java:
	(encodeSignature(BigInteger,BigInteger)): Make static.
	(decodeSignature(Object)): Likewise.
	* gnu/java/security/sig/dss/DSSSignatureRawCodec.java:
	(getFormatID()): Add @Override.
	(encodeSignature(Object)): Likewise.
	(decodeSignature(byte[])): Likewise.
	* gnu/java/security/sig/dss/DSSSignatureX509Codec.java:
	(getFormatID()): Add @Override.
	(encodeSignature(Object)): Likewise.
	(decodeSignature(byte[])): Likewise.
	* gnu/java/security/sig/rsa/EMSA_PKCS1_V1_5.java:
	(clone()): Add @Override.
	* gnu/java/security/sig/rsa/EMSA_PSS.java:
	(clone()): Add @Override.
	* gnu/java/security/sig/rsa/RSA.java:
	(RSADP(RSAPrivateKey, BigInteger)): Suppress null warning
	as r is always non-null if rsaBlinding is true.
	* gnu/java/security/sig/rsa/RSAPKCS1V1_5Signature.java:
	(clone()): Add @Override.
	(setupForVerification(PublicKey)): Likewise.
	(setupForSigning(PrivateKey)): Likewise.
	(generateSignature()): Likewise.
	(verifySignature(Object)): Likewise.
	* gnu/java/security/sig/rsa/RSAPKCS1V1_5SignatureRawCodec.java:
	(getFormatID()): Add @Override.
	(encodeSignature(Object)): Likewise.
	(decodeSignature(byte[])): Likewise.
	* gnu/java/security/sig/rsa/RSAPKCS1V1_5SignatureX509Codec.java:
	(getFormatID()): Add @Override.
	(encodeSignature(Object)): Likewise.
	(decodeSignature(byte[])): Likewise.
	* gnu/java/security/sig/rsa/RSAPSSSignature.java:
	(clone()): Add @Override.
	(setupForVerification(PublicKey)): Likewise. Remove unnecessary
	cast.
	(setupForSigning(PrivateKey)): Likewise.
	(generateSignature()): Add @Override.
	(verifySignature(Object)): Likewise.
	* gnu/java/security/sig/rsa/RSAPSSSignatureRawCodec.java:
	(getFormatID()): Add @Override.
	(encodeSignature(Object)): Likewise.
	(decodeSignature(byte[])): Likewise.
	* gnu/java/security/util/ByteArray.java:
	(toString()): Add @Override.
	* gnu/java/security/util/ByteBufferOutputStream.java:
	(toString()): Add @Override.
	* gnu/java/security/util/ExpirableObject.java:
	(destroy()): Add @Override.
	(Destroyer.run()): Likewise.
	* gnu/java/security/util/FormatUtil.java:
	(getEncodingName(int)): Add default case for switch statement.
	(getEncodingShortName(int)): Likewise.
	* gnu/java/security/util/Sequence.java:
	(size()): Add @Override.
	(toArray()): Likewise. Remove unnecessary cast.
	* gnu/java/security/util/SimpleList.java:
	(size()): Add @Override.
	(get(int)): Likewise.
	(toString()): Likewise.
	* gnu/java/security/util/Util.java:
	(toBase64(byte[])): Add default case to switch statement which
	does nothing. Remove unnecessary else clause.
	* gnu/java/security/x509/PolicyNodeImpl.java:
	(addExpectedPolicy(String)): Rename variable to expectedPolicy
	to avoid shadowing policy variable.
	(addAllPolicyQualifiers(Collection)): Rename variable to
	policyQualifiers to avoid shadowing qualifiers variable.
	Rewrite collection check to catch ClassCastException as,
	if it.next() returns normally, it will always be an instance
	of PolicyQualifierInfo.
	(toString()): Add @Override.
	* gnu/java/security/x509/X500DistinguishedName.java:
	(X500DistinguishedName(String)): Throw IOException rather
	than catching it as calling methods in X509CRLSelector
	implementations, addIssuerName(String), expect an
	IOException to be thrown if there is a parsing error.
	(getName()): Add @Override.
	(hashCode()): Likewise.
	(equals(Object)): Likewise.
	(toString()): Likewise.
	(getDer()): Remove unnecessary casts.
	(readAttributeType(Reader)): Make static.
	* gnu/java/security/x509/X509CRL.java:
	(equals(Object)): Add @Override.
	(hashCode()): Likewise.
	(getEncoded()): Remove unnecessary cast.
	(getIssuerX500Principal()): Add @Override.
	(getTBSCertList()): Remove unnecessary cast.
	(getSignature()): Likewise.
	(getSigAlgParams()): Likewise.
	(hasUnsupportedCriticalExtension()): Add @Override.
	(getCriticialExtensionOIDs()): Likewise.
	(getNonCriticalExtensionOIDs()): Likewise.
	(getExtensionValue(String)): Likewise.
	(isRevoked(Certificate)): Likewise. Remove unnecessary
	cast.
	(parse(InputStream)): Remove unnecessary cast.
	* gnu/java/security/x509/X509CRLEntry.java:
	(getEncoded()): Remove unncessary cast.
	(hasUnsupportedCriticalExtension()): Add @Override.
	(getCriticialExtensionOIDs()): Likewise.
	(getNonCriticalExtensionOIDs()): Likewise.
	(getExtensionValue(String)): Likewise.
	* gnu/java/security/x509/X509CRLSelectorImpl.java:
	(addIssuerName(String)): Throw IOException as specified.
	* gnu/java/security/x509/X509CertPath.java:
	(getCertificates()): Add @Override.
	(getEncoded()): Likewise. Remove unnecessary casts.
	(getEncodings()): Add @Override.
	(parse(InputStream, String)): Rename path to parsedPath
	to avoid shadowing.
	* gnu/java/security/x509/X509CertSelectorImpl.java:
	(addIssuerName(String)): Throw IOException as specified.
	* gnu/java/security/x509/X509Certificate.java:
	Remove unneeded Serializable reference.
	(checkValidity()): Add @Override.
	(checkValidity(Date)): Likewise.
	(getVersion()): Likewise.
	(getSerialNumber()): Likewise.
	(getIssuerDN()): Likewise.
	(getIssuerX500Principal()): Likewise.
	(getSubjectDN()): Likewise.
	(getSubjectX500Principal()): Likewise.
	(getNotBefore()): Likewise.
	(getNotAfter()): Likewise.
	(getTBSCertificate()): Likewise. Remove unnecessary cast.
	(getSignature()): Likewise.
	(getSigAlgName()): Add @Override.
	(getSigAlgOID()): Likewise.
	(getSigAlgParams()): Likewise. Remove unnecessary cast.
	(getIssuerUniqueID()): Add @Override.
	(getSubjectUniqueID()): Likewise.
	(getKeyUsage()): Likewise.
	(getExtendedKeyUsage()): Likewise.
	(getBasicConstraints()): Likewise.
	(getSubjectAlternativeNames()): Likewise. Make conversion
	from int to Integer explicit.
	(getIssuerAlternativeNames()): Likewise.
	(hasUnsupportedCriticalExtension()): Add @Override.
	(getCriticialExtensionOIDs()): Likewise.
	(getNonCriticalExtensionOIDs()): Likewise.
	(getExtensionValue(String)): Likewise.
	(getEncoded()): Likewise. Remove unnecessary cast.
	(verify(PublicKey)): Add @Override.
	(verify(PublicKey, String)): Likewise.
	(toString()): Likewise.
	(getPublicKey()): Likewise.
	(parse(InputStream)): Rename encoded to enc to avoid shadowing.
	Avoid unnecessary cast.
	* gnu/java/security/x509/ext/AuthorityKeyIdentifier.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/BasicConstraints.java:
	(getEncoded()): Add @Override. Remove unncessary casts.
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/CRLNumber.java:
	(getEncoded()): Add @Override. Remove unncessary casts.
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/CertificatePolicies.java:
	(CertificatePolicies(List,Map)): Swap empty for-loop
	for a while loop.
	(getEncoded()): Add @Override. Remove unnecessary cast.
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/ExtendedKeyUsage.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/Extension.java:
	(Extension(byte[])): Remove unnecessary cast.
	(getEncoded()): Likewise.
	(toString()): Add @Override.
	(Value.Value(byte[])): Remove unnecessary cast.
	(Value.getEncoded()): Likewise.
	(hashCode()): Add @Override.
	(equals(Object)): Likewise.
	(toString()): Likewise.
	* gnu/java/security/x509/ext/GeneralName.java:
	(Kind.forTag(int)): Add default case.
	(Kind): Remove unnecessary ; on closing brace.
	(GeneralName(Kind,byte[])): Remove unnecessary cast.
	(name()): Likewise.
	(encoded()): Check for null rather than catching exception.
	Remove unnecessary cast.
	(equals(Object)): Add @Override. Avoid unnecessary method call.
	(hashCode()): Implemented using java.util.Objects.hash.
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/GeneralNames.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/GeneralSubtree.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/IssuerAlternativeNames.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/KeyUsage.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/NameConstraints.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/PolicyConstraint.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/PolicyMappings.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/PrivateKeyUsagePeriod.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/ReasonCode.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/SubjectAlternativeNames.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/SubjectKeyIdentifier.java:
	(getKeyIdentifier()): Remove unnecessary cast.
	(toString()): Add @Override.
	* gnu/javax/security/auth/Password.java:
	(doDestroy): Add @Override. Remove unneeded else block.
	(isDestroyed): Add @Override.
	* gnu/javax/security/auth/callback/AWTCallbackHandler.java:
	(handleChoice(ChoiceCallback)): Add @Override.
	(handleConfirmation(ConfirmationCallback)): Likewise.
	(handleLanguage(LanguageCallback)): Likewise.
	(handleName(NameCallback)): Likewise.
	(handlePassword(PasswordCallback)): Likewise.
	(handleTextInput(TextInputCallback)): Likewise.
	(handleTextOutput(TextOutputCallback)): Likewise.
	(actionPerformed(ActionEvent)): Likewise.
	(windowClosing(WindowEvent)): Likewise.
	(windowOpened(WindowEvent)): Likewise.
	(windowClosed(WindowEvent)): Likewise.
	(windowIconified(WindowEvent)): Likewise.
	(windowDeiconified(WindowEvent)): Likewise.
	(windowActivated(WindowEvent)): Likewise.
	(windowDeactivated(WindowEvent)): Likewise.
	* gnu/javax/security/auth/callback/AbstractCallbackHandler.java:
	(AbstractCallbackHandler(String)): Reference getBundle by class
	where it is implemented (ResourceBundle).
	(handle(Callback[])): Add @Override.
	(handleChoice(ChoiceCallback)): Allow and document an
	UnsupportedCallbackException being thrown.
	(handleConfirmation(ConfirmationCallback)): Likewise.
	(handleLanguage(LanguageCallback)): Likewise.
	(handleName(NameCallback)): Likewise.
	(handlePassword(PasswordCallback)): Likewise.
	(handleTextInput(TextInputCallback)): Likewise.
	(handleTextOutput(TextOutputCallback)): Likewise.
	(handleOther(Callback)): Suppress warnings resulting from
	unused variables, unthrown exceptions and lack of IOException
	being thrown. They are necessary for subclasses.
	* gnu/javax/security/auth/callback/ConsoleCallbackHandler.java:
	(handleChoice(ChoiceCallback)): Add @Override. Drop unnecessary
	cast.
	(handleConfirmation(ConfirmationCallback)): Add @Override.
	(handleLanguage(LanguageCallback)): Likewise.
	(handleName(NameCallback)): Likewise.
	(handlePassword(PasswordCallback)): Likewise.
	(handleTextInput(TextInputCallback)): Likewise.
	(handleTextOutput(TextOutputCallback)): Likewise.
	* gnu/javax/security/auth/callback/DefaultCallbackHandler.java:
	(handleChoice(ChoiceCallback)): Add @Override.
	(handleConfirmation(ConfirmationCallback)): Likewise.
	(handleLanguage(LanguageCallback)): Likewise.
	(handleName(NameCallback)): Likewise.
	(handlePassword(PasswordCallback)): Likewise.
	(handleTextInput(TextInputCallback)): Likewise.
	(handleTextOutput(TextOutputCallback)): Likewise.
	* gnu/javax/security/auth/callback/GnuCallbacks.java:
	(GnuCallbacks()): Add @Override to run() implementation
	in anonymous inner class.
	* gnu/javax/security/auth/callback/SwingCallbackHandler.java:
	(handleChoice(ChoiceCallback)): Add @Override to method
	and methods of anonymous inner classes. Refer to
	constants using interface where they appear.
	(handleConfirmation(ConfirmationCallback)): Add @Override
	to method and methods of anonymous inner class. Declare
	UnsupportedCallbackException as thrown and add default
	cases and fall-through markers to switch statements.
	(handleLanguage(LanguageCallback)): Add @Override. Remove
	unused variable defaultIndex.
	(handleName(NameCallback)): Add @Override to method and
	method of anonymous inner class.
	(handlePassword(PasswordCallback)): Likewise.
	(handleTextInput(TextInputCallback)): Likewise. Refer to
	constants using interface where they appear.
	(handleTextOutput(TextOutputCallback)): Likewise. Declare
	UnsupportedCallbackException as thrown and add default
	case to switch statement.
	(waitForInput(JDialog, Callback)): Make static.
	* gnu/javax/security/auth/login/ConfigFileParser.java:
	(initParser(Reader)): Don't declare IOException as thrown
	as one is never thrown.
	(expandParamValue(String)): Make static.
	* gnu/javax/security/auth/login/GnuConfiguration.java:
	(getAppConfigurationEntry(String)): Add @Override.
	(refresh()): Likewise.
	(getInputStreamFromURL(String)): Make static.
	(parseConfig(InputStream)): Remove unneeded variable.
	(getUserName()): Make static.
	(getConfigFromUserName(File,String)): Likewise.
	* java/security/AccessControlContext.java:
	(equals(Object)): Add @Override.
	(hashCode()): Likewise.
	* java/security/AlgorithmParameters.java:
	(toString()): Add @Override.
	* java/security/AllPermission.java:
	(AllPermission(String,String)): Suppress
	warning about actions variable being unused.
	(implies(Permission)): Add @Override.
	(equals(Object)): Likewise.
	(hashCode()): Likewise.
	(getActions()): Likewise.
	(newPermissionCollection()): Likewise.
	(AllPermissionCollection()): Add public constructor
	to avoid generating a synthetic accessor method.
	* java/security/BasicPermission.java:
	Remove unneeded Serializable reference.
	(BasicPermission(String,String)): Suppress
	warnings about actions variable being unused.
	(getActions()): Add @Override.
	(newPermissionCollection()): Likewise.
	* java/security/Certificate.java:
	Mark with @Deprecated. Fix typo in documentation.
	* java/security/DigestInputStream.java:
	(read()): Add @Override.
	(read(byte[],int,int)): Likewise.
	(toString()): Likewise.
	* java/security/DigestOutputStream.java:
	(write(int)): Add @Override.
	(write(byte[],int,int)): Likewise.
	(toString()): Likewise.
	* java/security/DummyKeyPairGenerator.java:
	(clone()): Add @Override.
	(initialize(int,SecureRandom)): Likewise.
	(initialize(AlgorithmParameterSpec,SecureRandom)):
	Likewise.
	(generateKeyPair()): Likewise.
	* java/security/DummyMessageDigest.java:
	(clone()): Add @Override.
	(engineDigest()): Likewise.
	(engineDigest(byte[],int,int)): Likewise.
	(engineGetDigestLength()): Likewise.
	(engineReset()): Likewise.
	(engineUpdate(byte)): Likewise.
	(engineUpdate(byte[],int,int)): Likewise.
	* java/security/Identity.java:
	Mark as @Deprecated. Fix typo in documentation.
	(getName()): Add @Override.
	(equals(Object)): Likewise.
	(toString()): Likewise.
	(toString(boolean)): Remove unnecessary else clause.
	(hashCode()): Add @Override.
	* java/security/IdentityScope.java:
	Mark as @Deprecated.
	(toString()): Add @Override.
	* java/security/IntersectingDomainCombiner.java:
	(combine(ProtectionDomain[],ProtectionDomain[])):
	Add @Override.
	* java/security/KeyPairGenerator.java:
	(generateKeyPair()): Add @Override.
	* java/security/KeyPairGeneratorSpi.java:
	(initialize(AlgorithmParameterSpec,SecureRandom)):
	Suppress warning about making this method static.
	Intended to be overridden by subclasses.
	(clone()): Add @Override.
	* java/security/KeyStore.java:
	(getInstance(String,Provider)): Fix typo in documentation.
	(getDefaultType()): Add @Override to run() in anonymous
	inner class.
	* java/security/MessageDigest.java:
	(toString()): Add @Override.
	(clone()): Likewise.
	* java/security/MessageDigestSpi.java:
	(engineGetDigestLength()): Suppress warning about
	making this method static. Intended to be overridden
	by subclasses.
	(clone()): Add @Override.
	* java/security/Permission.java:
	(checkGuard(Object)): Add @Override.
	(equals(Object)): Likewise.
	(hashCode()): Likewise.
	(newPermissionCollection()): Likewise.
	(toString()): Likewise.
	* java/security/PermissionCollection.java:
	(toString()): Add @Override.
	* java/security/Permissions.java:
	Remove unneeded Serializable reference.
	(elements()): Add @Override to hasMoreElements
	and nextElement methods in anonymous inner class.
	(PermissionsHash.PermissionsHash()): Add explicit
	constructor to avoid a synthetic accessor method.
	(add(Permission)): Mark synchronized.
	(implies(Permission)): Likewise.
	* java/security/Policy.java:
	(implies(ProtectionDomain,Permission)): Remove
	unnecessary cast.
	* java/security/Principal.java:
	(equals(Object)): Add @Override.
	(toString()): Likewise.
	(hashCode()): Likewise.
	* java/security/PrivilegedActionException.java:
	(getCause()): Add @Override.
	(toString()): Removed; pointless as it just calls
	superclass version.
	* java/security/ProtectionDomain.java:
	(ProtectionDomain(CodeSource,PermissionCollection,
	ClassLoader,Principal[],boolean)): Remove unnecessary
	cast.
	(getPrincipals()): Add @Override.
	(toString()): Likewise.
	* java/security/Provider.java:
	Remove unneeded Serializable reference.
	(put(Object,Object)): Add @Override. Suppress warnings
	about overridding a synchronized method as all collection
	modifications are made in synchronized superclass method.
	(get(Object)): Likewise.
	(remove(Object)): Likewise.
	(clear()): Likewise.
	(toString()): Add @Override. Suppress warning about
	overridding a synchronized method as the collection isn't
	used.
	(toCanonicalKey(Object)): Make static.
	* java/security/SecureClassLoader.java:
	(getPermissions(CodeSource)): Suppress warning about
	making this method static; may potentially be overridden
	by subclasses. Avoid unnecessary variable policy.
	* java/security/SecureRandom.java:
	(setSeed(byte[])): Make synchronized to prevent
	concurrent access to secureRandomSpi.
	(setSeed(long)): Add @Override and make synchronized.
	(nextBytes(byte[])): Likewise.
	(next(int)): Likewise.
	(generateSeed(byte[])): Make synchronized.
	* java/security/Security.java:
	(getAlgorithmProperty(String,String)): Add @Deprecated.
	(getProvider(String)): Remove unnecessary else clause.
	(getAlgorithm(String)): Use provs instead of providers
	to avoid shadowing class variable.
	(provides(Provider,String,String,String,String)): Set
	serviceDotAlgorithm to the empty string to avoid null
	pointer issues.
	* java/security/SecurityPermission.java:
	(SecurityPermission(String,String)): Suppress warning
	due to nothing being done with actions.
	* java/security/Signature.java:
	(sign()): Remove unnecessary else clause.
	(sign(byte[],int,int)): Likewise.
	(verify(byte[])): Likewise.
	(toString()): Mark @Override.
	(setParameter(String,Object)): Add @Deprecated.
	(getParameter(String)): Likewise.
	(clone()): Add @Override.
	* java/security/SignatureSpi.java:
	(engineSetParameter(String,Object)): Add @Deprecated.
	(engineSetParameter(AlgorithmParameterSpec)): Suppress
	warnings about unused variables, unthrown exceptions and
	ability to be a static method. Subclasses override this.
	(engineGetParameters()): Suppress warnings about making
	this method static.
	(engineGetParameter(String)): Add @Deprecated.
	* java/security/SignedObject.java:
	(getSignature()): Remove unnecessary cast.
	(readObject(ObjectInputStream)): Likewise x 2.
	* java/security/Signer.java:
	Mark as @Deprecated.
	(toString()): Add @Override.
	* java/security/UnresolvedPermission.java:
	(getUnresolvedCerts()): Remove unnecessaary cast.
	(UnresolvedPermissionCollection.elements()):
	Add @Override to hasMoreElements and nextElement.
	* java/security/acl/Acl.java:
	(toString()): Add @Override.
	* java/security/acl/AclEntry.java:
	(setPrincipal(Principal)): Fix formatting of documentation.
	(addPermission(Permission)): Likewise.
	(removePermission(Permission)): Likewise.
	(checkPermission(Permission)): Likewise.
	(toString()): Add @Override.
	* java/security/acl/Permission.java:
	(equals(Object)): Add @Override.
	(toString()): Likewise.
	* java/security/cert/CRL.java:
	(toString()): Add @Override.
	* java/security/cert/CertPath.java:
	(equals(Object)): Add @Override.
	(hashCode()): Likewise.
	(toString()): Likewise.
	* java/security/cert/CertPathBuilderException.java:
	(CertPathBuilderException(Throwable)): Just call
	superclass constructor.
	(CertPathBuilderException(String,Throwable)): Likewise.
	(getMessage()): Removed; provided by superclass.
	(getCause()): Likewise.
	(toString()): Likewise.
	(printStackTrace()): Likewise.
	(printStackTrace(PrintStream)): Likewise.
	(printStackTrace(PrintWriter)): Likewise.
	* java/security/cert/CertPathValidatorException.java:
	(CertPathValidatorException(String,Throwable)): Just call
	superclass with both arguments, rather than initCause.
	(getMessage()): Removed; provided by superclass.
	(getCause()): Likewise.
	(toString()): Likewise.
	(printStackTrace()): Likewise.
	(printStackTrace(PrintStream)): Likewise.
	(printStackTrace(PrintWriter)): Likewise.
	* java/security/cert/CertStoreException.java:
	(CertStoreException(Throwable)): Just call superclass
	constructor.
	(CertStoreException(String,Throwable)): Likewise.
	(getMessage()): Removed; provided by superclass.
	(getCause()): Likewise.
	(toString()): Likewise.
	(printStackTrace()): Likewise.
	(printStackTrace(PrintStream)): Likewise.
	(printStackTrace(PrintWriter)): Likewise.
	* java/security/cert/CertStoreSpi.java:
	(CertStoreSpi(CertStoreParameters)): Suppress warnings
	about exception not being thrown. Present for subclasses.
	* java/security/cert/Certificate.java:
	(equals(Object)): Add @Override.
	(hashCode()): Likewise.
	(toString()): Likewise.
	* java/security/cert/CertificateFactorySpi.java:
	(engineGenerateCertPath(InputStream)): Suppress warnings
	about unused arguments, exceptions not being thrown and
	method can be static. Provided for subclass implementations.
	(engineGenerateCertPath(InputStream,String)): Likewise.
	(engineGenerateCertPath(List)): Likewise.
	(engineGetCertPathEncodings()): Likewise.
	* java/security/cert/CollectionCertStoreParameters.java:
	(toString()): Add @Override.
	* java/security/cert/LDAPCertStoreParameters.java:
	(clone()): Add @Override.
	(toString()): Likewise.
	* java/security/cert/PKIXBuilderParameters.java:
	(toString()): Likewise.
	* java/security/cert/PKIXCertPathBuilderResult.java:
	(getCertPath()): Add @Override.
	(toString()): Likewise.
	* java/security/cert/PKIXCertPathChecker.java:
	(clone()): Add @Override.
	* java/security/cert/PKIXCertPathValidatorResult.java:
	(clone()): Add @Override.
	(toString()): Likewise.
	* java/security/cert/PKIXParameters.java:
	(clone()): Add @Overrride.
	(toString()): Likewise.
	* java/security/cert/PolicyQualifierInfo.java:
	(PolicyQualifierInfo(byte[])): Remove unnecessary cast.
	(getEncoded()): Likewise.
	(toString()): Add @Override.
	* java/security/cert/TrustAnchor.java:
	(TrustAnchor(X509Certificate,byte[])): Remove unnecessary cast.
	(TrustAnchor(String,PublicKey,byte[])): Document exceptions.
	Catch IOException and throw as IllegalArgumentException.
	Remove unnecessary casts.
	(toString()): Add @Override.
	* java/security/cert/X509CRL.java:
	(equals(Object)): Add @Override.
	(hashCode()): Likewise.
	(getIssuerX500Principal()): Suppress warning about making this
	static. Should be overridden by subclasses.
	* java/security/cert/X509CRLEntry.java:
	(equals(Object):: Add @Override.
	(hashCode()): Likewise.
	(toString()): Likewise.
	* java/security/cert/X509CRLSelector.java:
	Remove unneeded Cloneable reference.
	(getIssuerNames()): Remove unneeded else block.
	(toString()): Add @Override.
	(match(CRL)): Likewise.
	(clone()): LIkewise.
	* java/security/cert/X509CertSelector.java:
	Remove unneeded Cloneable reference.
	(makeName(int,String)): Re-use earlier result of Kind.forTag(id).
	Add default case.
	(clone()): Add @Override.
	(getAuthorityKeyIdentifier()): Remove unneeded else block
	and cast.
	(getCertificateValid()): Remove unneeded else block.
	(getExtendedKeyUsage()): Likewise.
	(getIssuerAsBytes()): Likewise.
	(getIssuerAsString()): Likewise.
	(getKeyUsage()): Likewise and remove unneeded cast.
	(getNameConstraints()): Likewise.
	(getPathToNames()): Explicitly convert int to Integer.
	(getPrivateKeyValid()): Suppress static method warning.
	Method is deliberately useless.
	(getSubjectAlternativeNames()): Explicitly convert int to
	Integer.
	(getSubjectAsBytes()): Remove unneeded else block.
	(getSubjectAsString()): Likewise.
	(getSubjectKeyIdentifier()): Likewise and remove unneeded
	cast.
	(match(Certificate)): Add @Override. Rename cert to other
	to avoid shadowing.
	(setNameConstraints(byte[])): Remove unnecessary cast.
	Suppress warnings about NameConstraints instance being unused.
	(setPrivateKeyValid()): Suppress unused variable warning.
	Method is deliberately useless.
	(setSubjectPublicKey(PublicKey)): Remove unneeded cast.
	(toString()): Add @Override.
	* java/security/cert/X509Certificate.java:
	(getExtendedKeyUsage()): Suppress unthrown exception warning
	and static method suggestion. Overridden by subclasses.
	(getSubjectAlternativeNames()): Likewise.
	(getIssuerAlternativeNames()): Likewise.
	(getSubjectX500Principal()): Suppress static method suggestion.
	Overridden by subclasses.
	(getIssuerX500Principal()): Likewise.
	* java/security/spec/DSAParameterSpec.java:
	(getP()): Add @Override.
	(getQ()): Likewise.
	(getG()): Likewise.
	* java/security/spec/PKCS8EncodedKeySpec.java:
	(getEncoded()): Add @Override.
	(getFormat()): Likewise.
	* java/security/spec/RSAMultiPrimePrivateCrtKeySpec.java:
	(RSAMultiPrimePrivateCrtKeySpec(BigInteger,BigInteger,BigInteger,
	BigInteger,BigInteger,BigInteger,BigInteger,BigInteger,
	RSAOtherPrimeInfo[])): Remove unneeded else block.
	* java/security/spec/X509EncodedKeySpec.java:
	(getEncoded()): Add @Override.
	(getFormat()): Likewise.
	* javax/security/auth/Policy.java:
	Add @Deprecated.
	* javax/security/auth/PrivateCredentialPermission.java:
	Remove unneeded Serializable reference.
	(equals(Object)): Add @Override. Rename principals to
	thisPrincipals to avoid shadowing.
	(getActions()): Add @Override.
	(hashCode()): Likewise.
	(implies(Permission)): Likewise. Rename principals to
	thisPrincipals to avoid shadowing.
	(newPermissionCollection()): Add @Override to method
	and anonymous inner class implementations of equals(Object) &
	hashCode().
	* javax/security/auth/SubjectDomainCombiner.java:
	(combine(ProtectionDomain[],ProtectionDomain[])): Add @Override.
	* javax/security/auth/callback/ConfirmationCallback.java:
	(setOptions(String[],int)): Move reference to options.length to
	after options null check.
	* javax/security/auth/kerberos/KerberosKey.java:
	Remove unneeded Serializable reference.
	(getAlgorithm()): Add @Override.
	(getFormat()): Likewise.
	(getEncoded()): Likewise and remove unnecessary cast.
	(destroy()): Add @Override.
	(isDestroyed()): Likewise.
	(toString()): Likewise.
	* javax/security/auth/kerberos/KerberosPrincipal.java:
	(getName()): Add @Override.
	(hashCode()): Likewise.
	(equals(Object)): Likewise.
	(toString()): Likewise.
	* javax/security/auth/kerberos/KerberosTicket.java:
	(asn1Encoding): Remove @SuppressWarnings.
	(KerberosTicket(byte[],KerberosPrincipal,KerberosPrincipal,
	byte[],int,boolean[],Date,Date,Date,Date,InetAddress[])):
	Remove unnecessary cast. Remove duplicate assignment to flags.
	(destroy()): Add @Override.
	(isDestroyed()): Likewise.
	(isCurrent()): Likewise.
	(refresh()): Likewise.
	(getFlags()): Remove unnecessary cast.
	(getEncoded()): Likewise.
	(toString()): Add @Override.
	* javax/security/auth/kerberos/KeyImpl.java:
	Remove unneeded Serializable reference.
	(KeyImpl(byte[],int)): Remove unnecessary cast.
	(getAlgorithm()): Add @Override.
	(getEncoded()): Likewise.
	(getFormat()): Likewise.
	(toString()): Likewise.
	* javax/security/auth/login/AppConfigurationEntry.java:
	(toString()): Add @Override.
	(LoginModuleControlFlag.toString()): Likewise.
	* javax/security/auth/login/Configuration.java:
	(getConfig()): Use GetSecurityPropertyAction rather than
	a bespoke PrivilegedAction implementation.
	* javax/security/auth/login/LoginContext.java:
	(LoginContext(String,Subject,CallbackHandler,Configuration)):
	Rename entries to appEntries to avoid shadowing.
	(lookupModule(AppConfigurationEntry,Subject,Map)): Rename
	subject to subj to avoid shadowing. Check module is null
	rather than cause is non-null.
	* javax/security/auth/login/NullConfiguration.java:
	(getAppConfigurationEntry(String)): Add @Override.
	(refresh()): Likewise.
	* javax/security/auth/x500/X500Principal.java:
	(hashCode()): Add @Override.
	(equals(Object)): Likewise.
	(getEncoded()): Remove unnecessary cast.
	(getName()): Add @Override.
	(toString()): Likewise.
	(readAttributeType(Reader)): Make static.
	(parseDer(InputStream)): Rename encoded to encodedStream to
	avoid shadowing.
	* javax/security/auth/x500/X500PrivateCredential.java:
	(destroy()): Add @Override.
	(isDestroyed()): Likewise.
	* javax/security/cert/Certificate.java:
	(equals(Object)): Add @Override.
	(hashCode()): Likewise.
	(toString()): Likewise.
	* javax/security/cert/X509CertBridge.java:
	(getEncoded()): Add @Override.
	(verify(PublicKey)): Likewise.
	(verify(PublicKey,String)): Likewise.
	(toString()): Likewise.
	(getPublicKey()): Likewise.
	(checkValidity()): Likewise.
	(checkValidity(Date)): Likewise.
	(getVersion()): Likewise.
	(getSerialNumber()): Likewise.
	(getIssuerDN()): Likewise.
	(getSubjectDN()): Likewise.
	(getNotBefore()): Likewise.
	(getNotAfter()): Likewise.
	(getSigAlgName()): Likewise.
	(getSigAlgOID()): Likewise.
	(getSigAlgParams()): Likewise.
	* javax/security/sasl/Sasl.java:
	(createSaslClient(String[],String,String,String,Map,CallbackHandler)):
	Remove unnecessary else clause and pointless result assignment.
	(createSaslServer(String,String,String,Map,CallbackHandler)): Likewise.
	* javax/security/sasl/SaslException.java:
	Remove unneeded Serializable reference.
	(SaslException(String,Throwable)): Add cause to superclass call.
	(getCause()): Add @Override.
	(printStackTrace()): Removed; provided by superclass.
	(printStackTrace(PrintStream)): Likewise.
	(printStackTrace(PrintWriter)): Likewise.
	(initCause(Throwable)): Call superclass version, then sync the
	local copy.
	(toString()): Add @Override.





2015-03-11  Andrew John Hughes  <gnu_andrew@member.fsf.org>

	* configure.ac:
	(ECJ_WARNINGS): Turn off parameter assignment,
	autoboxing and overridding without a super method
	call warnings for now.
	* gnu/java/security/OID.java:
	(OID(int[],boolean)): Remove unnecessary cast on clone() call.
	(getIDs()): Likewise.
	(getDER()): Likewise.
	(clone()): Add @Override.
	(toString()): Add @Override. Remove unncessary else clause.
	(hashCode()): Add @Override.
	(equals(Object)): Likewise.
	(compareTo(OID)): Likewise.
	* gnu/java/security/PolicyFile.java:
	(getPermissions(CodeSource)): Add @Override.
	(refresh()): Likewise and on anonymous inner class run() method.
	(toString()): Add @Override.
	(parse(URL)): Throw exception if p is null, and suppress associated
	warning, as exception is thrown via error method. Add default
	empty case to switch method. Call error method with the exception,
	not the result of its toString() method. Remove unneeded else block.
	(expand(String)): Avoid shadowing the prop variable.
	(error(URL,StreamTokenizer,Throwable)): Add new variant that allows
	the cause to be included.
	* gnu/java/security/Properties.java:
	(init()): Avoid unnecessary casts.
	(handleBooleanProperty(String)): Make static.
	* gnu/java/security/action/GetPropertyAction.java:
	(run()): Add @Override.
	* gnu/java/security/action/GetSecurityPropertyAction.java:
	(run()): Add @Override.
	* gnu/java/security/ber/BERReader.java:
	(read()): Add @Override. Remove unnecessary else clause.
	* gnu/java/security/ber/BERValue.java:
	(getLength()): Add @Override.
	* gnu/java/security/der/BitString.java:
	(toByteArray()): Remove unnecessary cast on clone() call.
	(getShiftedByteArray()): Likewise.
	(toBooleanArray()): Likewise.
	(clone(): Add @Override.
	(hashCode()): Likewise.
	(equals(Object)): Likewise.
	(toString()): Likewise.
	* gnu/java/security/der/DERReader.java:
	(makeTime(int,byte[])): Make static. Mark fall-through
	cases in switch statement. Add default case which throws
	an exception.
	* gnu/java/security/der/DERValue.java:
	(DERValue(int,int,Object,byte[])): Remove unnecessary cast on clone() call.
	(getValueAs(int)): Avoid shadowing of encoded variable.
	(getEncoded()): Remove unnecessary cast on clone() call.
	(toString()): Add @Override.
	* gnu/java/security/hash/BaseHash.java:
	(name()): Add @Override.
	(hashSize()): Likewise.
	(blockSize()): Likewise.
	(update(byte)): Likewise.
	(update(byte[])): Likewise.
	(update(byte[],int,int)): Likewise.
	(digest()): Likewise.
	(reset()): Likewise.
	(clone()): Likewise.
	(selfTest()): Likewise.
	* gnu/java/security/hash/Haval.java:
	(Haval(Haval)): Remove unnecessary cast on clone() call.
	(clone()): Add @Override.
	(transform(byte[],int)): Likewise.
	(padBuffer()): Likewise.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(selfTest()): Likewise.
	(tailorDigestBits()): Add empty default case to switch statement.
	(FF5(int,int,int,int,int,int,int,int,int,int)): Make static.
	(f1(int,int,int,int,int,int,int)): Likewise.
	(f2(int,int,int,int,int,int,int)): Likewise.
	(f3(int,int,int,int,int,int,int)): Likewise.
	(f4(int,int,int,int,int,int,int)): Likewise.
	(f5(int,int,int,int,int,int,int)): Likewise.
	* gnu/java/security/hash/MD2.java:
	(MD2(MD2)): Remove unnecessary casts on clone() call.
	(clone()): Add @Override.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(selfTest())): Likewise.
	(padBuffer()): Likewise.
	(transform(byte[],int)): LIkewise.
	* gnu/java/security/hash/MD4.java:
	(MD4(MD4)): Remove unncessary casts on clone() call.
	(clone()): Add @Override.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(selfTest())): Likewise. Avoid shadowing d variable.
	(padBuffer()): Likewise.
	(transform(byte[],int)): LIkewise.
	* gnu/java/security/hash/MD5.java:
	(MD5(MD5)): Remove unnecessary casts on clone() call.
	(clone()): Add @Override.
	(transform(byte[],int)): LIkewise.
	(padBuffer()): Likewise.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(selfTest())): Likewise.
	* gnu/java/security/hash/RipeMD128.java:
	(RipeMD128(RipeMD128)): Remove unnecessary casts on clone() call.
	(clone()): Add @Override.
	(transform(byte[],int)): LIkewise.
	(padBuffer()): Likewise.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(selfTest())): Likewise.
	* gnu/java/security/hash/RipeMD160.java:
	(RipeMD160(RipeMD160)): Remove unnecessary casts on clone() call.
	(clone()): Add @Override.
	(transform(byte[],int)): LIkewise.
	(padBuffer()): Likewise.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(selfTest())): Likewise.
	* gnu/java/security/hash/Sha160.java:
	(Sha160(Sha160)): Remove unnecessary casts on clone() call.
	(clone()): Add @Override.
	(transform(byte[],int)): LIkewise.
	(padBuffer()): Likewise.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(selfTest())): Likewise.
	* gnu/java/security/hash/Sha256.java:
	(Sha256(Sha256)): Remove unnecessary casts on clone() call.
	(clone()): Add @Override.
	(transform(byte[],int)): LIkewise.
	(padBuffer()): Likewise.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(selfTest())): Likewise.
	* gnu/java/security/hash/Sha384.java:
	(Sha384(Sha384)): Remove unnecessary casts on clone() call.
	(clone()): Add @Override.
	(transform(byte[],int)): LIkewise.
	(padBuffer()): Likewise.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(selfTest())): Likewise.
	* gnu/java/security/hash/Sha512.java:
	(Sha512(Sha512)): Remove unnecessary casts on clone() call.
	(clone()): Add @Override.
	(transform(byte[],int)): LIkewise.
	(padBuffer()): Likewise.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(selfTest())): Likewise.
	* gnu/java/security/hash/Tiger.java:
	(Tiger(Tiger)): Remove unnecessary casts on clone() call.
	(clone()): Add @Override.
	(selfTest())): Likewise.
	(padBuffer()): Likewise.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(transform(byte[],int)): LIkewise.
	* gnu/java/security/hash/Whirlpool.java,
	(Whirlpool(Whirlpool)): Remove unnecessary casts on clone() call.
	(clone()): Add @Override.
	(transform(byte[],int)): LIkewise.
	(padBuffer()): Likewise.
	(getResult()): Likewise.
	(resetContext()): Likewise.
	(selfTest())): Likewise.
	* gnu/java/security/jce/hash/MessageDigestAdapter.java:
	(clone()): Add @Override.
	(engineGetDigestLength()): Likewise.
	(engineUpdate(byte)): Likewise.
	(engineUpdate(byte[],int,int)): Likewise.
	(engineDigest()): Likewise.
	(engineDigest(byte[],int,int)): Likewise.
	(engineReset()): Likewise.
	* gnu/java/security/jce/sig/DSSKeyPairGeneratorSpi.java:
	(initialize(int,SecureRandom)): Add @Override.
	(initialize(AlgorithmParameterSpec,SecureRandom)): Likewise.
	* gnu/java/security/jce/sig/DSSParametersGenerator.java:
	(engineInit(int,SecureRandom)): Add @Override.
	(engineInit(AlgorithmParameterSpec,SecureRandom)): Likewise.
	(engineGenerateParameters()): Likewise.
	* gnu/java/security/jce/sig/EncodedKeyFactory.java:
	(decodeDSSPublicKey(DSAPublicKeySpec)): Make static.
	(decodeRSAPublicKey(RSAPublicKeySpec)): Likewise.
	(decodeDHPublicKey(DHPublicKeySpec)): Likewise.
	(decodeDHPublicKey(byte[]]): Likewise.
	(decodeDSSPrivateKey(DSAPrivateKeySpec)): Likewise.
	(decodeRSAPrivateKey(RSAPrivateCrtKeySpec)): Likewise.
	(decodeDHPrivateKey(DHPrivateKeySpec)): Likewise.
	(decodeDHPrivateKey(byte[])): Likewise.
	* gnu/java/security/jce/sig/KeyPairGeneratorAdapter.java:
	(initialize(int,SecureRandom)): Add Override.
	(initialize(AlgorithmParameterSpec,SecureRandom)): Likewise.
	(generateKeyPair()): Likewise.
	(localiseName(String)): Uncomment conversion.
	* gnu/java/security/jce/sig/RSAKeyPairGeneratorSpi.java:
	(initialize(int,SecureRandom)): Add Override.
	(initialize(AlgorithmParameterSpec,SecureRandom)): Likewise.
	* gnu/java/security/jce/sig/SignatureAdapter.java:
	Drop unneeded import of BaseSignature.
	(clone()): Add @Override.
	(engineInitVerify(PublicKey)): Reference VERIFIER_KEY via
	interface ISignature where it is defined.
	(engineInitSign(PrivateKey)): Likewise for SIGNER_KEY.
	(engineInitSign(PrivateKey,SecureRandom)): Likewise for
	SIGNER_KEY and SOURCE_OF_RANDOMNESS.
	* gnu/java/security/key/KeyPairCodecFactory.java:
	(getInstance(String,int)): Add default case which returns null.
	(getInstance(Key)): Likewise and fix typo in documentation.
	* gnu/java/security/key/dss/DSSKey.java:
	(getParams()): Add @Override.
	(getAlgorithm()): Likewise.
	(getEncoded()): Likewise.
	(getFormat()): LIkewise.
	(equals(Object)): Likewise.
	(hashCode()): Add implementation using java.util.Objects.hash
	(toString()): Remove unneeded cast.
	* gnu/java/security/key/dss/DSSKeyPairGenerator.java:
	(setup(MAp)): Remove unnecessary else clause.
	(generate()): Remove left-over debug statement.
	* gnu/java/security/key/dss/DSSKeyPairRawCodec.java:
	(getFormatID()): Add @Override.
	(encodePublicKey(PublicKey)): Likewise.
	(decodePublicKey(byte[])): Likewise.
	(encodePrivateKey(PrivateKey)): Likewise.
	(decodePrivateKey(byte[])): Likewise.
	* gnu/java/security/key/dss/DSSKeyPairX509Codec.java:
	(getFormatID()): Add @Override.
	(encodePublicKey(PublicKey)): Likewise.
	(encodePrivateKey(PrivateKey)): Likewise.
	(decodePublicKey(byte[])): Likewise.
	(decodePrivateKey(byte[])): Likewise.
	* gnu/java/security/key/dss/DSSPrivateKey.java:
	Drop unneeded reference to PrivateKey.
	(getX()): Add @Override.
	(getEncoded(int)): Likewise.
	(equals(Object)): Likewise.
	(hashCode()): Implemented.
	(toString()): Add @Override and remove unneeded cast.
	* gnu/java/security/key/dss/DSSPublicKey.java:
	Drop unneeded reference to PublicKey.
	(getY()): Add @Override.
	(getEncoded(int)): Likewise.
	(equals(Object)): Likewise.
	(hashCode()): Implemented.
	(toString()): Add @Override and remove unneeded cast.
	* gnu/java/security/key/rsa/GnuRSAKey.java:
	(getModulus()): Add @Override.
	(getAlgorithm()): Likewise.
	(getEncoded()): Likewise.
	(getFormat()): Likewise.
	(equals(Object)): Likewise.
	(hashCode()): Implemented using java.util.Objects.hash
	(toString()): Add @Override and remove unneeded cast.
	* gnu/java/security/key/rsa/GnuRSAPrivateKey.java:
	Drop unneeded reference to PrivateKey.
	(getPrimeP()): Add @Override.
	(getPrimeQ()): Likewise.
	(getPrimeExponentP()): Likewise.
	(getPrimeExponentQ()): Likewise.
	(getCrtCoefficient()): Likewise.
	(getPrivateExponent()): Likewise.
	(getEncoded(int)): Likewise.
	(equals(Object)): Likewise.
	(hashCode()): Implemented using java.util.Objects.hash.
	(toString()): Add @Override and remove unneeded cast.
	* gnu/java/security/key/rsa/GnuRSAPublicKey.java:
	Drop unneeded reference to PublicKey.
	(getEncoded()): Add @Override.
	(equals(Object)): Likewise.
	(hashCode()): Implemented.
	(toString()): Add @Override and remove unneeded cast.
	* gnu/java/security/key/rsa/RSAKeyPairPKCS8Codec.java:
	(getFormatID()): Add @Override.
	(encodePublicKey(PublicKey)): Likewise.
	(encodePrivateKey(PrivateKey)): Likewise.
	(decodePublicKey(byte[])): Likewise.
	(decodePrivateKey(byte[])): Likewise.
	* gnu/java/security/key/rsa/RSAKeyPairRawCodec.java:
	(getFormatID()): Add @Override.
	(encodePublicKey(PublicKey)): Likewise.
	(decodePublicKey(byte[])): Likewise.
	(encodePrivateKey(PrivateKey)): Likewise.
	(decodePrivateKey(byte[])): Likewise.
	* gnu/java/security/pkcs/PKCS7SignedData.java:
	(PKCS7SignedData(BERReader)): Refer to constants by
	the interface where they are defined. Rename crls
	to avoid shadowing the class variable.
	* gnu/java/security/pkcs/SignerInfo.java:
	(SignerInfo(BERReader)): Refer to constants by the
	interface where they are defined.
	* gnu/java/security/prng/BasePRNG.java:
	(addRandomBytes(byte[])): Add @Override.
	(addRandomBytes(byte[],int,int)): Likewise. Rename
	buffer to buf to avoid shadowing.
	(clone()): Remove unnecessary cast and this references.
	* gnu/java/security/prng/MDGenerator.java:
	Remove unneeded reference to Cloneable.
	* gnu/java/security/prng/RandomEvent.java:
	(RandomEvent(Object,byte,byte,byte[])): Remove unnecessary cast.
	* gnu/java/security/provider/DefaultPolicy.java:
	(getPermissions(CodeSource)): Add @Override.
	(refresh()): Likewise.
	* gnu/java/security/provider/Gnu.java:
	(Gnu()): Add @Override to run implementation in anonymous inner
	class.
	* gnu/java/security/provider/PKIXCertPathValidatorImpl.java:
	(engineValidate(CertPath,CertPathParameters)): Add @Override. Remove
	unneeded cast and else clause.
	(checkExplicitPolicy(int,List)): Make static.
	* gnu/java/security/provider/X509CertificateFactory.java:
	(generateCert(InputStream)): Make static. Remove unnecessary
	else clause.
	(generateCRL(InputStream)): Likewise.
	* gnu/java/security/sig/SignatureCodecFactory.java:
	(getInstance(String,int)): Add default case to switch statement.
	* gnu/java/security/sig/dss/DSSSignature.java:
	(encodeSignature(BigInteger,BigInteger)): Make static.
	(decodeSignature(Object)): Likewise.
	* gnu/java/security/sig/dss/DSSSignatureRawCodec.java:
	(getFormatID()): Add @Override.
	(encodeSignature(Object)): Likewise.
	(decodeSignature(byte[])): Likewise.
	* gnu/java/security/sig/dss/DSSSignatureX509Codec.java:
	(getFormatID()): Add @Override.
	(encodeSignature(Object)): Likewise.
	(decodeSignature(byte[])): Likewise.
	* gnu/java/security/sig/rsa/EMSA_PKCS1_V1_5.java:
	(clone()): Add @Override.
	* gnu/java/security/sig/rsa/EMSA_PSS.java:
	(clone()): Add @Override.
	* gnu/java/security/sig/rsa/RSA.java:
	(RSADP(RSAPrivateKey, BigInteger)): Suppress null warning
	as r is always non-null if rsaBlinding is true.
	* gnu/java/security/sig/rsa/RSAPKCS1V1_5Signature.java:
	(clone()): Add @Override.
	(setupForVerification(PublicKey)): Likewise.
	(setupForSigning(PrivateKey)): Likewise.
	(generateSignature()): Likewise.
	(verifySignature(Object)): Likewise.
	* gnu/java/security/sig/rsa/RSAPKCS1V1_5SignatureRawCodec.java:
	(getFormatID()): Add @Override.
	(encodeSignature(Object)): Likewise.
	(decodeSignature(byte[])): Likewise.
	* gnu/java/security/sig/rsa/RSAPKCS1V1_5SignatureX509Codec.java:
	(getFormatID()): Add @Override.
	(encodeSignature(Object)): Likewise.
	(decodeSignature(byte[])): Likewise.
	* gnu/java/security/sig/rsa/RSAPSSSignature.java:
	(clone()): Add @Override.
	(setupForVerification(PublicKey)): Likewise. Remove unnecessary
	cast.
	(setupForSigning(PrivateKey)): Likewise.
	(generateSignature()): Add @Override.
	(verifySignature(Object)): Likewise.
	* gnu/java/security/sig/rsa/RSAPSSSignatureRawCodec.java:
	(getFormatID()): Add @Override.
	(encodeSignature(Object)): Likewise.
	(decodeSignature(byte[])): Likewise.
	* gnu/java/security/util/ByteArray.java:
	(toString()): Add @Override.
	* gnu/java/security/util/ByteBufferOutputStream.java:
	(toString()): Add @Override.
	* gnu/java/security/util/ExpirableObject.java:
	(destroy()): Add @Override.
	(Destroyer.run()): Likewise.
	* gnu/java/security/util/FormatUtil.java:
	(getEncodingName(int)): Add default case for switch statement.
	(getEncodingShortName(int)): Likewise.
	* gnu/java/security/util/Sequence.java:
	(size()): Add @Override.
	(toArray()): Likewise. Remove unnecessary cast.
	* gnu/java/security/util/SimpleList.java:
	(size()): Add @Override.
	(get(int)): Likewise.
	(toString()): Likewise.
	* gnu/java/security/util/Util.java:
	(toBase64(byte[])): Add default case to switch statement which
	does nothing. Remove unnecessary else clause.
	* gnu/java/security/x509/PolicyNodeImpl.java:
	(addExpectedPolicy(String)): Rename variable to expectedPolicy
	to avoid shadowing policy variable.
	(addAllPolicyQualifiers(Collection)): Rename variable to
	policyQualifiers to avoid shadowing qualifiers variable.
	Rewrite collection check to catch ClassCastException as,
	if it.next() returns normally, it will always be an instance
	of PolicyQualifierInfo.
	(toString()): Add @Override.
	* gnu/java/security/x509/X500DistinguishedName.java:
	(X500DistinguishedName(String)): Throw IOException rather
	than catching it as calling methods in X509CRLSelector
	implementations, addIssuerName(String), expect an
	IOException to be thrown if there is a parsing error.
	(getName()): Add @Override.
	(hashCode()): Likewise.
	(equals(Object)): Likewise.
	(toString()): Likewise.
	(getDer()): Remove unnecessary casts.
	(readAttributeType(Reader)): Make static.
	* gnu/java/security/x509/X509CRL.java:
	(equals(Object)): Add @Override.
	(hashCode()): Likewise.
	(getEncoded()): Remove unnecessary cast.
	(getIssuerX500Principal()): Add @Override.
	(getTBSCertList()): Remove unnecessary cast.
	(getSignature()): Likewise.
	(getSigAlgParams()): Likewise.
	(hasUnsupportedCriticalExtension()): Add @Override.
	(getCriticialExtensionOIDs()): Likewise.
	(getNonCriticalExtensionOIDs()): Likewise.
	(getExtensionValue(String)): Likewise.
	(isRevoked(Certificate)): Likewise. Remove unnecessary
	cast.
	(parse(InputStream)): Remove unnecessary cast.
	* gnu/java/security/x509/X509CRLEntry.java:
	(getEncoded()): Remove unncessary cast.
	(hasUnsupportedCriticalExtension()): Add @Override.
	(getCriticialExtensionOIDs()): Likewise.
	(getNonCriticalExtensionOIDs()): Likewise.
	(getExtensionValue(String)): Likewise.
	* gnu/java/security/x509/X509CRLSelectorImpl.java:
	(addIssuerName(String)): Throw IOException as specified.
	* gnu/java/security/x509/X509CertPath.java:
	(getCertificates()): Add @Override.
	(getEncoded()): Likewise. Remove unnecessary casts.
	(getEncodings()): Add @Override.
	(parse(InputStream, String)): Rename path to parsedPath
	to avoid shadowing.
	* gnu/java/security/x509/X509CertSelectorImpl.java:
	(addIssuerName(String)): Throw IOException as specified.
	* gnu/java/security/x509/X509Certificate.java:
	Remove unneeded Serializable reference.
	(checkValidity()): Add @Override.
	(checkValidity(Date)): Likewise.
	(getVersion()): Likewise.
	(getSerialNumber()): Likewise.
	(getIssuerDN()): Likewise.
	(getIssuerX500Principal()): Likewise.
	(getSubjectDN()): Likewise.
	(getSubjectX500Principal()): Likewise.
	(getNotBefore()): Likewise.
	(getNotAfter()): Likewise.
	(getTBSCertificate()): Likewise. Remove unnecessary cast.
	(getSignature()): Likewise.
	(getSigAlgName()): Add @Override.
	(getSigAlgOID()): Likewise.
	(getSigAlgParams()): Likewise. Remove unnecessary cast.
	(getIssuerUniqueID()): Add @Override.
	(getSubjectUniqueID()): Likewise.
	(getKeyUsage()): Likewise.
	(getExtendedKeyUsage()): Likewise.
	(getBasicConstraints()): Likewise.
	(getSubjectAlternativeNames()): Likewise. Make conversion
	from int to Integer explicit.
	(getIssuerAlternativeNames()): Likewise.
	(hasUnsupportedCriticalExtension()): Add @Override.
	(getCriticialExtensionOIDs()): Likewise.
	(getNonCriticalExtensionOIDs()): Likewise.
	(getExtensionValue(String)): Likewise.
	(getEncoded()): Likewise. Remove unnecessary cast.
	(verify(PublicKey)): Add @Override.
	(verify(PublicKey, String)): Likewise.
	(toString()): Likewise.
	(getPublicKey()): Likewise.
	(parse(InputStream)): Rename encoded to enc to avoid shadowing.
	Avoid unnecessary cast.
	* gnu/java/security/x509/ext/AuthorityKeyIdentifier.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/BasicConstraints.java:
	(getEncoded()): Add @Override. Remove unncessary casts.
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/CRLNumber.java:
	(getEncoded()): Add @Override. Remove unncessary casts.
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/CertificatePolicies.java:
	(CertificatePolicies(List,Map)): Swap empty for-loop
	for a while loop.
	(getEncoded()): Add @Override. Remove unnecessary cast.
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/ExtendedKeyUsage.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/Extension.java:
	(Extension(byte[])): Remove unnecessary cast.
	(getEncoded()): Likewise.
	(toString()): Add @Override.
	(Value.Value(byte[])): Remove unnecessary cast.
	(Value.getEncoded()): Likewise.
	(hashCode()): Add @Override.
	(equals(Object)): Likewise.
	(toString()): Likewise.
	* gnu/java/security/x509/ext/GeneralName.java:
	(Kind.forTag(int)): Add default case.
	(Kind): Remove unnecessary ; on closing brace.
	(GeneralName(Kind,byte[])): Remove unnecessary cast.
	(name()): Likewise.
	(encoded()): Check for null rather than catching exception.
	Remove unnecessary cast.
	(equals(Object)): Add @Override. Avoid unnecessary method call.
	(hashCode()): Implemented using java.util.Objects.hash.
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/GeneralNames.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/GeneralSubtree.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/IssuerAlternativeNames.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/KeyUsage.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/NameConstraints.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/PolicyConstraint.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/PolicyMappings.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/PrivateKeyUsagePeriod.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/ReasonCode.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/SubjectAlternativeNames.java:
	(toString()): Add @Override.
	* gnu/java/security/x509/ext/SubjectKeyIdentifier.java:
	(getKeyIdentifier()): Remove unnecessary cast.
	(toString()): Add @Override.
	* gnu/javax/security/auth/Password.java:
	(doDestroy): Add @Override. Remove unneeded else block.
	(isDestroyed): Add @Override.
	* gnu/javax/security/auth/callback/AWTCallbackHandler.java:
	(handleChoice(ChoiceCallback)): Add @Override.
	(handleConfirmation(ConfirmationCallback)): Likewise.
	(handleLanguage(LanguageCallback)): Likewise.
	(handleName(NameCallback)): Likewise.
	(handlePassword(PasswordCallback)): Likewise.
	(handleTextInput(TextInputCallback)): Likewise.
	(handleTextOutput(TextOutputCallback)): Likewise.
	(actionPerformed(ActionEvent)): Likewise.
	(windowClosing(WindowEvent)): Likewise.
	(windowOpened(WindowEvent)): Likewise.
	(windowClosed(WindowEvent)): Likewise.
	(windowIconified(WindowEvent)): Likewise.
	(windowDeiconified(WindowEvent)): Likewise.
	(windowActivated(WindowEvent)): Likewise.
	(windowDeactivated(WindowEvent)): Likewise.
	* gnu/javax/security/auth/callback/AbstractCallbackHandler.java:
	(AbstractCallbackHandler(String)): Reference getBundle by class
	where it is implemented (ResourceBundle).
	(handle(Callback[])): Add @Override.
	(handleChoice(ChoiceCallback)): Allow and document an
	UnsupportedCallbackException being thrown.
	(handleConfirmation(ConfirmationCallback)): Likewise.
	(handleLanguage(LanguageCallback)): Likewise.
	(handleName(NameCallback)): Likewise.
	(handlePassword(PasswordCallback)): Likewise.
	(handleTextInput(TextInputCallback)): Likewise.
	(handleTextOutput(TextOutputCallback)): Likewise.
	(handleOther(Callback)): Suppress warnings resulting from
	unused variables, unthrown exceptions and lack of IOException
	being thrown. They are necessary for subclasses.
	* gnu/javax/security/auth/callback/ConsoleCallbackHandler.java:
	(handleChoice(ChoiceCallback)): Add @Override. Drop unnecessary
	cast.
	(handleConfirmation(ConfirmationCallback)): Add @Override.
	(handleLanguage(LanguageCallback)): Likewise.
	(handleName(NameCallback)): Likewise.
	(handlePassword(PasswordCallback)): Likewise.
	(handleTextInput(TextInputCallback)): Likewise.
	(handleTextOutput(TextOutputCallback)): Likewise.
	* gnu/javax/security/auth/callback/DefaultCallbackHandler.java:
	(handleChoice(ChoiceCallback)): Add @Override.
	(handleConfirmation(ConfirmationCallback)): Likewise.
	(handleLanguage(LanguageCallback)): Likewise.
	(handleName(NameCallback)): Likewise.
	(handlePassword(PasswordCallback)): Likewise.
	(handleTextInput(TextInputCallback)): Likewise.
	(handleTextOutput(TextOutputCallback)): Likewise.
	* gnu/javax/security/auth/callback/GnuCallbacks.java:
	(GnuCallbacks()): Add @Override to run() implementation
	in anonymous inner class.
	* gnu/javax/security/auth/callback/SwingCallbackHandler.java:
	(handleChoice(ChoiceCallback)): Add @Override to method
	and methods of anonymous inner classes. Refer to
	constants using interface where they appear.
	(handleConfirmation(ConfirmationCallback)): Add @Override
	to method and methods of anonymous inner class. Declare
	UnsupportedCallbackException as thrown and add default
	cases and fall-through markers to switch statements.
	(handleLanguage(LanguageCallback)): Add @Override. Remove
	unused variable defaultIndex.
	(handleName(NameCallback)): Add @Override to method and
	method of anonymous inner class.
	(handlePassword(PasswordCallback)): Likewise.
	(handleTextInput(TextInputCallback)): Likewise. Refer to
	constants using interface where they appear.
	(handleTextOutput(TextOutputCallback)): Likewise. Declare
	UnsupportedCallbackException as thrown and add default
	case to switch statement.
	(waitForInput(JDialog, Callback)): Make static.
	* gnu/javax/security/auth/login/ConfigFileParser.java:
	(initParser(Reader)): Don't declare IOException as thrown
	as one is never thrown.
	(expandParamValue(String)): Make static.
	* gnu/javax/security/auth/login/GnuConfiguration.java:
	(getAppConfigurationEntry(String)): Add @Override.
	(refresh()): Likewise.
	(getInputStreamFromURL(String)): Make static.
	(parseConfig(InputStream)): Remove unneeded variable.
	(getUserName()): Make static.
	(getConfigFromUserName(File,String)): Likewise.
	* java/security/AccessControlContext.java:
	(equals(Object)): Add @Override.
	(hashCode()): Likewise.
	* java/security/AlgorithmParameters.java:
	(toString()): Add @Override.
	* java/security/AllPermission.java:
	(AllPermission(String,String)): Suppress
	warning about actions variable being unused.
	(implies(Permission)): Add @Override.
	(equals(Object)): Likewise.
	(hashCode()): Likewise.
	(getActions()): Likewise.
	(newPermissionCollection()): Likewise.
	(AllPermissionCollection()): Add public constructor
	to avoid generating a synthetic accessor method.
	* java/security/BasicPermission.java:
	Remove unneeded Serializable reference.
	(BasicPermission(String,String)): Suppress
	warnings about actions variable being unused.
	(getActions()): Add @Override.
	(newPermissionCollection()): Likewise.
	* java/security/Certificate.java:
	Mark with @Deprecated. Fix typo in documentation.
	* java/security/DigestInputStream.java:
	(read()): Add @Override.
	(read(byte[],int,int)): Likewise.
	(toString()): Likewise.
	* java/security/DigestOutputStream.java:
	(write(int)): Add @Override.
	(write(byte[],int,int)): Likewise.
	(toString()): Likewise.
	* java/security/DummyKeyPairGenerator.java:
	(clone()): Add @Override.
	(initialize(int,SecureRandom)): Likewise.
	(initialize(AlgorithmParameterSpec,SecureRandom)):
	Likewise.
	(generateKeyPair()): Likewise.
	* java/security/DummyMessageDigest.java:
	(clone()): Add @Override.
	(engineDigest()): Likewise.
	(engineDigest(byte[],int,int)): Likewise.
	(engineGetDigestLength()): Likewise.
	(engineReset()): Likewise.
	(engineUpdate(byte)): Likewise.
	(engineUpdate(byte[],int,int)): Likewise.
	* java/security/Identity.java:
	Mark as @Deprecated. Fix typo in documentation.
	(getName()): Add @Override.
	(equals(Object)): Likewise.
	(toString()): Likewise.
	(toString(boolean)): Remove unnecessary else clause.
	(hashCode()): Add @Override.
	* java/security/IdentityScope.java:
	Mark as @Deprecated.
	(toString()): Add @Override.
	* java/security/IntersectingDomainCombiner.java:
	(combine(ProtectionDomain[],ProtectionDomain[])):
	Add @Override.
	* java/security/KeyPairGenerator.java:
	(generateKeyPair()): Add @Override.
	* java/security/KeyPairGeneratorSpi.java:
	(initialize(AlgorithmParameterSpec,SecureRandom)):
	Suppress warning about making this method static.
	Intended to be overridden by subclasses.
	(clone()): Add @Override.
	* java/security/KeyStore.java:
	(getInstance(String,Provider)): Fix typo in documentation.
	(getDefaultType()): Add @Override to run() in anonymous
	inner class.
	* java/security/MessageDigest.java:
	(toString()): Add @Override.
	(clone()): Likewise.
	* java/security/MessageDigestSpi.java:
	(engineGetDigestLength()): Suppress warning about
	making this method static. Intended to be overridden
	by subclasses.
	(clone()): Add @Override.
	* java/security/Permission.java:
	(checkGuard(Object)): Add @Override.
	(equals(Object)): Likewise.
	(hashCode()): Likewise.
	(newPermissionCollection()): Likewise.
	(toString()): Likewise.
	* java/security/PermissionCollection.java:
	(toString()): Add @Override.
	* java/security/Permissions.java:
	Remove unneeded Serializable reference.
	(elements()): Add @Override to hasMoreElements
	and nextElement methods in anonymous inner class.
	(PermissionsHash.PermissionsHash()): Add explicit
	constructor to avoid a synthetic accessor method.
	(add(Permission)): Mark synchronized.
	(implies(Permission)): Likewise.
	* java/security/Policy.java:
	(implies(ProtectionDomain,Permission)): Remove
	unnecessary cast.
	* java/security/Principal.java:
	(equals(Object)): Add @Override.
	(toString()): Likewise.
	(hashCode()): Likewise.
	* java/security/PrivilegedActionException.java:
	(getCause()): Add @Override.
	(toString()): Removed; pointless as it just calls
	superclass version.
	* java/security/ProtectionDomain.java:
	(ProtectionDomain(CodeSource,PermissionCollection,
	ClassLoader,Principal[],boolean)): Remove unnecessary
	cast.
	(getPrincipals()): Add @Override.
	(toString()): Likewise.
	* java/security/Provider.java:
	Remove unneeded Serializable reference.
	(put(Object,Object)): Add @Override. Suppress warnings
	about overridding a synchronized method as all collection
	modifications are made in synchronized superclass method.
	(get(Object)): Likewise.
	(remove(Object)): Likewise.
	(clear()): Likewise.
	(toString()): Add @Override. Suppress warning about
	overridding a synchronized method as the collection isn't
	used.
	(toCanonicalKey(Object)): Make static.
	* java/security/SecureClassLoader.java:
	(getPermissions(CodeSource)): Suppress warning about
	making this method static; may potentially be overridden
	by subclasses. Avoid unnecessary variable policy.
	* java/security/SecureRandom.java:
	(setSeed(byte[])): Make synchronized to prevent
	concurrent access to secureRandomSpi.
	(setSeed(long)): Add @Override and make synchronized.
	(nextBytes(byte[])): Likewise.
	(next(int)): Likewise.
	(generateSeed(byte[])): Make synchronized.
	* java/security/Security.java:
	(getAlgorithmProperty(String,String)): Add @Deprecated.
	(getProvider(String)): Remove unnecessary else clause.
	(getAlgorithm(String)): Use provs instead of providers
	to avoid shadowing class variable.
	(provides(Provider,String,String,String,String)): Set
	serviceDotAlgorithm to the empty string to avoid null
	pointer issues.
	* java/security/SecurityPermission.java:
	(SecurityPermission(String,String)): Suppress warning
	due to nothing being done with actions.
	* java/security/Signature.java:
	(sign()): Remove unnecessary else clause.
	(sign(byte[],int,int)): Likewise.
	(verify(byte[])): Likewise.
	(toString()): Mark @Override.
	(setParameter(String,Object)): Add @Deprecated.
	(getParameter(String)): Likewise.
	(clone()): Add @Override.
	* java/security/SignatureSpi.java:
	(engineSetParameter(String,Object)): Add @Deprecated.
	(engineSetParameter(AlgorithmParameterSpec)): Suppress
	warnings about unused variables, unthrown exceptions and
	ability to be a static method. Subclasses override this.
	(engineGetParameters()): Suppress warnings about making
	this method static.
	(engineGetParameter(String)): Add @Deprecated.
	* java/security/SignedObject.java:
	(getSignature()): Remove unnecessary cast.
	(readObject(ObjectInputStream)): Likewise x 2.
	* java/security/Signer.java:
	Mark as @Deprecated.
	(toString()): Add @Override.
	* java/security/UnresolvedPermission.java:
	(getUnresolvedCerts()): Remove unnecessaary cast.
	(UnresolvedPermissionCollection.elements()):
	Add @Override to hasMoreElements and nextElement.
	* java/security/acl/Acl.java:
	(toString()): Add @Override.
	* java/security/acl/AclEntry.java:
	(setPrincipal(Principal)): Fix formatting of documentation.
	(addPermission(Permission)): Likewise.
	(removePermission(Permission)): Likewise.
	(checkPermission(Permission)): Likewise.
	(toString()): Add @Override.
	* java/security/acl/Permission.java:
	(equals(Object)): Add @Override.
	(toString()): Likewise.
	* java/security/cert/CRL.java:
	(toString()): Add @Override.
	* java/security/cert/CertPath.java:
	(equals(Object)): Add @Override.
	(hashCode()): Likewise.
	(toString()): Likewise.
	* java/security/cert/CertPathBuilderException.java:
	(CertPathBuilderException(Throwable)): Just call
	superclass constructor.
	(CertPathBuilderException(String,Throwable)): Likewise.
	(getMessage()): Removed; provided by superclass.
	(getCause()): Likewise.
	(toString()): Likewise.
	(printStackTrace()): Likewise.
	(printStackTrace(PrintStream)): Likewise.
	(printStackTrace(PrintWriter)): Likewise.
	* java/security/cert/CertPathValidatorException.java:
	(CertPathValidatorException(String,Throwable)): Just call
	superclass with both arguments, rather than initCause.
	(getMessage()): Removed; provided by superclass.
	(getCause()): Likewise.
	(toString()): Likewise.
	(printStackTrace()): Likewise.
	(printStackTrace(PrintStream)): Likewise.
	(printStackTrace(PrintWriter)): Likewise.
	* java/security/cert/CertStoreException.java:
	(CertStoreException(Throwable)): Just call superclass
	constructor.
	(CertStoreException(String,Throwable)): Likewise.
	(getMessage()): Removed; provided by superclass.
	(getCause()): Likewise.
	(toString()): Likewise.
	(printStackTrace()): Likewise.
	(printStackTrace(PrintStream)): Likewise.
	(printStackTrace(PrintWriter)): Likewise.
	* java/security/cert/CertStoreSpi.java:
	(CertStoreSpi(CertStoreParameters)): Suppress warnings
	about exception not being thrown. Present for subclasses.
	* java/security/cert/Certificate.java:
	(equals(Object)): Add @Override.
	(hashCode()): Likewise.
	(toString()): Likewise.
	* java/security/cert/CertificateFactorySpi.java:
	(engineGenerateCertPath(InputStream)): Suppress warnings
	about unused arguments, exceptions not being thrown and
	method can be static. Provided for subclass implementations.
	(engineGenerateCertPath(InputStream,String)): Likewise.
	(engineGenerateCertPath(List)): Likewise.
	(engineGetCertPathEncodings()): Likewise.
	* java/security/cert/CollectionCertStoreParameters.java:
	(toString()): Add @Override.
	* java/security/cert/LDAPCertStoreParameters.java:
	(clone()): Add @Override.
	(toString()): Likewise.
	* java/security/cert/PKIXBuilderParameters.java:
	(toString()): Likewise.
	* java/security/cert/PKIXCertPathBuilderResult.java:
	(getCertPath()): Add @Override.
	(toString()): Likewise.
	* java/security/cert/PKIXCertPathChecker.java:
	(clone()): Add @Override.
	* java/security/cert/PKIXCertPathValidatorResult.java:
	(clone()): Add @Override.
	(toString()): Likewise.
	* java/security/cert/PKIXParameters.java:
	(clone()): Add @Overrride.
	(toString()): Likewise.
	* java/security/cert/PolicyQualifierInfo.java:
	(PolicyQualifierInfo(byte[])): Remove unnecessary cast.
	(getEncoded()): Likewise.
	(toString()): Add @Override.
	* java/security/cert/TrustAnchor.java:
	(TrustAnchor(X509Certificate,byte[])): Remove unnecessary cast.
	(TrustAnchor(String,PublicKey,byte[])): Document exceptions.
	Catch IOException and throw as IllegalArgumentException.
	Remove unnecessary casts.
	(toString()): Add @Override.
	* java/security/cert/X509CRL.java:
	(equals(Object)): Add @Override.
	(hashCode()): Likewise.
	(getIssuerX500Principal()): Suppress warning about making this
	static. Should be overridden by subclasses.
	* java/security/cert/X509CRLEntry.java:
	(equals(Object):: Add @Override.
	(hashCode()): Likewise.
	(toString()): Likewise.
	* java/security/cert/X509CRLSelector.java:
	Remove unneeded Cloneable reference.
	(getIssuerNames()): Remove unneeded else block.
	(toString()): Add @Override.
	(match(CRL)): Likewise.
	(clone()): LIkewise.
	* java/security/cert/X509CertSelector.java:
	Remove unneeded Cloneable reference.
	(makeName(int,String)): Re-use earlier result of Kind.forTag(id).
	Add default case.
	(clone()): Add @Override.
	(getAuthorityKeyIdentifier()): Remove unneeded else block
	and cast.
	(getCertificateValid()): Remove unneeded else block.
	(getExtendedKeyUsage()): Likewise.
	(getIssuerAsBytes()): Likewise.
	(getIssuerAsString()): Likewise.
	(getKeyUsage()): Likewise and remove unneeded cast.
	(getNameConstraints()): Likewise.
	(getPathToNames()): Explicitly convert int to Integer.
	(getPrivateKeyValid()): Suppress static method warning.
	Method is deliberately useless.
	(getSubjectAlternativeNames()): Explicitly convert int to
	Integer.
	(getSubjectAsBytes()): Remove unneeded else block.
	(getSubjectAsString()): Likewise.
	(getSubjectKeyIdentifier()): Likewise and remove unneeded
	cast.
	(match(Certificate)): Add @Override. Rename cert to other
	to avoid shadowing.
	(setNameConstraints(byte[])): Remove unnecessary cast.
	Suppress warnings about NameConstraints instance being unused.
	(setPrivateKeyValid()): Suppress unused variable warning.
	Method is deliberately useless.
	(setSubjectPublicKey(PublicKey)): Remove unneeded cast.
	(toString()): Add @Override.
	* java/security/cert/X509Certificate.java:
	(getExtendedKeyUsage()): Suppress unthrown exception warning
	and static method suggestion. Overridden by subclasses.
	(getSubjectAlternativeNames()): Likewise.
	(getIssuerAlternativeNames()): Likewise.
	(getSubjectX500Principal()): Suppress static method suggestion.
	Overridden by subclasses.
	(getIssuerX500Principal()): Likewise.
	* java/security/spec/DSAParameterSpec.java:
	(getP()): Add @Override.
	(getQ()): Likewise.
	(getG()): Likewise.
	* java/security/spec/PKCS8EncodedKeySpec.java:
	(getEncoded()): Add @Override.
	(getFormat()): Likewise.
	* java/security/spec/RSAMultiPrimePrivateCrtKeySpec.java:
	(RSAMultiPrimePrivateCrtKeySpec(BigInteger,BigInteger,BigInteger,
	BigInteger,BigInteger,BigInteger,BigInteger,BigInteger,
	RSAOtherPrimeInfo[])): Remove unneeded else block.
	* java/security/spec/X509EncodedKeySpec.java:
	(getEncoded()): Add @Override.
	(getFormat()): Likewise.
	* javax/security/auth/Policy.java:
	Add @Deprecated.
	* javax/security/auth/PrivateCredentialPermission.java:
	Remove unneeded Serializable reference.
	(equals(Object)): Add @Override. Rename principals to
	thisPrincipals to avoid shadowing.
	(getActions()): Add @Override.
	(hashCode()): Likewise.
	(implies(Permission)): Likewise. Rename principals to
	thisPrincipals to avoid shadowing.
	(newPermissionCollection()): Add @Override to method
	and anonymous inner class implementations of equals(Object) &
	hashCode().
	* javax/security/auth/SubjectDomainCombiner.java:
	(combine(ProtectionDomain[],ProtectionDomain[])): Add @Override.
	* javax/security/auth/callback/ConfirmationCallback.java:
	(setOptions(String[],int)): Move reference to options.length to
	after options null check.
	* javax/security/auth/kerberos/KerberosKey.java:
	Remove unneeded Serializable reference.
	(getAlgorithm()): Add @Override.
	(getFormat()): Likewise.
	(getEncoded()): Likewise and remove unnecessary cast.
	(destroy()): Add @Override.
	(isDestroyed()): Likewise.
	(toString()): Likewise.
	* javax/security/auth/kerberos/KerberosPrincipal.java:
	(getName()): Add @Override.
	(hashCode()): Likewise.
	(equals(Object)): Likewise.
	(toString()): Likewise.
	* javax/security/auth/kerberos/KerberosTicket.java:
	(asn1Encoding): Remove @SuppressWarnings.
	(KerberosTicket(byte[],KerberosPrincipal,KerberosPrincipal,
	byte[],int,boolean[],Date,Date,Date,Date,InetAddress[])):
	Remove unnecessary cast. Remove duplicate assignment to flags.
	(destroy()): Add @Override.
	(isDestroyed()): Likewise.
	(isCurrent()): Likewise.
	(refresh()): Likewise.
	(getFlags()): Remove unnecessary cast.
	(getEncoded()): Likewise.
	(toString()): Add @Override.
	* javax/security/auth/kerberos/KeyImpl.java:
	Remove unneeded Serializable reference.
	(KeyImpl(byte[],int)): Remove unnecessary cast.
	(getAlgorithm()): Add @Override.
	(getEncoded()): Likewise.
	(getFormat()): Likewise.
	(toString()): Likewise.
	* javax/security/auth/login/AppConfigurationEntry.java:
	(toString()): Add @Override.
	(LoginModuleControlFlag.toString()): Likewise.
	* javax/security/auth/login/Configuration.java:
	(getConfig()): Use GetSecurityPropertyAction rather than
	a bespoke PrivilegedAction implementation.
	* javax/security/auth/login/LoginContext.java:
	(LoginContext(String,Subject,CallbackHandler,Configuration)):
	Rename entries to appEntries to avoid shadowing.
	(lookupModule(AppConfigurationEntry,Subject,Map)): Rename
	subject to subj to avoid shadowing. Check module is null
	rather than cause is non-null.
	* javax/security/auth/login/NullConfiguration.java:
	(getAppConfigurationEntry(String)): Add @Override.
	(refresh()): Likewise.
	* javax/security/auth/x500/X500Principal.java:
	(hashCode()): Add @Override.
	(equals(Object)): Likewise.
	(getEncoded()): Remove unnecessary cast.
	(getName()): Add @Override.
	(toString()): Likewise.
	(readAttributeType(Reader)): Make static.
	(parseDer(InputStream)): Rename encoded to encodedStream to
	avoid shadowing.
	* javax/security/auth/x500/X500PrivateCredential.java:
	(destroy()): Add @Override.
	(isDestroyed()): Likewise.
	* javax/security/cert/Certificate.java:
	(equals(Object)): Add @Override.
	(hashCode()): Likewise.
	(toString()): Likewise.
	* javax/security/cert/X509CertBridge.java:
	(getEncoded()): Add @Override.
	(verify(PublicKey)): Likewise.
	(verify(PublicKey,String)): Likewise.
	(toString()): Likewise.
	(getPublicKey()): Likewise.
	(checkValidity()): Likewise.
	(checkValidity(Date)): Likewise.
	(getVersion()): Likewise.
	(getSerialNumber()): Likewise.
	(getIssuerDN()): Likewise.
	(getSubjectDN()): Likewise.
	(getNotBefore()): Likewise.
	(getNotAfter()): Likewise.
	(getSigAlgName()): Likewise.
	(getSigAlgOID()): Likewise.
	(getSigAlgParams()): Likewise.
	* javax/security/sasl/Sasl.java:
	(createSaslClient(String[],String,String,String,Map,CallbackHandler)):
	Remove unnecessary else clause and pointless result assignment.
	(createSaslServer(String,String,String,Map,CallbackHandler)): Likewise.
	* javax/security/sasl/SaslException.java:
	Remove unneeded Serializable reference.
	(SaslException(String,Throwable)): Add cause to superclass call.
	(getCause()): Add @Override.
	(printStackTrace()): Removed; provided by superclass.
	(printStackTrace(PrintStream)): Likewise.
	(printStackTrace(PrintWriter)): Likewise.
	(initCause(Throwable)): Call superclass version, then sync the
	local copy.
	(toString()): Add @Override.







PR64881: KeyPairGenerator.genKeyPair() ends up calling the default generateKeyPair method which returns a DSA generator
2015-02-02T15:28:40+00:00

Andrew John Hughes
gnu_andrew@member.fsf.org

2015-02-02T15:28:40+00:00

55c5097f9ce57cb5ebdbec6383c6c89ad4933348

2015-01-30  Andrew John Hughes  <gnu_andrew@member.fsf.org>

	PR classpath/64881
	* NEWS: Updated.
	* java/security/KeyPairGenerator.java:
	(genKeyPair()): Document properly. Call original
	method, generateKeyPair().
	(generateKeyPair()): Document properly. Use provider
	and algorithm values if set rather than just defaulting
	to GNU and DSA.

Signed-off-by: Andrew John Hughes <gnu_andrew@member.fsf.org>





2015-01-30  Andrew John Hughes  <gnu_andrew@member.fsf.org>

	PR classpath/64881
	* NEWS: Updated.
	* java/security/KeyPairGenerator.java:
	(genKeyPair()): Document properly. Call original
	method, generateKeyPair().
	(generateKeyPair()): Document properly. Use provider
	and algorithm values if set rather than just defaulting
	to GNU and DSA.

Signed-off-by: Andrew John Hughes <gnu_andrew@member.fsf.org>







Implement java.util.Objects.
2015-01-07T02:16:30+00:00

Andrew John Hughes
gnu_andrew@member.fsf.org

2015-01-07T02:16:30+00:00

92f6e5177fbd0c8bfdbecce4b5704d981f4988bb

2015-01-06  Andrew John Hughes  <gnu_andrew@member.fsf.org>

	* NEWS: Updated.
	* java/util/Objects.java: New class.
	(compareTo(T,T,Comparator)): Implemented.
	(deepEquals(Object,Object)): Likewise.
	(equals(Object,Object)): Likewise.
	(hash(Object...)): Likewise.
	(hashCode(Object)): Likewise.
	(requireNonNull(T)): Likewise.
	(requireNonNull(T,String)): Likewise.
	(toString(Object)): Likewise.
	(toString(Object,String)): Likewise.

Signed-off-by: Andrew John Hughes <gnu_andrew@member.fsf.org>





2015-01-06  Andrew John Hughes  <gnu_andrew@member.fsf.org>

	* NEWS: Updated.
	* java/util/Objects.java: New class.
	(compareTo(T,T,Comparator)): Implemented.
	(deepEquals(Object,Object)): Likewise.
	(equals(Object,Object)): Likewise.
	(hash(Object...)): Likewise.
	(hashCode(Object)): Likewise.
	(requireNonNull(T)): Likewise.
	(requireNonNull(T,String)): Likewise.
	(toString(Object)): Likewise.
	(toString(Object,String)): Likewise.

Signed-off-by: Andrew John Hughes <gnu_andrew@member.fsf.org>







PR64176: Week of year field during end of year transition is incorrect
2014-12-22T01:31:38+00:00

Andrew John Hughes
gnu_andrew@member.fsf.org

2014-12-22T01:31:38+00:00

f74797dcba95e7902cb1364deb718c2633ff3bb3

2014-12-15  Andrew John Hughes  <gnu_andrew@member.fsf.org>

	PR classpath/64176
	* NEWS: Updated.
	* java/util/GregorianCalendar.java:
	(computeFields()): Handle the week that runs over
	the end of the year and the beginning of the next
	one, so that it is numbered the same in both years.
	(getBaseWeekOfYear(int,int,int)): Broken out of
	computeFields to avoid code duplication.
	(getRelativeWeekday(int)): Likewise.

Signed-off-by: Andrew John Hughes <gnu_andrew@member.fsf.org>





2014-12-15  Andrew John Hughes  <gnu_andrew@member.fsf.org>

	PR classpath/64176
	* NEWS: Updated.
	* java/util/GregorianCalendar.java:
	(computeFields()): Handle the week that runs over
	the end of the year and the beginning of the next
	one, so that it is numbered the same in both years.
	(getBaseWeekOfYear(int,int,int)): Broken out of
	computeFields to avoid code duplication.
	(getRelativeWeekday(int)): Likewise.

Signed-off-by: Andrew John Hughes <gnu_andrew@member.fsf.org>







Fix majority of warnings in gnu.java.security.* and java.security.*.
2014-10-13T19:00:13+00:00

Andrew John Hughes
gnu_andrew@member.fsf.org

2014-10-13T19:00:13+00:00

82c3cd04a94740401ccfce52e67dcc2ed588e40d

Also fixes PR58688 as a consequence.

2014-10-09  Andrew John Hughes  <gnu_andrew@member.fsf.org>

	* NEWS: Updated.
	* gnu/java/security/util/IntegerUtil.java: Removed.
	Methods are available in java.lang.Integer.
	* gnu/java/security/Engine.java:
	Add missing type parameters to Class, Constructor and
	Enumeration.
	* gnu/java/security/OID.java:
	Add type parameter to Comparable implementation.
	(compareTo(OID)): Changed from compareTo(Object).
	Remove now redundant cast.
	* gnu/java/security/Properties.java:
	Add type parameters to HashMap.
	(getProperty(String)): Remove redundant cast.
	(init()): Use generic implementation of PrivilegedAction.
	Add properties in a for-each loop to get correct types.
	* gnu/java/security/action/SetAccessibleAction.java:
	Use generic implementation of PrivilegedAction.
	* gnu/java/security/ber/BEREncodingException.java:
	Add explicit serialVersionUID.
	* gnu/java/security/der/BitString.java:
	Add type parameter to Comparable implementation.
	(compareTo(BitString)): Changed from compareTo(Object).
	Remove now redundant cast.
	* gnu/java/security/der/DEREncodingException.java:
	Add explicit serialVersionUID.
	* gnu/java/security/der/DERWriter.java:
	(write(OutputStream,DERValue)): Cast List and Set
	to correct generic versions.
	(writeSequence(OutputStream,List)): Add type parameters.
	Drop now redundant cast.
	(writeSet(OutputStream,Set)): Likewise.
	* gnu/java/security/hash/HashFactory.java:
	(getNames()): Add type parameters.
	* gnu/java/security/hash/Whirlpool.java:
	Drop unused byte array.
	* gnu/java/security/jce/prng/HavalRandomSpi.java:
	Add explicit serialVersionUID.
	* gnu/java/security/jce/prng/MD2RandomSpi.java: Likewise.
	* gnu/java/security/jce/prng/MD4RandomSpi.java: Likewise.
	* gnu/java/security/jce/prng/MD5RandomSpi.java: Likewise.
	* gnu/java/security/jce/prng/RipeMD128RandomSpi.java: Likewise.
	* gnu/java/security/jce/prng/RipeMD160RandomSpi.java: Likewise.
	* gnu/java/security/jce/prng/SecureRandomAdapter.java:
	Likewise. Drop unused mdName variable. Remove redundant casts.
	Add Override annotation to interface implementation.
	* gnu/java/security/jce/prng/Sha160RandomSpi.java:
	Add explicit serialVersionUID.
	* gnu/java/security/jce/prng/Sha256RandomSpi.java: Likewise.
	* gnu/java/security/jce/prng/Sha384RandomSpi.java: Likewise.
	* gnu/java/security/jce/prng/Sha512RandomSpi.java: Likewise.
	* gnu/java/security/jce/prng/TigerRandomSpi.java: Likewise.
	* gnu/java/security/jce/prng/WhirlpoolRandomSpi.java: Likewise.
	* gnu/java/security/jce/sig/DSSKeyFactory.java: Add Override
	annotation to interface implementation.
	(engineGetKeySpec(Key,Class)): Update return type. Use
	keySpec.cast to cast newly created instances to the correct type.
	* gnu/java/security/jce/sig/DSSKeyPairGeneratorSpi.java:
	Add missing type parameters and Override annotations.
	* gnu/java/security/jce/sig/DSSParameters.java:
	Add Override annotation to interface implementation.
	(engineGetParameterSpec(Class)): Update return type. Use
	paramSpec.cast to cast new instances to correct type.
	(engineGetEncoded()): Add missing type parameter to list.
	* gnu/java/security/jce/sig/EncodedKeyFactory.java:
	Add type parameters and Override annotations.
	(engineGetKeySpec(Key,Class)): Update return type. Use
	keySpec.cast to cast new instances to correct type.
	* gnu/java/security/jce/sig/RSAKeyFactory.java:
	Add @Override annotation. Drop unused variables.
	(engineGetKeySpec(Key,Class)): Update return type. Use
	keySpec.cast to cast new instances to correct type.
	* gnu/java/security/jce/sig/RSAKeyPairGeneratorSpi.java:
	Add type parameters.
	* gnu/java/security/jce/sig/SignatureAdapter.java:
	Add type parameters and Override annotation.
	* gnu/java/security/key/IKeyPairGenerator.java:
	(setup(Map)): Add type parameters.
	* gnu/java/security/key/KeyPairCodecFactory.java:
	Add type parameters.
	* gnu/java/security/key/KeyPairGeneratorFactory.java: Likewise.
	* gnu/java/security/key/dss/DSSKey.java:
	Add explicit serialVersionUID.
	* gnu/java/security/key/dss/DSSKeyPairGenerator.java:
	Add type parameters and Override annotations.
	* gnu/java/security/key/dss/DSSKeyPairPKCS8Codec.java:
	Likewise.
	* gnu/java/security/key/dss/DSSKeyPairX509Codec.java:
	Add type parameters.
	* gnu/java/security/key/dss/DSSPrivateKey.java:
	Add explicit serialVersionUID.
	* gnu/java/security/key/dss/DSSPublicKey.java: Likewise.
	* gnu/java/security/key/rsa/GnuRSAKey.java: Likewise.
	* gnu/java/security/key/rsa/GnuRSAPrivateKey.java: Likewise.
	* gnu/java/security/key/rsa/GnuRSAPublicKey.java: Likewise.
	* gnu/java/security/key/rsa/RSAKeyPairGenerator.java:
	Add Override annotations and type parameters.
	* gnu/java/security/key/rsa/RSAKeyPairPKCS8Codec.java:
	Add missing type parameters on ArrayList instances.
	* gnu/java/security/key/rsa/RSAKeyPairX509Codec.java:
	Add Override annotations and type parameters.
	* gnu/java/security/pkcs/PKCS7SignedData.java:
	(PKCS7SignedData(BERReader)): Add a type parameter to
	the algId list and ensure all additions are homogenous.
	Add other missing type parameters.
	(PKCS7SignedData(Set,PKCS7Data,Certificate[],X509CRL[],Set)):
	Add missing type parameters.
	(getDigestAlgorithms()): Do a deep copy of the set.
	(getSignerInfos()): Add type parameters.
	(encode(OutputStream)): Likewise.
	* gnu/java/security/pkcs/SignerInfo.java:
	Drop unused variable, count. Add type parameters.
	(encode(OutputStream)): Include derAuthenticatedAttributes
	and derUnauthenticatedAttributes in signerInfo.
	* gnu/java/security/prng/BasePRNG.java:
	Add type parameters and Override annotations.
	* gnu/java/security/prng/IRandom.java: Add type parameters.
	* gnu/java/security/prng/LimitReachedException.java:
	Add explicit serialVersionUID.
	* gnu/java/security/prng/MDGenerator.java:
	Add type parameters and Override annotations.
	* gnu/java/security/prng/PRNGFactory.java:
	Add missing type parameters.
	* gnu/java/security/prng/RandomEvent.java:
	Add explicit serialVersionUID.
	* gnu/java/security/provider/CollectionCertStoreImpl.java:
	Add Override annotation and missing type parameters.
	* gnu/java/security/provider/Gnu.java:
	Add explicit serialVersionUID. Parameterise implementation
	of PrivilegedAction.
	* gnu/java/security/provider/PKIXCertPathValidatorImpl.java:
	Add missing type parameters. Remove unused qualifierInfos
	variable.
	* gnu/java/security/provider/X509CertificateFactory.java:
	Add Override annotations and type parameters.
	* gnu/java/security/sig/BaseSignature.java: Likewise.
	* gnu/java/security/sig/ISignature.java: Add type parameters.
	* gnu/java/security/sig/SignatureCodecFactory.java: Likewise.
	* gnu/java/security/sig/SignatureFactory.java: Likewise.
	* gnu/java/security/sig/dss/DSSSignature.java:
	Add Override annotations and type parameters.
	* gnu/java/security/sig/dss/DSSSignatureX509Codec.java: Add
	type parameter to ArrayList instance.
	* gnu/java/security/sig/rsa/EMSA_PKCS1_V1_5.java:
	Remove unused hLen variable.
	* gnu/java/security/sig/rsa/RSASignatureFactory.java:
	Add type parameters.
	* gnu/java/security/util/PRNG.java:
	(getInstance()): Move initialisation code to shared
	method, initialiseDelegate.
	(nextBytes(byte[],int,int)): Call out to initialiseDelegate
	to re-initialise.
	(initialiseDelegate(IRandom)): New common method for
	shared code.
	* gnu/java/security/util/Sequence.java:
	Add Override annotation and type parameters.
	* gnu/java/security/util/SimpleList.java:
	Add type parameters.
	* gnu/java/security/x509/GnuPKIExtension.java: Likewise.
	* gnu/java/security/x509/PolicyNodeImpl.java:
	Add type parameters and Override annotations.
	(addAllPolicyQualifiers(Collection)): Qualify reference
	to addAll.
	* gnu/java/security/x509/X500DistinguishedName.java:
	Add type parameters.
	* gnu/java/security/x509/X509CRL.java:
	Remove unused variable algParams. Add type parameters
	and Override annotations.
	* gnu/java/security/x509/X509CRLEntry.java:
	Add type parameters and Override annotations.
	* gnu/java/security/x509/X509CRLSelectorImpl.java:
	Likewise.
	* gnu/java/security/x509/X509CertPath.java:
	Add type parameters.
	(pkcsEncoded): Renamed from pkcs_encoded.
	(pkiEncoded): Renamed from pki_encoded.
	* gnu/java/security/x509/X509CertSelectorImpl.java:
	Add type parameters and Override annotations.
	* gnu/java/security/x509/X509Certificate.java: Likewise.
	* gnu/java/security/x509/ext/BasicConstraints.java:
	Add type parameters.
	* gnu/java/security/x509/ext/CertificatePolicies.java:
	Likewise.
	* gnu/java/security/x509/ext/PolicyMappings.java:
	Likewise.
	* gnu/javax/crypto/cipher/IBlockCipher.java:
	Add type parameters.
	* gnu/javax/crypto/jce/prng/FortunaImpl.java:
	(engineSetSeed(byte[])): Add cast for singletonMap
	invocation.
	* gnu/javax/crypto/key/dh/DHKeyPairPKCS8Codec.java:
	Add type parameters.
	* gnu/javax/crypto/key/dh/DHKeyPairX509Codec.java:
	Likewise.
	* gnu/javax/crypto/mac/IMac.java: Likewise.
	* gnu/javax/crypto/mode/BaseMode.java:
	Add Override annotations and type parameters.
	* gnu/javax/crypto/mode/EAX.java:
	Add Override annotations, type parameters and
	casts for singletonMap invocations.
	* gnu/javax/crypto/prng/Fortuna.java: Likewise.
	* gnu/javax/net/ssl/Session.java:
	Add Override annotations and type parameters.
	* gnu/javax/net/ssl/provider/AbstractHandshake.java:
	Fix type parameters.
	* gnu/javax/net/ssl/provider/SSLRandom.java:
	Add Override annotations and type parameters.
	* gnu/javax/net/ssl/provider/TLSRandom.java:
	Likewise.
	(hmacSHA): Renamed from hmac_sha.
	(hmacMD5): Renamed from hmac_md5.
	* gnu/javax/net/ssl/provider/Util.java:
	(transform(Object,Class,String,Object[])): Use
	a type parameter T rather than Object.
	* gnu/javax/net/ssl/provider/X509KeyManagerFactory.java:
	Add type parameters.
	* gnu/javax/net/ssl/provider/X509TrustManagerFactory.java:
	Likewise.
	* gnu/javax/security/auth/callback/AWTCallbackHandler.java:
	Replace calls to deprecated show() with setVisible(true).
	(ACTION_NO): Remove unused variable.
	(ACTION_YES): Likewise.
	* gnu/javax/security/auth/callback/ConsoleCallbackHandler.java:
	Add type parameters.
	* gnu/javax/security/auth/callback/GnuCallbacks.java:
	Add explicit serialVersionUID. Convert PrivilegedAction
	implementation to parameterised version.
	* gnu/javax/security/auth/login/ConfigFileParser.java:
	Add type parameters.
	* gnu/javax/security/auth/login/GnuConfiguration.java:
	Likewise. Fix typo.
	* java/security/AccessControlContext.java:
	Add type parameters.
	* java/security/AllPermission.java:
	Add Override annotations.
	(AllPermissionCollection.elements()): Add type parameter
	to return type and return appropriately typed enumerations.
	* java/security/BasicPermission.java:
	Add type parameters and Override annotations.
	* java/security/CodeSource.java: Likewise.
	* java/security/DummySignature.java:
	Add Override annotations.
	* java/security/Identity.java:
	Add type parameters.
	* java/security/IntersectingDomainCombiner.java:
	Likewise.
	* java/security/KeyPairGenerator.java:
	Add Override annotations.
	* java/security/Permissions.java:
	Add type parameters and Override annotations.
	(elements()): Rename main_enum and sub_enum
	to mainEnum and subEnum respectively.
	* java/security/Policy.java: Add type parameters.
	* java/security/SecureRandom.java: Add missing
	type parameter. Remove unused imports.
	* java/security/Security.java:
	Add type parameters. Fix mis-spelling of 'query'.
	* java/security/SignatureSpi.java: Add
	Override annotation.
	* java/security/UnresolvedPermission.java:
	Add Override annotations and type parameters.
	(elements()): Rename main_enum and sub_enum
	to mainEnum and subEnum respectively.
	* java/security/cert/CertPath.java:
	Add type parameters.
	* java/security/cert/CertPathValidator.java:
	(getDefaultType()): Use GetSecurityPropertyAction
	rather than implementing PrivilegedAction locally.
	* java/security/cert/CertStore.java:
	(getDefaultType()): Use GetSecurityPropertyAction
	rather than implementing PrivilegedAction locally.
	* java/security/cert/CollectionCertStoreParameters.java:
	Add type parameters and Override annotations.
	* java/security/cert/PKIXParameters.java:
	Add type parameters.
	* java/security/cert/X509CRLSelector.java:
	Add type parameters.
	(getIssuerNames()): Return a deep copy.
	* java/security/cert/X509CertSelector.java:
	Add type parameters.
	* java/util/Properties.java:
	Add type parameters.
	(stringPropertyNames()): Implemented.
	* javax/naming/directory/BasicAttribute.java:
	Add Override annotations and missing type parameter.
	* javax/security/auth/AuthPermission.java:
	Add explicit serialVersionUID.
	* javax/security/auth/DestroyFailedException.java:
	Likewise.
	* javax/security/auth/PrivateCredentialPermission.java:
	Add type parameters.
	(equals(Object)): Use thatPrincipals instead of
	that_principals.
	(implies(Permission)): Likewise.
	(CredOwner): Add explicit serialVersionUID.
	* javax/security/auth/RefreshFailedException.java:
	Add explicit serialVersionUID.
	* javax/security/auth/Subject.java:
	Add type parameters and Override annotations.
	* javax/security/auth/SubjectDomainCombiner.java:
	Add type parameters.
	* javax/security/auth/callback/ChoiceCallback.java:
	Add explicit serialVersionUID.
	* javax/security/auth/callback/ConfirmationCallback.java:
	Likewise.
	* javax/security/auth/callback/LanguageCallback.java:
	Likewise.
	* javax/security/auth/callback/NameCallback.java:
	Likewise.
	* javax/security/auth/callback/PasswordCallback.java:
	Likewise.
	* javax/security/auth/callback/TextInputCallback.java:
	Likewise.
	* javax/security/auth/callback/TextOutputCallback.java:
	Likewise.
	* javax/security/auth/callback/UnsupportedCallbackException.java:
	Likewise.
	* javax/security/auth/kerberos/DelegationPermission.java:
	Re-enable explicit serialVersionUID. Add Override annotations
	and type parameters.
	* javax/security/auth/kerberos/KerberosPrincipal.java:
	Re-enable explicit serialVersionUID.
	* javax/security/auth/kerberos/KerberosTicket.java:
	Suppress warning about unused asn1Encoding variable.
	* javax/security/auth/kerberos/KeyImpl.java:
	Re-enable explicit serialVersionUID.
	* javax/security/auth/kerberos/ServicePermission.java:
	Re-enable explicit serialVersionUID. Add Override annotations
	and type parameters.
	* javax/security/auth/login/AppConfigurationEntry.java:
	Add type parameters.
	* javax/security/auth/login/Configuration.java: Likewise.
	* javax/security/auth/login/LoginContext.java: Likewise.
	* javax/security/auth/x500/X500Principal.java: Likewise.
	(fixed): Remove unused variable.
	* javax/security/cert/CertificateEncodingException.java:
	Add explicit serialVersionUID.
	* javax/security/cert/CertificateException.java: Likewise.
	* javax/security/cert/CertificateExpiredException.java:
	Likewise.
	* javax/security/cert/CertificateNotYetValidException.java:
	Likewise.
	* javax/security/cert/CertificateParsingException.java:
	Likewise.
	* javax/security/sasl/AuthenticationException.java:
	Likewise.
	* javax/security/sasl/RealmCallback.java: Likewise.
	* javax/security/sasl/RealmChoiceCallback.java: Likewise.
	* javax/security/sasl/Sasl.java: Add type parameters.
	* tools/gnu/classpath/tools/jarsigner/SFHelper.java:
	Likewise.

Signed-off-by: Andrew John Hughes <gnu_andrew@member.fsf.org>





Also fixes PR58688 as a consequence.

2014-10-09  Andrew John Hughes  <gnu_andrew@member.fsf.org>

	* NEWS: Updated.
	* gnu/java/security/util/IntegerUtil.java: Removed.
	Methods are available in java.lang.Integer.
	* gnu/java/security/Engine.java:
	Add missing type parameters to Class, Constructor and
	Enumeration.
	* gnu/java/security/OID.java:
	Add type parameter to Comparable implementation.
	(compareTo(OID)): Changed from compareTo(Object).
	Remove now redundant cast.
	* gnu/java/security/Properties.java:
	Add type parameters to HashMap.
	(getProperty(String)): Remove redundant cast.
	(init()): Use generic implementation of PrivilegedAction.
	Add properties in a for-each loop to get correct types.
	* gnu/java/security/action/SetAccessibleAction.java:
	Use generic implementation of PrivilegedAction.
	* gnu/java/security/ber/BEREncodingException.java:
	Add explicit serialVersionUID.
	* gnu/java/security/der/BitString.java:
	Add type parameter to Comparable implementation.
	(compareTo(BitString)): Changed from compareTo(Object).
	Remove now redundant cast.
	* gnu/java/security/der/DEREncodingException.java:
	Add explicit serialVersionUID.
	* gnu/java/security/der/DERWriter.java:
	(write(OutputStream,DERValue)): Cast List and Set
	to correct generic versions.
	(writeSequence(OutputStream,List)): Add type parameters.
	Drop now redundant cast.
	(writeSet(OutputStream,Set)): Likewise.
	* gnu/java/security/hash/HashFactory.java:
	(getNames()): Add type parameters.
	* gnu/java/security/hash/Whirlpool.java:
	Drop unused byte array.
	* gnu/java/security/jce/prng/HavalRandomSpi.java:
	Add explicit serialVersionUID.
	* gnu/java/security/jce/prng/MD2RandomSpi.java: Likewise.
	* gnu/java/security/jce/prng/MD4RandomSpi.java: Likewise.
	* gnu/java/security/jce/prng/MD5RandomSpi.java: Likewise.
	* gnu/java/security/jce/prng/RipeMD128RandomSpi.java: Likewise.
	* gnu/java/security/jce/prng/RipeMD160RandomSpi.java: Likewise.
	* gnu/java/security/jce/prng/SecureRandomAdapter.java:
	Likewise. Drop unused mdName variable. Remove redundant casts.
	Add Override annotation to interface implementation.
	* gnu/java/security/jce/prng/Sha160RandomSpi.java:
	Add explicit serialVersionUID.
	* gnu/java/security/jce/prng/Sha256RandomSpi.java: Likewise.
	* gnu/java/security/jce/prng/Sha384RandomSpi.java: Likewise.
	* gnu/java/security/jce/prng/Sha512RandomSpi.java: Likewise.
	* gnu/java/security/jce/prng/TigerRandomSpi.java: Likewise.
	* gnu/java/security/jce/prng/WhirlpoolRandomSpi.java: Likewise.
	* gnu/java/security/jce/sig/DSSKeyFactory.java: Add Override
	annotation to interface implementation.
	(engineGetKeySpec(Key,Class)): Update return type. Use
	keySpec.cast to cast newly created instances to the correct type.
	* gnu/java/security/jce/sig/DSSKeyPairGeneratorSpi.java:
	Add missing type parameters and Override annotations.
	* gnu/java/security/jce/sig/DSSParameters.java:
	Add Override annotation to interface implementation.
	(engineGetParameterSpec(Class)): Update return type. Use
	paramSpec.cast to cast new instances to correct type.
	(engineGetEncoded()): Add missing type parameter to list.
	* gnu/java/security/jce/sig/EncodedKeyFactory.java:
	Add type parameters and Override annotations.
	(engineGetKeySpec(Key,Class)): Update return type. Use
	keySpec.cast to cast new instances to correct type.
	* gnu/java/security/jce/sig/RSAKeyFactory.java:
	Add @Override annotation. Drop unused variables.
	(engineGetKeySpec(Key,Class)): Update return type. Use
	keySpec.cast to cast new instances to correct type.
	* gnu/java/security/jce/sig/RSAKeyPairGeneratorSpi.java:
	Add type parameters.
	* gnu/java/security/jce/sig/SignatureAdapter.java:
	Add type parameters and Override annotation.
	* gnu/java/security/key/IKeyPairGenerator.java:
	(setup(Map)): Add type parameters.
	* gnu/java/security/key/KeyPairCodecFactory.java:
	Add type parameters.
	* gnu/java/security/key/KeyPairGeneratorFactory.java: Likewise.
	* gnu/java/security/key/dss/DSSKey.java:
	Add explicit serialVersionUID.
	* gnu/java/security/key/dss/DSSKeyPairGenerator.java:
	Add type parameters and Override annotations.
	* gnu/java/security/key/dss/DSSKeyPairPKCS8Codec.java:
	Likewise.
	* gnu/java/security/key/dss/DSSKeyPairX509Codec.java:
	Add type parameters.
	* gnu/java/security/key/dss/DSSPrivateKey.java:
	Add explicit serialVersionUID.
	* gnu/java/security/key/dss/DSSPublicKey.java: Likewise.
	* gnu/java/security/key/rsa/GnuRSAKey.java: Likewise.
	* gnu/java/security/key/rsa/GnuRSAPrivateKey.java: Likewise.
	* gnu/java/security/key/rsa/GnuRSAPublicKey.java: Likewise.
	* gnu/java/security/key/rsa/RSAKeyPairGenerator.java:
	Add Override annotations and type parameters.
	* gnu/java/security/key/rsa/RSAKeyPairPKCS8Codec.java:
	Add missing type parameters on ArrayList instances.
	* gnu/java/security/key/rsa/RSAKeyPairX509Codec.java:
	Add Override annotations and type parameters.
	* gnu/java/security/pkcs/PKCS7SignedData.java:
	(PKCS7SignedData(BERReader)): Add a type parameter to
	the algId list and ensure all additions are homogenous.
	Add other missing type parameters.
	(PKCS7SignedData(Set,PKCS7Data,Certificate[],X509CRL[],Set)):
	Add missing type parameters.
	(getDigestAlgorithms()): Do a deep copy of the set.
	(getSignerInfos()): Add type parameters.
	(encode(OutputStream)): Likewise.
	* gnu/java/security/pkcs/SignerInfo.java:
	Drop unused variable, count. Add type parameters.
	(encode(OutputStream)): Include derAuthenticatedAttributes
	and derUnauthenticatedAttributes in signerInfo.
	* gnu/java/security/prng/BasePRNG.java:
	Add type parameters and Override annotations.
	* gnu/java/security/prng/IRandom.java: Add type parameters.
	* gnu/java/security/prng/LimitReachedException.java:
	Add explicit serialVersionUID.
	* gnu/java/security/prng/MDGenerator.java:
	Add type parameters and Override annotations.
	* gnu/java/security/prng/PRNGFactory.java:
	Add missing type parameters.
	* gnu/java/security/prng/RandomEvent.java:
	Add explicit serialVersionUID.
	* gnu/java/security/provider/CollectionCertStoreImpl.java:
	Add Override annotation and missing type parameters.
	* gnu/java/security/provider/Gnu.java:
	Add explicit serialVersionUID. Parameterise implementation
	of PrivilegedAction.
	* gnu/java/security/provider/PKIXCertPathValidatorImpl.java:
	Add missing type parameters. Remove unused qualifierInfos
	variable.
	* gnu/java/security/provider/X509CertificateFactory.java:
	Add Override annotations and type parameters.
	* gnu/java/security/sig/BaseSignature.java: Likewise.
	* gnu/java/security/sig/ISignature.java: Add type parameters.
	* gnu/java/security/sig/SignatureCodecFactory.java: Likewise.
	* gnu/java/security/sig/SignatureFactory.java: Likewise.
	* gnu/java/security/sig/dss/DSSSignature.java:
	Add Override annotations and type parameters.
	* gnu/java/security/sig/dss/DSSSignatureX509Codec.java: Add
	type parameter to ArrayList instance.
	* gnu/java/security/sig/rsa/EMSA_PKCS1_V1_5.java:
	Remove unused hLen variable.
	* gnu/java/security/sig/rsa/RSASignatureFactory.java:
	Add type parameters.
	* gnu/java/security/util/PRNG.java:
	(getInstance()): Move initialisation code to shared
	method, initialiseDelegate.
	(nextBytes(byte[],int,int)): Call out to initialiseDelegate
	to re-initialise.
	(initialiseDelegate(IRandom)): New common method for
	shared code.
	* gnu/java/security/util/Sequence.java:
	Add Override annotation and type parameters.
	* gnu/java/security/util/SimpleList.java:
	Add type parameters.
	* gnu/java/security/x509/GnuPKIExtension.java: Likewise.
	* gnu/java/security/x509/PolicyNodeImpl.java:
	Add type parameters and Override annotations.
	(addAllPolicyQualifiers(Collection)): Qualify reference
	to addAll.
	* gnu/java/security/x509/X500DistinguishedName.java:
	Add type parameters.
	* gnu/java/security/x509/X509CRL.java:
	Remove unused variable algParams. Add type parameters
	and Override annotations.
	* gnu/java/security/x509/X509CRLEntry.java:
	Add type parameters and Override annotations.
	* gnu/java/security/x509/X509CRLSelectorImpl.java:
	Likewise.
	* gnu/java/security/x509/X509CertPath.java:
	Add type parameters.
	(pkcsEncoded): Renamed from pkcs_encoded.
	(pkiEncoded): Renamed from pki_encoded.
	* gnu/java/security/x509/X509CertSelectorImpl.java:
	Add type parameters and Override annotations.
	* gnu/java/security/x509/X509Certificate.java: Likewise.
	* gnu/java/security/x509/ext/BasicConstraints.java:
	Add type parameters.
	* gnu/java/security/x509/ext/CertificatePolicies.java:
	Likewise.
	* gnu/java/security/x509/ext/PolicyMappings.java:
	Likewise.
	* gnu/javax/crypto/cipher/IBlockCipher.java:
	Add type parameters.
	* gnu/javax/crypto/jce/prng/FortunaImpl.java:
	(engineSetSeed(byte[])): Add cast for singletonMap
	invocation.
	* gnu/javax/crypto/key/dh/DHKeyPairPKCS8Codec.java:
	Add type parameters.
	* gnu/javax/crypto/key/dh/DHKeyPairX509Codec.java:
	Likewise.
	* gnu/javax/crypto/mac/IMac.java: Likewise.
	* gnu/javax/crypto/mode/BaseMode.java:
	Add Override annotations and type parameters.
	* gnu/javax/crypto/mode/EAX.java:
	Add Override annotations, type parameters and
	casts for singletonMap invocations.
	* gnu/javax/crypto/prng/Fortuna.java: Likewise.
	* gnu/javax/net/ssl/Session.java:
	Add Override annotations and type parameters.
	* gnu/javax/net/ssl/provider/AbstractHandshake.java:
	Fix type parameters.
	* gnu/javax/net/ssl/provider/SSLRandom.java:
	Add Override annotations and type parameters.
	* gnu/javax/net/ssl/provider/TLSRandom.java:
	Likewise.
	(hmacSHA): Renamed from hmac_sha.
	(hmacMD5): Renamed from hmac_md5.
	* gnu/javax/net/ssl/provider/Util.java:
	(transform(Object,Class,String,Object[])): Use
	a type parameter T rather than Object.
	* gnu/javax/net/ssl/provider/X509KeyManagerFactory.java:
	Add type parameters.
	* gnu/javax/net/ssl/provider/X509TrustManagerFactory.java:
	Likewise.
	* gnu/javax/security/auth/callback/AWTCallbackHandler.java:
	Replace calls to deprecated show() with setVisible(true).
	(ACTION_NO): Remove unused variable.
	(ACTION_YES): Likewise.
	* gnu/javax/security/auth/callback/ConsoleCallbackHandler.java:
	Add type parameters.
	* gnu/javax/security/auth/callback/GnuCallbacks.java:
	Add explicit serialVersionUID. Convert PrivilegedAction
	implementation to parameterised version.
	* gnu/javax/security/auth/login/ConfigFileParser.java:
	Add type parameters.
	* gnu/javax/security/auth/login/GnuConfiguration.java:
	Likewise. Fix typo.
	* java/security/AccessControlContext.java:
	Add type parameters.
	* java/security/AllPermission.java:
	Add Override annotations.
	(AllPermissionCollection.elements()): Add type parameter
	to return type and return appropriately typed enumerations.
	* java/security/BasicPermission.java:
	Add type parameters and Override annotations.
	* java/security/CodeSource.java: Likewise.
	* java/security/DummySignature.java:
	Add Override annotations.
	* java/security/Identity.java:
	Add type parameters.
	* java/security/IntersectingDomainCombiner.java:
	Likewise.
	* java/security/KeyPairGenerator.java:
	Add Override annotations.
	* java/security/Permissions.java:
	Add type parameters and Override annotations.
	(elements()): Rename main_enum and sub_enum
	to mainEnum and subEnum respectively.
	* java/security/Policy.java: Add type parameters.
	* java/security/SecureRandom.java: Add missing
	type parameter. Remove unused imports.
	* java/security/Security.java:
	Add type parameters. Fix mis-spelling of 'query'.
	* java/security/SignatureSpi.java: Add
	Override annotation.
	* java/security/UnresolvedPermission.java:
	Add Override annotations and type parameters.
	(elements()): Rename main_enum and sub_enum
	to mainEnum and subEnum respectively.
	* java/security/cert/CertPath.java:
	Add type parameters.
	* java/security/cert/CertPathValidator.java:
	(getDefaultType()): Use GetSecurityPropertyAction
	rather than implementing PrivilegedAction locally.
	* java/security/cert/CertStore.java:
	(getDefaultType()): Use GetSecurityPropertyAction
	rather than implementing PrivilegedAction locally.
	* java/security/cert/CollectionCertStoreParameters.java:
	Add type parameters and Override annotations.
	* java/security/cert/PKIXParameters.java:
	Add type parameters.
	* java/security/cert/X509CRLSelector.java:
	Add type parameters.
	(getIssuerNames()): Return a deep copy.
	* java/security/cert/X509CertSelector.java:
	Add type parameters.
	* java/util/Properties.java:
	Add type parameters.
	(stringPropertyNames()): Implemented.
	* javax/naming/directory/BasicAttribute.java:
	Add Override annotations and missing type parameter.
	* javax/security/auth/AuthPermission.java:
	Add explicit serialVersionUID.
	* javax/security/auth/DestroyFailedException.java:
	Likewise.
	* javax/security/auth/PrivateCredentialPermission.java:
	Add type parameters.
	(equals(Object)): Use thatPrincipals instead of
	that_principals.
	(implies(Permission)): Likewise.
	(CredOwner): Add explicit serialVersionUID.
	* javax/security/auth/RefreshFailedException.java:
	Add explicit serialVersionUID.
	* javax/security/auth/Subject.java:
	Add type parameters and Override annotations.
	* javax/security/auth/SubjectDomainCombiner.java:
	Add type parameters.
	* javax/security/auth/callback/ChoiceCallback.java:
	Add explicit serialVersionUID.
	* javax/security/auth/callback/ConfirmationCallback.java:
	Likewise.
	* javax/security/auth/callback/LanguageCallback.java:
	Likewise.
	* javax/security/auth/callback/NameCallback.java:
	Likewise.
	* javax/security/auth/callback/PasswordCallback.java:
	Likewise.
	* javax/security/auth/callback/TextInputCallback.java:
	Likewise.
	* javax/security/auth/callback/TextOutputCallback.java:
	Likewise.
	* javax/security/auth/callback/UnsupportedCallbackException.java:
	Likewise.
	* javax/security/auth/kerberos/DelegationPermission.java:
	Re-enable explicit serialVersionUID. Add Override annotations
	and type parameters.
	* javax/security/auth/kerberos/KerberosPrincipal.java:
	Re-enable explicit serialVersionUID.
	* javax/security/auth/kerberos/KerberosTicket.java:
	Suppress warning about unused asn1Encoding variable.
	* javax/security/auth/kerberos/KeyImpl.java:
	Re-enable explicit serialVersionUID.
	* javax/security/auth/kerberos/ServicePermission.java:
	Re-enable explicit serialVersionUID. Add Override annotations
	and type parameters.
	* javax/security/auth/login/AppConfigurationEntry.java:
	Add type parameters.
	* javax/security/auth/login/Configuration.java: Likewise.
	* javax/security/auth/login/LoginContext.java: Likewise.
	* javax/security/auth/x500/X500Principal.java: Likewise.
	(fixed): Remove unused variable.
	* javax/security/cert/CertificateEncodingException.java:
	Add explicit serialVersionUID.
	* javax/security/cert/CertificateException.java: Likewise.
	* javax/security/cert/CertificateExpiredException.java:
	Likewise.
	* javax/security/cert/CertificateNotYetValidException.java:
	Likewise.
	* javax/security/cert/CertificateParsingException.java:
	Likewise.
	* javax/security/sasl/AuthenticationException.java:
	Likewise.
	* javax/security/sasl/RealmCallback.java: Likewise.
	* javax/security/sasl/RealmChoiceCallback.java: Likewise.
	* javax/security/sasl/Sasl.java: Add type parameters.
	* tools/gnu/classpath/tools/jarsigner/SFHelper.java:
	Likewise.

Signed-off-by: Andrew John Hughes <gnu_andrew@member.fsf.org>







Add missing IOException constructors.
2014-05-07T10:44:40+00:00

Andrew John Hughes
gnu_andrew@member.fsf.org

2014-05-07T10:44:40+00:00

89e04db227083da5489c41ebfd003b140283d4d8

2014-05-07  Andrew John Hughes  <gnu_andrew@member.fsf.org>

	* java/io/IOException.java:
	(IOException(String,Throwable)): Add missing constructor.
	(IOException(Throwable)): Likewise.

Signed-off-by: Andrew John Hughes <gnu_andrew@member.fsf.org>





2014-05-07  Andrew John Hughes  <gnu_andrew@member.fsf.org>

	* java/io/IOException.java:
	(IOException(String,Throwable)): Add missing constructor.
	(IOException(Throwable)): Likewise.

Signed-off-by: Andrew John Hughes <gnu_andrew@member.fsf.org>







Fix warnings in TreeMap and TreeSet.
2013-05-26T12:55:04+00:00

Andrew John Hughes
gnu_andrew@member.fsf.org

2013-05-26T12:55:04+00:00

e53ef43da7fd8bcbf855f2e95b370964e665dcef

2013-02-17  Andrew John Hughes  <gnu_andrew@member.fsf.org>

	Fix warnings.
	* java/util/TreeMap.java:
	(nil): Add type parameters.
	(root): Likewise.
	(left): Don't set to nil here.
	(right): Likewise.
	(parent): Likewise.
	(Node(K,V,int)): Set left, right and parent
	here using correctly typed nil.
	(TreeMap()): Cast Comparator with type parameters.
	(TreeMap(Map)): Likewise.
	(TreeMap(SortedMap)): Remove unused variable.  Use
	for-each loop and typed nil.
	(clone()): Separate cast and cloning.  Add type
	parameters to node and cnode.
	(containsKey(Object)): Cast key.
	(containsvalue()): Add type parameters to node.
	(get(Object)): Cast key.
	(headMap(K,boolean)): Likewise.
	(put(K,V)): Cast nil before assigning to parent.
	Add type parameters to n.
	(putAll(Map)): Rewrite using for-each loop.
	(remove(Object)): Cast key.
	(tailMap(K,boolean)): Likewise.
	(values()): Add type parameter to iterator.
	(compare(K,K)): Suppress warnings.
	(fabricateTree(int)): Use typed nil.
	Add type parameters to root, row, parent, last,
	left, right and next.
	(firstNode()): Add type parameters to node.
	(highestLessThan(K,boolean)): Use typed nil.
	(insertFixup(Node)): Add type parameters to
	uncle.
	(lastNode()): Add type parameters to node.
	(lowestGreaterThan(K,boolean,boolean)):
	Use typed nil.
	(predecessor(Node)): Add type parameters to
	parent.
	(putFromObjStream(ObjectInputStream,int,V)):
	Pass value with type rather than using String.
	Add type parameter to node.
	(putKeysLinear(Iterator,int,V)): Pass in value
	rather than using empty string.
	(readObject(ObjectInputStream)): Call putFromObjStream
	with null rather than true.
	(removeNode(Node)): Add type parameters to parent.
	(rotateLeft(Node)): Add type parameters to child.
	(rotateRight(Node)): Likewise.
	(writeObject(ObjectOutputStream)): Add type parameters
	to node.
	(TreeIterator): Add type parameter.
	(TreeIterator.last): Likewise.
	(TreeIterator.next): Likewise.
	(TreeIterator.max): Likewise.
	(TreeIterator.TreeIterator(int)): Cast nil.
	(TreeIterator.TreeIterator(int,Node,Node)): Add type
	parameters.
	(TreeIterator.next()): Suppress warnings and cast to
	correct type.
	(descendingMap()): Add type parameters.
	(clear()): Add type parameters to next, max and current.
	(SubMap.containsKey(Object)): Fix casting of key.
	(SubMap.containsValue(Object)): Add type parameters to
	node and max.
	(SubMap.get(Object)): Fix casting of key.
	(SubMap.remove(Object)): Likewise.
	(SubMap.size()): Add type parameters to node and max.
	(SubMap.values()): Add type parameter to AbstractCollection,
	first, max and TreeIterator.
	(SubMap.KeySet.iterator()): Add type parameters to first and
	max.
	(SubMap.KeySet.contains(Object)): Fix casting of key.
	(SubMap.KeySet.remove(Object)): Likewise.
	(SubMap.NavigableKeySet.descendingSet()): Add type parameter
	to DescendingSet.
	(SubMap.EntrySet.iterator()): Add type parameters to first
	and max.
	(SubMap.EntrySet.contains(Object)): Fix casting of entry.
	(SubMap.EntrySet.remove(Object)): Likewise.
	(SubMap.NavigableEntrySet.descendingSet()): Add type
	parameter to DescendingSet.
	(SubMap.NavigableEntrySet.tailSet(Entry,boolean)): Return
	entry set, not key set.
	(DescendingMap.headMap(DK,boolean)): Add type parameters.
	(DescendingMap.subMap(DK,boolean,DK,boolean)): Likewise.
	(DescendingMap.tailMap(Dk,boolean)): Likewise.
	(DescendingMap.values()): Add type parameter to
	AbstractCollection.
	(KeySet.iterator()): Add type parameter to TreeIterator.
	(KeySet.remove(Object)): Fix casting of key.
	(NavigableKeySet.headSet(D,boolean)): Add type parameter.
	(NavigableKeySet.subSet(D,boolean,D,boolean)): Likewise.
	(NavigableKeySet.tailSet(D,boolean)): Likewise.
	(NavigableKeySet.toArray()): Suppress warnings on cast.
	(NavigableKeySet.toArray(T[])): Likewise.
	(EntrySet.iterator()): Add type parameter to TreeIterator.
	(EntrySet.contains(Object)): Fix casting of entry.
	(EntrySet.remove(Object)): Likewise.
	(NavigableEntrySet.descendingSet()): Add type
	parameter to DescendingSet.
	(NavigableEntrySet.tailSet(Entry,boolean)): Return
	entry set, not key set.
	* java/util/TreeSet.java:
	(TreeSet(SortedSet)): Explicitly pass empty String to
	putKeysLinear as it no longer defaults to this.
	(readObject(ObjectInputStream)): Pass empty String rather
	than false, which will in turn make "" == null return false
	in putFromObjStream.

Signed-off-by: Andrew John Hughes <gnu_andrew@member.fsf.org>





2013-02-17  Andrew John Hughes  <gnu_andrew@member.fsf.org>

	Fix warnings.
	* java/util/TreeMap.java:
	(nil): Add type parameters.
	(root): Likewise.
	(left): Don't set to nil here.
	(right): Likewise.
	(parent): Likewise.
	(Node(K,V,int)): Set left, right and parent
	here using correctly typed nil.
	(TreeMap()): Cast Comparator with type parameters.
	(TreeMap(Map)): Likewise.
	(TreeMap(SortedMap)): Remove unused variable.  Use
	for-each loop and typed nil.
	(clone()): Separate cast and cloning.  Add type
	parameters to node and cnode.
	(containsKey(Object)): Cast key.
	(containsvalue()): Add type parameters to node.
	(get(Object)): Cast key.
	(headMap(K,boolean)): Likewise.
	(put(K,V)): Cast nil before assigning to parent.
	Add type parameters to n.
	(putAll(Map)): Rewrite using for-each loop.
	(remove(Object)): Cast key.
	(tailMap(K,boolean)): Likewise.
	(values()): Add type parameter to iterator.
	(compare(K,K)): Suppress warnings.
	(fabricateTree(int)): Use typed nil.
	Add type parameters to root, row, parent, last,
	left, right and next.
	(firstNode()): Add type parameters to node.
	(highestLessThan(K,boolean)): Use typed nil.
	(insertFixup(Node)): Add type parameters to
	uncle.
	(lastNode()): Add type parameters to node.
	(lowestGreaterThan(K,boolean,boolean)):
	Use typed nil.
	(predecessor(Node)): Add type parameters to
	parent.
	(putFromObjStream(ObjectInputStream,int,V)):
	Pass value with type rather than using String.
	Add type parameter to node.
	(putKeysLinear(Iterator,int,V)): Pass in value
	rather than using empty string.
	(readObject(ObjectInputStream)): Call putFromObjStream
	with null rather than true.
	(removeNode(Node)): Add type parameters to parent.
	(rotateLeft(Node)): Add type parameters to child.
	(rotateRight(Node)): Likewise.
	(writeObject(ObjectOutputStream)): Add type parameters
	to node.
	(TreeIterator): Add type parameter.
	(TreeIterator.last): Likewise.
	(TreeIterator.next): Likewise.
	(TreeIterator.max): Likewise.
	(TreeIterator.TreeIterator(int)): Cast nil.
	(TreeIterator.TreeIterator(int,Node,Node)): Add type
	parameters.
	(TreeIterator.next()): Suppress warnings and cast to
	correct type.
	(descendingMap()): Add type parameters.
	(clear()): Add type parameters to next, max and current.
	(SubMap.containsKey(Object)): Fix casting of key.
	(SubMap.containsValue(Object)): Add type parameters to
	node and max.
	(SubMap.get(Object)): Fix casting of key.
	(SubMap.remove(Object)): Likewise.
	(SubMap.size()): Add type parameters to node and max.
	(SubMap.values()): Add type parameter to AbstractCollection,
	first, max and TreeIterator.
	(SubMap.KeySet.iterator()): Add type parameters to first and
	max.
	(SubMap.KeySet.contains(Object)): Fix casting of key.
	(SubMap.KeySet.remove(Object)): Likewise.
	(SubMap.NavigableKeySet.descendingSet()): Add type parameter
	to DescendingSet.
	(SubMap.EntrySet.iterator()): Add type parameters to first
	and max.
	(SubMap.EntrySet.contains(Object)): Fix casting of entry.
	(SubMap.EntrySet.remove(Object)): Likewise.
	(SubMap.NavigableEntrySet.descendingSet()): Add type
	parameter to DescendingSet.
	(SubMap.NavigableEntrySet.tailSet(Entry,boolean)): Return
	entry set, not key set.
	(DescendingMap.headMap(DK,boolean)): Add type parameters.
	(DescendingMap.subMap(DK,boolean,DK,boolean)): Likewise.
	(DescendingMap.tailMap(Dk,boolean)): Likewise.
	(DescendingMap.values()): Add type parameter to
	AbstractCollection.
	(KeySet.iterator()): Add type parameter to TreeIterator.
	(KeySet.remove(Object)): Fix casting of key.
	(NavigableKeySet.headSet(D,boolean)): Add type parameter.
	(NavigableKeySet.subSet(D,boolean,D,boolean)): Likewise.
	(NavigableKeySet.tailSet(D,boolean)): Likewise.
	(NavigableKeySet.toArray()): Suppress warnings on cast.
	(NavigableKeySet.toArray(T[])): Likewise.
	(EntrySet.iterator()): Add type parameter to TreeIterator.
	(EntrySet.contains(Object)): Fix casting of entry.
	(EntrySet.remove(Object)): Likewise.
	(NavigableEntrySet.descendingSet()): Add type
	parameter to DescendingSet.
	(NavigableEntrySet.tailSet(Entry,boolean)): Return
	entry set, not key set.
	* java/util/TreeSet.java:
	(TreeSet(SortedSet)): Explicitly pass empty String to
	putKeysLinear as it no longer defaults to this.
	(readObject(ObjectInputStream)): Pass empty String rather
	than false, which will in turn make "" == null return false
	in putFromObjStream.

Signed-off-by: Andrew John Hughes <gnu_andrew@member.fsf.org>