delta/coreboot/coreboot.git/src/include, branch master

console: Add format-checking __printf() to die()

2023-05-17T11:23:59+00:00

Code changes are necessary because `-Wformat` warns about empty
format strings by default.

Change-Id: Ic8021b70f4cd4875b06f196f88b84940c9a79fe0
Signed-off-by: Nico Huber 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75147
Reviewed-by: Jérémy Compostella 
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
Reviewed-by: Arthur Heymans

acpigen: Add printf-like function for debug string

2023-05-16T12:22:32+00:00

Generate formatted string and ACPI code to print debug string.

For example (with pcie_rp = 1):

    acpigen_write_debug_sprintf("calling _ON for RP: %u", pcie_rp);

generates the following ACPI code:

    Debug = "calling _ON for RP: 1"

With this new function, the following functions are not needed anymore
and therefore are removed by this patch.

- acpigen_concatenate_string_string()
- acpigen_concatenate_string_int()
- acpigen_write_debug_concatenate_string_string()
- acpigen_write_debug_concatenate_string_int()

BRANCH=firmware-brya-14505.B
TEST=Add above functions in the acpigen code and check the generated
     SSDT table after OS boot. Check the debug messages is in the
     kernel log when /sys/modules/acpi/parameters/aml_debug_output is
     set to '1'.

Change-Id: Id4a42e5854516a22b7bc4559c2ed08680722c5ba
Signed-off-by: Cliff Huang 
Signed-off-by: Jeremy Compostella 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73113
Tested-by: build bot (Jenkins) 
Reviewed-by: Bora Guvendik 
Reviewed-by: Nico Huber 
Reviewed-by: Zhixing Ma 
Reviewed-by: Musse Abdullahi 
Reviewed-by: Angel Pons 
Reviewed-by: Lean Sheng Tan

acpi/acpigen: add acpigen_resource_io to generate I/O resource

2023-05-11T19:30:10+00:00

Add the acpigen_resource_io helper function to generate an I/O range
resource.

Signed-off-by: Felix Held 
Signed-off-by: Arthur Heymans 
Change-Id: I177f59b52d4dbbff0a3ceeef5fc8c7455cef9ff8
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75044
Tested-by: build bot (Jenkins) 
Reviewed-by: Tim Wawrzynczak

acpi/acpigen: add acpigen_resource_bus_number to generate bus number

2023-05-11T19:28:59+00:00

Add the acpigen_resource_bus_number helper function to generate a bus
number range resource.

Signed-off-by: Felix Held 
Signed-off-by: Arthur Heymans 
Change-Id: Ib1f1da3dbe823c6bc4fc30c0622653410cfbf301
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75043
Tested-by: build bot (Jenkins) 
Reviewed-by: Tim Wawrzynczak

drivers/pc80/rtc/mc146818rtc.c: Add Kconfig for RTC CMOS base addresses

2023-05-08T17:51:08+00:00

Configure the CMOS bank I/O base addresses with
PC_CMOS_BASE_PORT_BANK* rather than hard-coding as 0x70, 0x72.  The
defaults remain the same.

Change-Id: Ie44e5f5191c66f44e2df8ea0ff58a860be88bfcf
Signed-off-by: Jonathon Hall 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74903
Reviewed-by: Kyösti Mälkki 
Tested-by: build bot (Jenkins)

acpi/acpigen: add acpigen_write_BBN to generate base bus number method

2023-05-08T16:00:54+00:00

Introduce acpigen_write_BBN to generate the ACPI method object that
returns the base bus number for a PCI(e) host bridge. When called, the
base_bus_number argument must be the first PCI bus number that got
assigned to the corresponding host bridge.

Signed-off-by: Felix Held 
Change-Id: Ib67bf42b9c77c262d8a02d8f28ac5cb8482136b9
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74991
Tested-by: build bot (Jenkins) 
Reviewed-by: Tim Wawrzynczak

acpigen: Add a runtime method to override exposed _Sx sleep states

2023-05-01T06:38:36+00:00

This allows mainboards to override available sleep states at runtime.
This is done by adding a IntObj in SSDT that DSDT consumes to override
the available _Sx states.

Signed-off-by: Arthur Heymans 
Change-Id: Ic21830c1ef9c183b1e3005cc1f8b7daf7e9ea998
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74762
Reviewed-by: Nico Huber 
Reviewed-by: Jakub Czapiga 
Reviewed-by: Jan Samek 
Tested-by: build bot (Jenkins) 
Reviewed-by: Lean Sheng Tan

ACPI: Make FADT entries for RTC/CMOS architectural

2023-04-29T01:20:54+00:00

For AMD, replace name RTC_ALT_CENTURY with RTC_CLK_ALTCENTURY
that points to same offset. Since the century field inside
RTC falls within the NVRAM space, and could interfere with
OPTION_TABLE, it is now guarded with config USE_PC_CMOS_ALTCENTURY.

There were no reference for the use of offset 0x48 for century.

Change-Id: I965a83dc8daaa02ad0935bdde5ca50110adb014a
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74601
Reviewed-by: Elyes Haouas 
Tested-by: build bot (Jenkins) 
Reviewed-by: Felix Held

vga: Change the arguments of vga_write_text to support extended ASCII

2023-04-28T09:39:06+00:00

VGA defined the extended ASCII set based on CP437, but the function
vga_write_text() accepts a signed char array.

This will cause unnecessary confusion that if we want to print u with
umlaut (code=129 in CP437), we need to explicitly cast it to -127 in
signed char.

Since we still want to leverage the built-in string utilities
which only accepts const char*, we still need to cast it to signed char
while processing, and cast it back to unsigned once we write into the
frame buffer.

BRANCH=brya
BUG=b:264666392
TEST=emerge-brya coreboot chromeos-bootimage

Signed-off-by: Hsuan Ting Chen 
Change-Id: If555bbc05f40ce3f02339c0468afff6dda8b7ded
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73099
Tested-by: build bot (Jenkins) 
Reviewed-by: Tarun Tuli

arch/x86/ioapic: Promote ioapic_get_sci_pin()

2023-04-26T10:53:16+00:00

Platform needs to implement this to provide information about SCI IRQ
pin and polarity, to be used for filling in ACPI FADT and MADT entries.

Change-Id: Icea7e9ca4abf3997c01617d2f78f25036d85a52f
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74337
Tested-by: build bot (Jenkins) 
Reviewed-by: Arthur Heymans