delta/cpython-git.git/Lib/test/test_email/test_utils.py, branch enum-private-310

bpo-30681: Support invalid date format or value in email Date header (GH-22090)

2020-10-27T00:31:06+00:00

I am re-submitting an older PR which was abandoned but is still relevant, #10783 by @timb07.

The issue being solved () is still relevant. The original PR #10783 was closed as
the final request changes were not applied and since abandoned.

In this new PR I have re-used the original patch plus applied both comments from the review, by @maxking and @pganssle.


For reference, here is the original PR description:
In email.utils.parsedate_to_datetime(), a failure to parse the date, or invalid date components (such as hour outside 0..23) raises an exception. Document this behaviour, and add tests to test_email/test_utils.py to confirm this behaviour.

In email.headerregistry.DateHeader.parse(), check when parsedate_to_datetime() raises an exception and add a new defect InvalidDateDefect; preserve the invalid value as the string value of the header, but set the datetime attribute to None.

Add tests to test_email/test_headerregistry.py to confirm this behaviour; also added test to test_email/test_inversion.py to confirm emails with such defective date headers round trip successfully.

This pull request incorporates feedback gratefully received from @bitdancer, @brettcannon, @Mariatta and @warsaw, and replaces the earlier PR #2254.

Automerge-Triggered-By: GH:warsaw

bpo-35317: Fix mktime() error in test_email (GH-10721)

2018-11-27T11:40:50+00:00

Fix mktime() overflow error in test_email: run
test_localtime_daylight_true_dst_true() and
test_localtime_daylight_false_dst_true() with a specific timezone.

Issue #24836: Skip FormatDateTests of test_email.test_utils on Mac OS X Snow

2015-09-18T14:32:23+00:00

Leopard because this OS uses out of date (pre 2011k) timezone files.

Issue #22932: Fix timezones in email.utils.formatdate.

2015-07-31T20:18:22+00:00

Patch from Dmitry Shachnev.

Issue #19590: Use specific asserts in email tests.

2013-11-16T10:56:23+00:00

#17877: skip test if the Olson's TZ database is missing.

2013-05-08T08:16:02+00:00

Close #15165: Fix test_email on Windows 64 bits

2012-11-05T01:06:13+00:00

Use year 1990 instead of year 1970 to avoid issues with negative timestamps.

Added test for a bug fixed in issue #665194.

2012-08-23T02:06:37+00:00

#665194: Update email.utils.localtime to use astimezone, and fix bug.

2012-08-23T01:34:00+00:00

The new code correctly handles historic changes in UTC offsets.
A test for this should follow.

Original patch by Alexander Belopolsky.

#665194: Add a localtime function to email.utils.

2012-05-26T03:22:59+00:00

Without this function people would be tempted to use the other date functions
in email.utils to compute an aware localtime, and those functions are not as
good for that purpose as this code.  The code is Alexander Belopolsy's from
his proposed patch for issue 9527, with a fix (and additional tests) by Brian
K. Jones.