delta/cpython-git.git/Modules, branch v2.4.4 github.com: python/cpython.git Backport 50567 2006-10-10T16:20:41+00:00 Anthony Baxter anthonybaxter@gmail.com 2006-10-10T16:20:41+00:00 3d62ffe0fa549508ea939a74e97b0248a84561f6 #1494314: Fix a regression with high-numbered sockets in 2.4.3. This means that select() on sockets > FD_SETSIZE (typically 1024) work again. The patch makes sockets use poll() internally where available. 
#1494314: Fix a regression with high-numbered sockets in 2.4.3. This
means that select() on sockets > FD_SETSIZE (typically 1024) work again.
The patch makes sockets use poll() internally where available.
Backport r45505, r45573, r45576 2006-10-09T19:29:06+00:00 Martin v. Löwis martin@v.loewis.de 2006-10-09T19:29:06+00:00 b8f82e6febddbd534e0f08ab480367561daa0717 - reset errno before calling confstr - use confstr() doc to simplify checks afterwards - Correct implementation and documentation of os.confstr. Add a simple test case. I've yet to figure out how to provoke a None return I can test. - Address issues brought up by MvL on python-checkins. I tested this with valgrind on amd64. The man pages I found for diff architectures are inconsistent on this. I'm not entirely sure this change is correct for all architectures either. Perhaps we should just over-allocate and not worry about it? The change to return None instead of "" in case of unconfigured values has not been backported. 
- reset errno before calling confstr - use confstr() doc to simplify
  checks afterwards
- Correct implementation and documentation of os.confstr.  Add a simple
  test case.  I've yet to figure out how to provoke a None return I can test.
- Address issues brought up by MvL on python-checkins.
  I tested this with valgrind on amd64.

  The man pages I found for diff architectures are inconsistent on this.
  I'm not entirely sure this change is correct for all architectures
  either.

  Perhaps we should just over-allocate and not worry about it?

The change to return None instead of "" in case of unconfigured
values has not been backported.
[Partial backport of r45947 | neal.norwitz] 2006-10-09T18:30:13+00:00 Andrew M. Kuchling amk@amk.ca 2006-10-09T18:30:13+00:00 cebdc5e373e9df417b24e4f5442637f27d53f4ba Fix problems found by Coverity. _ssl.c: under fail: self is DECREF'd, but it would have been NULL. _csv.c: I'm not sure if lineterminator could have been anything other than a string. However, other string method calls are checked, so check this one too. 
Fix problems found by Coverity.

_ssl.c: under fail: self is DECREF'd, but it would have been NULL.

_csv.c: I'm not sure if lineterminator could have been anything other than
a string.  However, other string method calls are checked, so check this
one too.
Port of universal binary support for Mac OSX from python 2.5. This takes away 2006-10-08T17:41:25+00:00 Ronald Oussoren ronaldoussoren@mac.com 2006-10-08T17:41:25+00:00 392cafba4fb899f8a205f7962302b77db8c61980 the need for the out-of-tree universal binary support that was used to build the 2.4.3 installer. Missing here relative to that tree are some changes to IDLE, IMHO those patches aren't appropriate for the 2.4 branch and users are better of using 2.5's IDLE. 
the need for the out-of-tree universal binary support that was used to build
the 2.4.3 installer.

Missing here relative to that tree are some changes to IDLE, IMHO those patches
aren't appropriate for the 2.4 branch and users are better of using 2.5's IDLE.
Backport from trunk r52223: 2006-10-08T13:56:00+00:00 Hye-Shik Chang hyeshik@gmail.com 2006-10-08T13:56:00+00:00 2d09be9e488828876228bc435d16ee4b90a2ca08 Bug #1572832: fix a bug in ISO-2022 codecs which may cause segfault when encoding non-BMP unicode characters. (Submitted by Ray Chason) 
Bug #1572832: fix a bug in ISO-2022 codecs which may cause segfault
when encoding non-BMP unicode characters.  (Submitted by Ray Chason)
[Backport r50783 | neal.norwitz. The bytes_left code is complicated, 2006-10-05T18:49:36+00:00 Andrew M. Kuchling amk@amk.ca 2006-10-05T18:49:36+00:00 da604c19923ef1fd365a0ace5bb8c6e0bbe763ce but looks correct on a casual inspection and hasn't been modified in the trunk. Does anyone want to review further?] Ensure we don't write beyond errText. I think I got this right, but it definitely could use some review to ensure I'm not off by one and there's no possible overflow/wrap-around of bytes_left. Reported by Klocwork #1. Fix a problem if there is a failure allocating self->db. Found with failmalloc. 
 but looks correct on a casual inspection and hasn't been modified
 in the trunk.  Does anyone want to review further?]

Ensure we don't write beyond errText.  I think I got this right, but
it definitely could use some review to ensure I'm not off by one
and there's no possible overflow/wrap-around of bytes_left.
Reported by Klocwork #1.

Fix a problem if there is a failure allocating self->db.
Found with failmalloc.
[Partial backport of r51218 | neal.norwitz -- the changes to ast.c, symtable.c, 2006-10-05T18:37:08+00:00 Andrew M. Kuchling amk@amk.ca 2006-10-05T18:37:08+00:00 978809518d823c6f67ed7be2563de52275ea8623 and _elementtree.c weren't applicable] Klocwork made another run and found a bunch more problems. This is the first batch of fixes that should be easy to verify based on context. This fixes problem numbers: 220 (ast), 323-324 (symtable), 321-322 (structseq), 215 (array), 210 (hotshot), 182 (codecs), 209 (etree). 
 and _elementtree.c weren't applicable]

Klocwork made another run and found a bunch more problems.
This is the first batch of fixes that should be easy to verify based on context.
This fixes problem numbers: 220 (ast), 323-324 (symtable),
321-322 (structseq), 215 (array), 210 (hotshot), 182 (codecs), 209 (etree).
[Partial backport of r50773 | neal.norwitz -- other parts of this patch 2006-10-05T18:22:02+00:00 Andrew M. Kuchling amk@amk.ca 2006-10-05T18:22:02+00:00 9781e5d97e4648453b6b4d011b7252c1cb05656c applied to pyarena.c, compile.c, and symtable.c, which were different in 2.4.] Fix more memory allocation issues found with failmalloc. 
 applied to pyarena.c, compile.c, and symtable.c, which were different in 2.4.]

Fix more memory allocation issues found with failmalloc.
[Backport r52147 | andrew.kuchling] 2006-10-05T17:30:48+00:00 Andrew M. Kuchling amk@amk.ca 2006-10-05T17:30:48+00:00 af4defb79ddec0c5db161f9b084097b843918737 Cause a PyObject_Malloc() failure to trigger a MemoryError, and then add 'if (PyErr_Occurred())' checks to various places so that NULL is returned properly. 
Cause a PyObject_Malloc() failure to trigger a MemoryError, and then
add 'if (PyErr_Occurred())' checks to various places so that NULL is
returned properly.
[Backport r51223 | neal.norwitz] 2006-10-05T17:24:08+00:00 Andrew M. Kuchling amk@amk.ca 2006-10-05T17:24:08+00:00 a1ade3e925836a89e1ebacb74eb8e81d85190cd8 If _stat_float_times is false, we will try to INCREF ival which could be NULL. Return early in that case. The caller checks for PyErr_Occurred so this should be ok. Klocwork #297 
If _stat_float_times is false, we will try to INCREF ival which could be NULL.
Return early in that case.  The caller checks for PyErr_Occurred so this
should be ok.

Klocwork #297