summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2021-10-07 05:11:38 -0700
committerGitHub <noreply@github.com>2021-10-07 05:11:38 -0700
commitd55bf81c4ee2dcdd5dfa3b5a9905a0b32ca8d38b (patch)
treeebd3fbbfa0145571492bfc4d6956fadd0ac45531
parentee92205bb2b0c3693c5ed32d281d2d3bb40f6e4d (diff)
downloadcpython-git-d55bf81c4ee2dcdd5dfa3b5a9905a0b32ca8d38b.tar.gz
bpo-45400: Fix suggestion test of test_exceptions (GH-28783)
Fix test_name_error_suggestions_do_not_trigger_for_too_many_locals() of test_exceptions if a directory name contains "a1" (like "Python-3.11.0a1"): use a stricter regular expression. (cherry picked from commit 4e605666b08b8f863cbbbdaa34bb06988e648d26) Co-authored-by: Victor Stinner <vstinner@python.org>
-rw-r--r--Lib/test/test_exceptions.py2
-rw-r--r--Misc/NEWS.d/next/Tests/2021-10-07-13-11-45.bpo-45400.h3iT7V.rst3
2 files changed, 4 insertions, 1 deletions
diff --git a/Lib/test/test_exceptions.py b/Lib/test/test_exceptions.py
index 82aa79e996..143b856280 100644
--- a/Lib/test/test_exceptions.py
+++ b/Lib/test/test_exceptions.py
@@ -1840,7 +1840,7 @@ class NameErrorTests(unittest.TestCase):
with support.captured_stderr() as err:
sys.__excepthook__(*sys.exc_info())
- self.assertNotIn("a1", err.getvalue())
+ self.assertNotRegex(err.getvalue(), r"NameError.*a1")
def test_name_error_with_custom_exceptions(self):
def f():
diff --git a/Misc/NEWS.d/next/Tests/2021-10-07-13-11-45.bpo-45400.h3iT7V.rst b/Misc/NEWS.d/next/Tests/2021-10-07-13-11-45.bpo-45400.h3iT7V.rst
new file mode 100644
index 0000000000..61b6653320
--- /dev/null
+++ b/Misc/NEWS.d/next/Tests/2021-10-07-13-11-45.bpo-45400.h3iT7V.rst
@@ -0,0 +1,3 @@
+Fix test_name_error_suggestions_do_not_trigger_for_too_many_locals() of
+test_exceptions if a directory name contains "a1" (like "Python-3.11.0a1"):
+use a stricter regular expression. Patch by Victor Stinner.