diff options
| author | Victor Stinner <vstinner@python.org> | 2021-04-28 15:47:10 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-04-28 15:47:10 +0200 |
| commit | fe52eb62191e640e720d184a9a1a04e965b8a062 (patch) | |
| tree | bbfe56fcdd433643e4b3e4dcda419abdf36e9682 | |
| parent | 32c5a174445ec93747240cd8472012276ed27acf (diff) | |
| download | cpython-git-fe52eb62191e640e720d184a9a1a04e965b8a062.tar.gz | |
bpo-43961: Fix test_logging.test_namer_rotator_inheritance() (GH-25684)
Fix test_logging.test_namer_rotator_inheritance() on Windows: use
os.replace() rather than os.rename().
| -rw-r--r-- | Lib/test/test_logging.py | 2 | ||||
| -rw-r--r-- | Misc/NEWS.d/next/Tests/2021-04-28-13-21-52.bpo-43961.gNchls.rst | 2 |
2 files changed, 3 insertions, 1 deletions
diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py index bb31e29ca7..1d061e4993 100644 --- a/Lib/test/test_logging.py +++ b/Lib/test/test_logging.py @@ -5219,7 +5219,7 @@ class RotatingFileHandlerTest(BaseFileTest): def rotator(self, source, dest): if os.path.exists(source): - os.rename(source, dest + ".rotated") + os.replace(source, dest + ".rotated") rh = HandlerWithNamerAndRotator( self.fn, encoding="utf-8", backupCount=2, maxBytes=1) diff --git a/Misc/NEWS.d/next/Tests/2021-04-28-13-21-52.bpo-43961.gNchls.rst b/Misc/NEWS.d/next/Tests/2021-04-28-13-21-52.bpo-43961.gNchls.rst new file mode 100644 index 0000000000..e56572f517 --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2021-04-28-13-21-52.bpo-43961.gNchls.rst @@ -0,0 +1,2 @@ +Fix test_logging.test_namer_rotator_inheritance() on Windows: use +:func:`os.replace` rather than :func:`os.rename`. Patch by Victor Stinner. |