summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSenthil Kumaran <senthil@uthcode.com>2012-07-08 17:47:25 -0700
committerSenthil Kumaran <senthil@uthcode.com>2012-07-08 17:47:25 -0700
commit168456df1158beee5a5051c108a9052a9aebba27 (patch)
treeefc2662674f659d05f5ff7746ead0673983a5bcf
parent83efd6cbb697fec5412ea7a987222baf18349a91 (diff)
downloadcpython-git-168456df1158beee5a5051c108a9052a9aebba27.tar.gz
revert the changes done for issue14826 - quoting witin Request is not desirable.
-rw-r--r--Lib/test/test_urllib.py5
-rw-r--r--Lib/urllib/request.py1
-rw-r--r--Misc/NEWS5
3 files changed, 0 insertions, 11 deletions
diff --git a/Lib/test/test_urllib.py b/Lib/test/test_urllib.py
index 69d543855e..c6f6f6121f 100644
--- a/Lib/test/test_urllib.py
+++ b/Lib/test/test_urllib.py
@@ -1246,11 +1246,6 @@ class URLopener_Tests(unittest.TestCase):
# ftp.close()
- def test_quote_url(self):
- Request = urllib.request.Request
- request = Request("http://www.python.org/foo bar")
- self.assertEqual(request.full_url, "http://www.python.org/foo%20bar")
-
def test_main():
support.run_unittest(
diff --git a/Lib/urllib/request.py b/Lib/urllib/request.py
index c77697c576..d6f9f9a1bc 100644
--- a/Lib/urllib/request.py
+++ b/Lib/urllib/request.py
@@ -181,7 +181,6 @@ class Request:
origin_req_host=None, unverifiable=False):
# unwrap('<URL:type://host/path>') --> 'type://host/path'
self.full_url = unwrap(url)
- self.full_url = quote(self.full_url, safe="%/:=&?~#+!$,;'@()*[]|")
self.full_url, self.fragment = splittag(self.full_url)
self.data = data
self.headers = {}
diff --git a/Misc/NEWS b/Misc/NEWS
index 2e2b03fb65..fe83897553 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -87,11 +87,6 @@ Core and Builtins
Library
-------
-- Issue #14826: Quote urls in urllib.request.Request similar to how they are
- quoted by urllib.request.URLopener. Allows urls to spaces in them to work
- transparently with urllib.request.urlopen(...). Patch contributed by Stephen
- Thorne.
-
- Issue #14990: Correctly fail with SyntaxError on invalid encoding
declaration.