summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Heimes <christian@python.org>2014-02-05 00:29:48 +0100
committerChristian Heimes <christian@python.org>2014-02-05 00:29:48 +0100
commit25ff287dd7a8ed43b99433796f2d1dcf78efa878 (patch)
treef313edc91ec322c4ea9fd1e12c3afa9ba0d024fc
parent3b55f0c6226a1a1b56c661246dbbcce1bc2e3d76 (diff)
parentd33491ea76b3898d5fd0fe3ae75e73ea157a7186 (diff)
downloadcpython-git-25ff287dd7a8ed43b99433796f2d1dcf78efa878.tar.gz
Issue #20515: Fix NULL pointer dereference introduced by issue #20368
CID 1167595
-rw-r--r--Misc/NEWS2
-rw-r--r--Modules/_tkinter.c3
2 files changed, 5 insertions, 0 deletions
diff --git a/Misc/NEWS b/Misc/NEWS
index 0bf92fd629..594b9472cc 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -24,6 +24,8 @@ Core and Builtins
Library
-------
+- Issue #20515: Fix NULL pointer dereference introduced by issue #20368.
+
- Issue #19186: Restore namespacing of expat symbols inside the pyexpat module.
- Issue #20053: ensurepip (and hence venv) are no longer affected by the
diff --git a/Modules/_tkinter.c b/Modules/_tkinter.c
index d48fb179f3..af430fba98 100644
--- a/Modules/_tkinter.c
+++ b/Modules/_tkinter.c
@@ -1397,6 +1397,9 @@ varname_converter(PyObject *in, void *_out)
if (PyUnicode_Check(in)) {
Py_ssize_t size;
s = PyUnicode_AsUTF8AndSize(in, &size);
+ if (s == NULL) {
+ return 0;
+ }
if (size > INT_MAX) {
PyErr_SetString(PyExc_OverflowError, "string is too long");
return 0;