diff options
| author | gescheit <gescheit12@gmail.com> | 2019-04-30 10:54:30 +0300 |
|---|---|---|
| committer | Inada Naoki <songofacandy@gmail.com> | 2019-04-30 16:54:30 +0900 |
| commit | 3bbcc92577f8e616bc94c679040043bacd00ebf1 (patch) | |
| tree | c010916e6f1cb8ca7872b0b325193dcaf7eaef42 | |
| parent | b0a2c0fa83f9b79616ccf451687096542de1e6f8 (diff) | |
| download | cpython-git-3bbcc92577f8e616bc94c679040043bacd00ebf1.tar.gz | |
bpo-25430: improve performance of IPNetwork.__contains__ (GH-1785)
make a compare in bit-operation manner.
| -rw-r--r-- | Lib/ipaddress.py | 3 | ||||
| -rw-r--r-- | Misc/NEWS.d/next/Library/2019-04-15-12-22-09.bpo-25430.7_8kqc.rst | 1 |
2 files changed, 2 insertions, 2 deletions
diff --git a/Lib/ipaddress.py b/Lib/ipaddress.py index 909a55de4f..662d737389 100644 --- a/Lib/ipaddress.py +++ b/Lib/ipaddress.py @@ -697,8 +697,7 @@ class _BaseNetwork(_IPAddressBase): # dealing with another address else: # address - return (int(self.network_address) <= int(other._ip) <= - int(self.broadcast_address)) + return other._ip & self.netmask._ip == self.network_address._ip def overlaps(self, other): """Tell if self is partly contained in other.""" diff --git a/Misc/NEWS.d/next/Library/2019-04-15-12-22-09.bpo-25430.7_8kqc.rst b/Misc/NEWS.d/next/Library/2019-04-15-12-22-09.bpo-25430.7_8kqc.rst new file mode 100644 index 0000000000..922bdef56e --- /dev/null +++ b/Misc/NEWS.d/next/Library/2019-04-15-12-22-09.bpo-25430.7_8kqc.rst @@ -0,0 +1 @@ +improve performance of ``IPNetwork.__contains__()``
\ No newline at end of file |