diff options
| author | Victor Stinner <victor.stinner@haypocalc.com> | 2011-05-19 15:52:59 +0200 |
|---|---|---|
| committer | Victor Stinner <victor.stinner@haypocalc.com> | 2011-05-19 15:52:59 +0200 |
| commit | 4c9706bd275134d513c61e07764215a7d0c2302c (patch) | |
| tree | e6fa27d81211d15e3028e9ce7cde899c58a6f3c4 | |
| parent | 21a9c748aa8698c8201e30a58320d587f6bb7540 (diff) | |
| download | cpython-git-4c9706bd275134d513c61e07764215a7d0c2302c.tar.gz | |
package: replace open(fn, 'w').close() by open(fn, 'wb').close()
We don't need to open the files in text mode just to create them (or update
their modification time).
| -rw-r--r-- | Lib/packaging/command/install_distinfo.py | 2 | ||||
| -rw-r--r-- | Lib/packaging/tests/test_command_build_py.py | 4 | ||||
| -rw-r--r-- | Lib/packaging/tests/test_database.py | 2 | ||||
| -rw-r--r-- | Lib/packaging/tests/test_install.py | 2 | ||||
| -rw-r--r-- | Lib/packaging/util.py | 2 |
5 files changed, 6 insertions, 6 deletions
diff --git a/Lib/packaging/command/install_distinfo.py b/Lib/packaging/command/install_distinfo.py index a25a15a2bb..db49236b96 100644 --- a/Lib/packaging/command/install_distinfo.py +++ b/Lib/packaging/command/install_distinfo.py @@ -98,7 +98,7 @@ class install_distinfo(Command): if self.requested: requested_path = os.path.join(self.distinfo_dir, 'REQUESTED') logger.info('creating %s', requested_path) - open(requested_path, 'w').close() + open(requested_path, 'wb').close() self.outputs.append(requested_path) diff --git a/Lib/packaging/tests/test_command_build_py.py b/Lib/packaging/tests/test_command_build_py.py index 9b40e6d9b2..3c5630b23f 100644 --- a/Lib/packaging/tests/test_command_build_py.py +++ b/Lib/packaging/tests/test_command_build_py.py @@ -72,10 +72,10 @@ class BuildPyTestCase(support.TempdirManager, sources = self.mkdtemp() pkg = os.path.join(sources, 'pkg') os.mkdir(pkg) - open(os.path.join(pkg, "__init__.py"), "w").close() + open(os.path.join(pkg, "__init__.py"), "wb").close() testdir = os.path.join(pkg, "doc") os.mkdir(testdir) - open(os.path.join(testdir, "testfile"), "w").close() + open(os.path.join(testdir, "testfile"), "wb").close() os.chdir(sources) old_stdout = sys.stdout diff --git a/Lib/packaging/tests/test_database.py b/Lib/packaging/tests/test_database.py index c8d941527e..251181aba0 100644 --- a/Lib/packaging/tests/test_database.py +++ b/Lib/packaging/tests/test_database.py @@ -133,7 +133,7 @@ class TestDistribution(CommonDistributionTests, unittest.TestCase): def tearDown(self): for distinfo_dir in self.dirs: record_file = os.path.join(distinfo_dir, 'RECORD') - open(record_file, 'w').close() + open(record_file, 'wb').close() super(TestDistribution, self).tearDown() def test_instantiation(self): diff --git a/Lib/packaging/tests/test_install.py b/Lib/packaging/tests/test_install.py index 8aae4ac29c..7bdee943af 100644 --- a/Lib/packaging/tests/test_install.py +++ b/Lib/packaging/tests/test_install.py @@ -227,7 +227,7 @@ class TestInstall(LoggingCatcher, TempdirManager, unittest.TestCase): newpath = self.mkdtemp() files = [os.path.join(path, str(x)) for x in range(1, 20)] for f in files: - open(f, 'a+').close() + open(f, 'ab+').close() output = [o for o in install._move_files(files, newpath)] # check that output return the list of old/new places diff --git a/Lib/packaging/util.py b/Lib/packaging/util.py index 348e3cd14a..058f13e334 100644 --- a/Lib/packaging/util.py +++ b/Lib/packaging/util.py @@ -1201,7 +1201,7 @@ def egginfo_to_distinfo(record_file, installer=_DEFAULT_INSTALLER, if requested: requested_path = distinfo['requested_path'] logger.info('creating %s', requested_path) - open(requested_path, 'w').close() + open(requested_path, 'wb').close() distinfo['installed'].append(requested_path) record_path = distinfo['record_path'] |