diff options
author | Senthil Kumaran <orsenthil@gmail.com> | 2010-12-17 04:56:02 +0000 |
---|---|---|
committer | Senthil Kumaran <orsenthil@gmail.com> | 2010-12-17 04:56:02 +0000 |
commit | 5c7fd6eefa457457f6f19e4397a79de5627af32e (patch) | |
tree | b172f2cae3162594127f81689c81d79ec477b859 | |
parent | 3e8cd62d0342d819157ddab7c36b0eee4018ab95 (diff) | |
download | cpython-git-5c7fd6eefa457457f6f19e4397a79de5627af32e.tar.gz |
Merged revisions 87329 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k
........
r87329 | senthil.kumaran | 2010-12-17 12:48:45 +0800 (Fri, 17 Dec 2010) | 3 lines
Fix Issue9721 - urljoin behavior when the relative url starts with ';'
........
-rw-r--r-- | Lib/test/test_urlparse.py | 3 | ||||
-rw-r--r-- | Lib/urlparse.py | 9 | ||||
-rw-r--r-- | Misc/NEWS | 2 |
3 files changed, 7 insertions, 7 deletions
diff --git a/Lib/test/test_urlparse.py b/Lib/test/test_urlparse.py index 82440176f4..c5764c59ca 100644 --- a/Lib/test/test_urlparse.py +++ b/Lib/test/test_urlparse.py @@ -295,6 +295,9 @@ class UrlParseTestCase(unittest.TestCase): #self.checkJoin(RFC3986_BASE, 'http:g','http:g') # strict parser self.checkJoin(RFC3986_BASE, 'http:g','http://a/b/c/g') # relaxed parser + # Test for issue9721 + self.checkJoin('http://a/b/c/de', ';x','http://a/b/c/;x') + def test_urljoins(self): self.checkJoin(SIMPLE_BASE, 'g:h','g:h') self.checkJoin(SIMPLE_BASE, 'http:g','http://a/b/c/g') diff --git a/Lib/urlparse.py b/Lib/urlparse.py index 4ac9867331..a019a7b7a4 100644 --- a/Lib/urlparse.py +++ b/Lib/urlparse.py @@ -256,14 +256,9 @@ def urljoin(base, url, allow_fragments=True): if path[:1] == '/': return urlunparse((scheme, netloc, path, params, query, fragment)) - if not path: + if not path and not params: path = bpath - if not params: - params = bparams - else: - path = path[:-1] - return urlunparse((scheme, netloc, path, - params, query, fragment)) + params = bparams if not query: query = bquery return urlunparse((scheme, netloc, path, @@ -21,6 +21,8 @@ Core and Builtins Library ------- +- Issue #9721: Fix the behavior of urljoin when the relative url starts with a + ';' character. Patch by Wes Chow. - Issue #10714: Limit length of incoming request in http.server to 65536 bytes for security reasons. Initial patch by Ross Lagerwall. |