summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorent Xicluna <florent.xicluna@gmail.com>2011-11-04 10:15:57 +0100
committerFlorent Xicluna <florent.xicluna@gmail.com>2011-11-04 10:15:57 +0100
commit5f761d79c0578c24f72663493915b8975e246fbd (patch)
tree4eb7b006ebca307d40e3f694fc4b400179388dc0
parent09f871462f2b6cd53daf7cb43e861737af9ebc52 (diff)
downloadcpython-git-5f761d79c0578c24f72663493915b8975e246fbd.tar.gz
Issue #13140: Fix the daemon_threads attribute of ThreadingMixIn.
-rw-r--r--Lib/SocketServer.py3
-rw-r--r--Lib/test/test_socketserver.py1
-rw-r--r--Misc/NEWS2
3 files changed, 3 insertions, 3 deletions
diff --git a/Lib/SocketServer.py b/Lib/SocketServer.py
index 71b9caa973..2ff388836a 100644
--- a/Lib/SocketServer.py
+++ b/Lib/SocketServer.py
@@ -589,8 +589,7 @@ class ThreadingMixIn:
"""Start a new thread to process the request."""
t = threading.Thread(target = self.process_request_thread,
args = (request, client_address))
- if self.daemon_threads:
- t.setDaemon (1)
+ t.daemon = self.daemon_threads
t.start()
diff --git a/Lib/test/test_socketserver.py b/Lib/test/test_socketserver.py
index 41634e73a2..08fb03350d 100644
--- a/Lib/test/test_socketserver.py
+++ b/Lib/test/test_socketserver.py
@@ -123,7 +123,6 @@ class SocketServerTest(unittest.TestCase):
self.assertEqual(server.server_address, server.socket.getsockname())
return server
- @unittest.skipUnless(threading, 'Threading required for this test.')
@reap_threads
def run_server(self, svrcls, hdlrbase, testfunc):
server = self.make_server(self.pickaddr(svrcls.address_family),
diff --git a/Misc/NEWS b/Misc/NEWS
index c7637beca0..2701b87013 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -74,6 +74,8 @@ Core and Builtins
Library
-------
+- Issue #13140: Fix the daemon_threads attribute of ThreadingMixIn.
+
- Issue #2892: preserve iterparse events in case of SyntaxError.
- Issue #670664: Fix HTMLParser to correctly handle the content of