summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTarek Ziadé <ziade.tarek@gmail.com>2009-11-29 22:20:30 +0000
committerTarek Ziadé <ziade.tarek@gmail.com>2009-11-29 22:20:30 +0000
commita5076a2543e9d52128b875bc4b3b0521ed3a2b12 (patch)
treeea35399f6744926c4d5aa3ba9f36d1075f921941
parentc4ab8339e9a966d9d8e601531489a5436d197f47 (diff)
downloadcpython-git-a5076a2543e9d52128b875bc4b3b0521ed3a2b12.tar.gz
Fixed #7408: dropped group ownership checking because it relies on os-specific rules
-rw-r--r--Lib/distutils/tests/test_sdist.py5
-rw-r--r--Misc/NEWS4
2 files changed, 8 insertions, 1 deletions
diff --git a/Lib/distutils/tests/test_sdist.py b/Lib/distutils/tests/test_sdist.py
index b8e3dca560..20b20aae0b 100644
--- a/Lib/distutils/tests/test_sdist.py
+++ b/Lib/distutils/tests/test_sdist.py
@@ -336,10 +336,13 @@ class SDistTestCase(PyPIRCCommandTestCase):
# making sure we have the good rights
archive_name = join(self.tmp_dir, 'dist', 'fake-1.0.tar.gz')
archive = tarfile.open(archive_name)
+
+ # note that we are not testing the group ownership here
+ # because, depending on the platforms and the container
+ # rights (see #7408)
try:
for member in archive.getmembers():
self.assertEquals(member.uid, os.getuid())
- self.assertEquals(member.gid, os.getgid())
finally:
archive.close()
diff --git a/Misc/NEWS b/Misc/NEWS
index e5c8626777..8ac7c24fcc 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -487,6 +487,10 @@ Core and Builtins
Library
-------
+- Issue #7408: Fixed distutils.tests.sdist so it doesn't check for group
+ ownership when the group is not forced, because the group may be different
+ from the user's group and inherit from its container when the test is run.
+
- Issue #1515: Enable use of deepcopy() with instance methods. Patch by
Robert Collins.