summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVictor Stinner <victor.stinner@gmail.com>2015-10-01 00:53:09 +0200
committerVictor Stinner <victor.stinner@gmail.com>2015-10-01 00:53:09 +0200
commita53a818c3c67c927bcf8ee118fd29e21045dd9ab (patch)
tree2a2458ba72070603304e8ed6f4579e79d85baade
parentc29f399e7e59c6e3d369568af784958321c151ac (diff)
downloadcpython-git-a53a818c3c67c927bcf8ee118fd29e21045dd9ab.tar.gz
Fix regrtest --coverage on Windows
Issue #25260: Fix ``python -m test --coverage`` on Windows. Remove the list of ignored directories.
-rw-r--r--Lib/test/libregrtest/main.py5
-rw-r--r--Lib/test/test_regrtest.py2
-rw-r--r--Misc/NEWS3
3 files changed, 4 insertions, 6 deletions
diff --git a/Lib/test/libregrtest/main.py b/Lib/test/libregrtest/main.py
index e1a99fb50b..c1ce3b179f 100644
--- a/Lib/test/libregrtest/main.py
+++ b/Lib/test/libregrtest/main.py
@@ -272,10 +272,7 @@ class Regrtest:
def run_tests_sequential(self):
if self.ns.trace:
import trace
- self.tracer = trace.Trace(ignoredirs=[sys.base_prefix,
- sys.base_exec_prefix,
- tempfile.gettempdir()],
- trace=False, count=True)
+ self.tracer = trace.Trace(trace=False, count=True)
save_modules = sys.modules.keys()
diff --git a/Lib/test/test_regrtest.py b/Lib/test/test_regrtest.py
index 897598dddc..0f5f22ca4e 100644
--- a/Lib/test/test_regrtest.py
+++ b/Lib/test/test_regrtest.py
@@ -605,8 +605,6 @@ class ArgsTestCase(BaseTestCase):
% (self.TESTNAME_REGEX, len(tests)))
self.check_line(output, regex)
- @unittest.skipIf(sys.platform == 'win32',
- "FIXME: coverage doesn't work on Windows")
def test_coverage(self):
# test --coverage
test = self.create_test()
diff --git a/Misc/NEWS b/Misc/NEWS
index 72d6fef778..a1aa269c70 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -157,6 +157,9 @@ Documentation
Tests
-----
+- Issue #25260: Fix ``python -m test --coverage`` on Windows. Remove the
+ list of ignored directories.
+
- PCbuild\rt.bat now accepts an unlimited number of arguments to pass along
to regrtest.py. Previously there was a limit of 9.