diff options
author | Zachary Ware <zachary.ware@gmail.com> | 2013-12-16 09:05:44 -0600 |
---|---|---|
committer | Zachary Ware <zachary.ware@gmail.com> | 2013-12-16 09:05:44 -0600 |
commit | d2e48ca813a70edc4a28477c150ad8079df584e6 (patch) | |
tree | 966755dcfd2714a7e54f6570b78e869615b1078f | |
parent | e9dacaa93f64ba05f06c06db7d81571ba580a352 (diff) | |
parent | 1007432c95acee46a09b08306ef1859b97a184b0 (diff) | |
download | cpython-git-d2e48ca813a70edc4a28477c150ad8079df584e6.tar.gz |
Issue #19987: Merge with 3.3
-rw-r--r-- | Lib/test/test_winsound.py | 16 | ||||
-rw-r--r-- | Misc/NEWS | 2 |
2 files changed, 9 insertions, 9 deletions
diff --git a/Lib/test/test_winsound.py b/Lib/test/test_winsound.py index f1af2d2fc5..83618b6a44 100644 --- a/Lib/test/test_winsound.py +++ b/Lib/test/test_winsound.py @@ -158,15 +158,15 @@ class PlaySoundTest(unittest.TestCase): ) def test_alias_fallback(self): - if _have_soundcard(): + # In the absense of the ability to tell if a sound was actually + # played, this test has two acceptable outcomes: success (no error, + # sound was theoretically played; although as issue #19987 shows + # a box without a soundcard can "succeed") or RuntimeError. Any + # other error is a failure. + try: winsound.PlaySound('!"$%&/(#+*', winsound.SND_ALIAS) - # see http://bugs.python.org/issue19987 - #else: - # self.assertRaises( - # RuntimeError, - # winsound.PlaySound, - # '!"$%&/(#+*', winsound.SND_ALIAS - # ) + except RuntimeError: + pass def test_alias_nofallback(self): if _have_soundcard(): @@ -199,7 +199,7 @@ Tests - Issue #19572: More skipped tests explicitly marked as skipped. -- Issue #19595: Re-enabled a long-disabled test in test_winsound. +- Issue #19595, #19987: Re-enabled a long-disabled test in test_winsound. - Issue #19588: Fixed tests in test_random that were silently skipped most of the time. Patch by Julian Gindi. |