diff options
| author | Neal Norwitz <nnorwitz@gmail.com> | 2006-07-16 02:35:47 +0000 |
|---|---|---|
| committer | Neal Norwitz <nnorwitz@gmail.com> | 2006-07-16 02:35:47 +0000 |
| commit | ee4cc698ca906c519054a85d119c76e757227e82 (patch) | |
| tree | 6af7ef2bb20a9e32e86354878b29e3ef026ac366 | |
| parent | fc28e0de584e8040bd27080b0111a722243b82c7 (diff) | |
| download | cpython-git-ee4cc698ca906c519054a85d119c76e757227e82.tar.gz | |
PyFunction_SetDefaults() is documented as taking None or a tuple.
A NULL would crash the PyTuple_Check(). Now make NULL return a SystemError.
Reported by Klocwork #73.
| -rw-r--r-- | Objects/funcobject.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Objects/funcobject.c b/Objects/funcobject.c index 59cb519507..e514eeb2d3 100644 --- a/Objects/funcobject.c +++ b/Objects/funcobject.c @@ -109,8 +109,8 @@ PyFunction_SetDefaults(PyObject *op, PyObject *defaults) } if (defaults == Py_None) defaults = NULL; - else if (PyTuple_Check(defaults)) { - Py_XINCREF(defaults); + else if (defaults && PyTuple_Check(defaults)) { + Py_INCREF(defaults); } else { PyErr_SetString(PyExc_SystemError, "non-tuple default args"); |