summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFlorent Xicluna <florent.xicluna@gmail.com>2010-03-08 10:59:33 +0000
committerFlorent Xicluna <florent.xicluna@gmail.com>2010-03-08 10:59:33 +0000
commitfaf175385de454a99edef26986637fc80c8aaba7 (patch)
tree367f5165abb1db721ef407b1998e1de8539ab51d
parentcf741ceb69f951448a61a2f654b198c1cde0c579 (diff)
downloadcpython-git-faf175385de454a99edef26986637fc80c8aaba7.tar.gz
Replace the stderr logging with assertNotEqual(returncode, 0).
-rw-r--r--Lib/test/test_subprocess.py6
1 files changed, 2 insertions, 4 deletions
diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py
index 027546b047..dc57c46b45 100644
--- a/Lib/test/test_subprocess.py
+++ b/Lib/test/test_subprocess.py
@@ -770,7 +770,7 @@ class Win32ProcessTestCase(unittest.TestCase):
p = subprocess.Popen([sys.executable, "-c", "input()"],
stdin=subprocess.PIPE)
- # Let the process initialize
+ # Let the process initialize (Issue #3137)
time.sleep(0.1)
# The process should not terminate prematurely
self.assertIsNone(p.poll())
@@ -786,10 +786,8 @@ class Win32ProcessTestCase(unittest.TestCase):
if count > 1:
print >>sys.stderr, ("p.{}{} succeeded after "
"{} attempts".format(method, args, count))
- if returncode == 0:
- # On some win32 platforms, it returns 0. See #2777.
- print >>sys.stderr, "p.{}{} returned 0".format(method, args)
self.assertEqual(p.wait(), returncode)
+ self.assertNotEqual(returncode, 0)
def test_send_signal(self):
self._kill_process('send_signal', signal.SIGTERM)