summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTarek Ziadé <ziade.tarek@gmail.com>2009-10-12 22:38:34 +0000
committerTarek Ziadé <ziade.tarek@gmail.com>2009-10-12 22:38:34 +0000
commitff0d8a36befda1fbecf11d76921f9e34632c181b (patch)
treeb1c3c7aa742fcbd2f8af46268ab9b4d18401bc80
parentdff2028a1b8d680cc489bb3ffb8a5b120e772c8a (diff)
downloadcpython-git-ff0d8a36befda1fbecf11d76921f9e34632c181b.tar.gz
Fixed #7115: using paths instead of dotted name for extensions works too in distutils.command.build_ext
-rw-r--r--Lib/distutils/command/build_ext.py2
-rw-r--r--Lib/distutils/tests/test_build_ext.py10
-rw-r--r--Misc/NEWS3
3 files changed, 15 insertions, 0 deletions
diff --git a/Lib/distutils/command/build_ext.py b/Lib/distutils/command/build_ext.py
index da9cbfd574..abc1584180 100644
--- a/Lib/distutils/command/build_ext.py
+++ b/Lib/distutils/command/build_ext.py
@@ -628,6 +628,8 @@ class build_ext (Command):
The file is located in `build_lib` or directly in the package
(inplace option).
"""
+ if os.sep in ext_name:
+ ext_name = ext_name.replace(os.sep, '.')
fullname = self.get_ext_fullname(ext_name)
modpath = fullname.split('.')
filename = self.get_ext_filename(ext_name)
diff --git a/Lib/distutils/tests/test_build_ext.py b/Lib/distutils/tests/test_build_ext.py
index 00733a46a7..5dffe2ca03 100644
--- a/Lib/distutils/tests/test_build_ext.py
+++ b/Lib/distutils/tests/test_build_ext.py
@@ -363,6 +363,16 @@ class BuildExtTestCase(support.TempdirManager,
path = cmd.get_ext_fullpath('lxml.etree')
self.assertEquals(wanted, path)
+ def test_build_ext_path_with_os_sep(self):
+ dist = Distribution({'name': 'UpdateManager'})
+ cmd = build_ext(dist)
+ cmd.ensure_finalized()
+ ext = sysconfig.get_config_var("SO")
+ ext_name = os.path.join('UpdateManager', 'fdsend')
+ ext_path = cmd.get_ext_fullpath(ext_name)
+ wanted = os.path.join(cmd.build_lib, 'UpdateManager', 'fdsend' + ext)
+ self.assertEquals(ext_path, wanted)
+
def test_suite():
if not sysconfig.python_build:
if test_support.verbose:
diff --git a/Misc/NEWS b/Misc/NEWS
index b4a2c50a6f..26cbbb4143 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -18,6 +18,9 @@ Core and Builtins
Library
-------
+- Issue #7115: Fixed the extension module builds that is failing when using
+ paths in the extension name instead of dotted names.
+
- Issue #7068: Fixed the partial renaming that occured in r72594.
- Issue #7064: Fixed the incompatibility with Setuptools in distutils