summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Wouters <thomas@python.org>2001-07-16 15:45:20 +0000
committerThomas Wouters <thomas@python.org>2001-07-16 15:45:20 +0000
commitb8238516a2eadc8ec1e6a55fdc3c0664bb97349d (patch)
treeeee899b9d796c39ceab51acb10b6bbf7a64d427d
parentc743869a59972f4accc0c1f6ab9594ef888e0f20 (diff)
downloadcpython-git-b8238516a2eadc8ec1e6a55fdc3c0664bb97349d.tar.gz
Fix SF #441664: Python crash on del of a slice of a mmap
Check for slice/item deletion, which calls slice/item assignment with a NULL value, and raise a TypeError instead of coredumping. Bugreport and suggested fix by Alex Martelli.
-rw-r--r--Modules/mmapmodule.c10
1 files changed, 10 insertions, 0 deletions
diff --git a/Modules/mmapmodule.c b/Modules/mmapmodule.c
index 63ef72a7f3..d5bc89f309 100644
--- a/Modules/mmapmodule.c
+++ b/Modules/mmapmodule.c
@@ -663,6 +663,11 @@ mmap_ass_slice(mmap_object *self, int ilow, int ihigh, PyObject *v)
else if ((size_t)ihigh > self->size)
ihigh = self->size;
+ if (v == NULL) {
+ PyErr_SetString(PyExc_TypeError,
+ "mmap object doesn't support slice deletion");
+ return -1;
+ }
if (! (PyString_Check(v)) ) {
PyErr_SetString(PyExc_IndexError,
"mmap slice assignment must be a string");
@@ -688,6 +693,11 @@ mmap_ass_item(mmap_object *self, int i, PyObject *v)
PyErr_SetString(PyExc_IndexError, "mmap index out of range");
return -1;
}
+ if (v == NULL) {
+ PyErr_SetString(PyExc_TypeError,
+ "mmap object doesn't support item deletion");
+ return -1;
+ }
if (! (PyString_Check(v) && PyString_Size(v)==1) ) {
PyErr_SetString(PyExc_IndexError,
"mmap assignment must be single-character string");