summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2018-06-05 06:47:42 -0700
committerGitHub <noreply@github.com>2018-06-05 06:47:42 -0700
commit194a5c07228342106c98dcf85c8a5f4cd2c8b04e (patch)
treedae96ac0e869343dcf9c64c9f4a3aa18d1cb549d
parentae55d29fe04ee1aeb1bcb2e9b84e5bc9d4ecb070 (diff)
downloadcpython-git-194a5c07228342106c98dcf85c8a5f4cd2c8b04e.tar.gz
bpo-33752: Fix a file leak in test_dbm. (GH-7376)
With addCleanup() f.close() was executed after tearDown(). (cherry picked from commit 6592d7fe11477f8f974d2d4a85c3382a1ad05217) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
-rw-r--r--Lib/test/test_dbm.py6
1 files changed, 2 insertions, 4 deletions
diff --git a/Lib/test/test_dbm.py b/Lib/test/test_dbm.py
index 78c32c4c93..1884b5c683 100644
--- a/Lib/test/test_dbm.py
+++ b/Lib/test/test_dbm.py
@@ -75,10 +75,8 @@ class AnyDBMTestCase:
def test_anydbm_creation_n_file_exists_with_invalid_contents(self):
# create an empty file
test.support.create_empty_file(_fname)
-
- f = dbm.open(_fname, 'n')
- self.addCleanup(f.close)
- self.assertEqual(len(f), 0)
+ with dbm.open(_fname, 'n') as f:
+ self.assertEqual(len(f), 0)
def test_anydbm_modification(self):
self.init_db()