diff options
author | Neal Norwitz <nnorwitz@gmail.com> | 2007-02-25 19:44:48 +0000 |
---|---|---|
committer | Neal Norwitz <nnorwitz@gmail.com> | 2007-02-25 19:44:48 +0000 |
commit | ee3a1b5244e60566c5d5c8f6a1ea4b381de99f1c (patch) | |
tree | ad52a17fc77530870a575107a7cea9c27de17606 /Include/stringobject.h | |
parent | 5a3e812444609329b30be837a08c11269d917b72 (diff) | |
download | cpython-git-ee3a1b5244e60566c5d5c8f6a1ea4b381de99f1c.tar.gz |
Variation of patch # 1624059 to speed up checking if an object is a subclass
of some of the common builtin types.
Use a bit in tp_flags for each common builtin type. Check the bit
to determine if any instance is a subclass of these common types.
The check avoids a function call and O(n) search of the base classes.
The check is done in the various Py*_Check macros rather than calling
PyType_IsSubtype().
All the bits are set in tp_flags when the type is declared
in the Objects/*object.c files because PyType_Ready() is not called
for all the types. Should PyType_Ready() be called for all types?
If so and the change is made, the changes to the Objects/*object.c files
can be reverted (remove setting the tp_flags). Objects/typeobject.c
would also have to be modified to add conditions
for Py*_CheckExact() in addition to each the PyType_IsSubtype check.
Diffstat (limited to 'Include/stringobject.h')
-rw-r--r-- | Include/stringobject.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/Include/stringobject.h b/Include/stringobject.h index 5f8a6f02a0..03c377763b 100644 --- a/Include/stringobject.h +++ b/Include/stringobject.h @@ -55,7 +55,8 @@ typedef struct { PyAPI_DATA(PyTypeObject) PyBaseString_Type; PyAPI_DATA(PyTypeObject) PyString_Type; -#define PyString_Check(op) PyObject_TypeCheck(op, &PyString_Type) +#define PyString_Check(op) \ + PyType_FastSubclass((op)->ob_type, Py_TPFLAGS_STRING_SUBCLASS) #define PyString_CheckExact(op) ((op)->ob_type == &PyString_Type) PyAPI_FUNC(PyObject *) PyString_FromStringAndSize(const char *, Py_ssize_t); |