summaryrefslogtreecommitdiff
path: root/Lib/logging/handlers.py
diff options
context:
space:
mode:
authorVinay Sajip <vinay_sajip@yahoo.co.uk>2010-08-22 18:11:02 +0000
committerVinay Sajip <vinay_sajip@yahoo.co.uk>2010-08-22 18:11:02 +0000
commite8b1eafd8819bcc98d38a93a9ecfe76066c370a1 (patch)
tree78602d9517ef6768ea0bb7d14e737a771604808f /Lib/logging/handlers.py
parente5632642fcd590e01087da5b2c32d14d5fe83585 (diff)
downloadcpython-git-e8b1eafd8819bcc98d38a93a9ecfe76066c370a1.tar.gz
Issue #9512: Made comment more informative.
Diffstat (limited to 'Lib/logging/handlers.py')
-rw-r--r--Lib/logging/handlers.py7
1 files changed, 6 insertions, 1 deletions
diff --git a/Lib/logging/handlers.py b/Lib/logging/handlers.py
index cda84e7010..38beb1079b 100644
--- a/Lib/logging/handlers.py
+++ b/Lib/logging/handlers.py
@@ -108,8 +108,13 @@ class RotatingFileHandler(BaseRotatingHandler):
If maxBytes is zero, rollover never occurs.
"""
+ # If rotation/rollover is wanted, it doesn't make sense to use another
+ # mode. If for example 'w' were specified, then if there were multiple
+ # runs of the calling application, the logs from previous runs would be
+ # lost if the 'w' is respected, because the log file would be truncated
+ # on each run.
if maxBytes > 0:
- mode = 'a' # doesn't make sense otherwise!
+ mode = 'a'
BaseRotatingHandler.__init__(self, filename, mode, encoding, delay)
self.maxBytes = maxBytes
self.backupCount = backupCount