summaryrefslogtreecommitdiff
path: root/Lib/test/test_httplib.py
diff options
context:
space:
mode:
authorSerhiy Storchaka <storchaka@gmail.com>2013-02-06 10:35:40 +0200
committerSerhiy Storchaka <storchaka@gmail.com>2013-02-06 10:35:40 +0200
commitb6c86fd87f93f73c8d5f759d3f5136f1a1cc67e9 (patch)
tree55c7afdcc6d513a552b69e7a3ff4481c11f4a873 /Lib/test/test_httplib.py
parente201e9d584e2922997eeacad06ee6e84a6419d08 (diff)
parentb5b9c8cd402b8ab8d6cb00f157ac855b37a1e5c6 (diff)
downloadcpython-git-b6c86fd87f93f73c8d5f759d3f5136f1a1cc67e9.tar.gz
Issue #16723: httplib.HTTPResponse no longer marked closed when the connection
is automatically closed.
Diffstat (limited to 'Lib/test/test_httplib.py')
-rw-r--r--Lib/test/test_httplib.py24
1 files changed, 24 insertions, 0 deletions
diff --git a/Lib/test/test_httplib.py b/Lib/test/test_httplib.py
index a58a592476..db123dcb56 100644
--- a/Lib/test/test_httplib.py
+++ b/Lib/test/test_httplib.py
@@ -164,6 +164,9 @@ class BasicTest(TestCase):
resp.begin()
self.assertEqual(resp.read(), b"Text")
self.assertTrue(resp.isclosed())
+ self.assertFalse(resp.closed)
+ resp.close()
+ self.assertTrue(resp.closed)
body = "HTTP/1.1 400.100 Not Ok\r\n\r\nText"
sock = FakeSocket(body)
@@ -185,6 +188,9 @@ class BasicTest(TestCase):
self.assertFalse(resp.isclosed())
self.assertEqual(resp.read(2), b'xt')
self.assertTrue(resp.isclosed())
+ self.assertFalse(resp.closed)
+ resp.close()
+ self.assertTrue(resp.closed)
def test_partial_readintos(self):
# if we have a length, the system knows when to close itself
@@ -202,6 +208,9 @@ class BasicTest(TestCase):
self.assertEqual(n, 2)
self.assertEqual(bytes(b), b'xt')
self.assertTrue(resp.isclosed())
+ self.assertFalse(resp.closed)
+ resp.close()
+ self.assertTrue(resp.closed)
def test_partial_reads_no_content_length(self):
# when no length is present, the socket should be gracefully closed when
@@ -215,6 +224,9 @@ class BasicTest(TestCase):
self.assertEqual(resp.read(2), b'xt')
self.assertEqual(resp.read(1), b'')
self.assertTrue(resp.isclosed())
+ self.assertFalse(resp.closed)
+ resp.close()
+ self.assertTrue(resp.closed)
def test_partial_readintos_no_content_length(self):
# when no length is present, the socket should be gracefully closed when
@@ -266,6 +278,9 @@ class BasicTest(TestCase):
n = resp.readinto(b)
self.assertEqual(n, 0)
self.assertTrue(resp.isclosed())
+ self.assertFalse(resp.closed)
+ resp.close()
+ self.assertTrue(resp.closed)
def test_host_port(self):
# Check invalid host_port
@@ -493,6 +508,9 @@ class BasicTest(TestCase):
self.assertEqual(resp.status, 200)
self.assertEqual(resp.reason, 'OK')
self.assertTrue(resp.isclosed())
+ self.assertFalse(resp.closed)
+ resp.close()
+ self.assertTrue(resp.closed)
def test_readinto_chunked_head(self):
chunked_start = (
@@ -513,6 +531,9 @@ class BasicTest(TestCase):
self.assertEqual(resp.status, 200)
self.assertEqual(resp.reason, 'OK')
self.assertTrue(resp.isclosed())
+ self.assertFalse(resp.closed)
+ resp.close()
+ self.assertTrue(resp.closed)
def test_negative_content_length(self):
sock = FakeSocket(
@@ -588,6 +609,9 @@ class BasicTest(TestCase):
resp.begin()
self.assertEqual(resp.read(), b'')
self.assertTrue(resp.isclosed())
+ self.assertFalse(resp.closed)
+ resp.close()
+ self.assertTrue(resp.closed)
class OfflineTest(TestCase):
def test_responses(self):