diff options
author | Serhiy Storchaka <storchaka@gmail.com> | 2020-04-25 10:06:29 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-04-25 10:06:29 +0300 |
commit | 16994912c93e8e5db7365d48b75d67d3f70dd7b2 (patch) | |
tree | 248f177a93676406af6d6ae977bed868aa2d1a34 /Lib/test/test_nntplib.py | |
parent | 3c8a5b459d68b4337776ada1e04f5b33f90a2275 (diff) | |
download | cpython-git-16994912c93e8e5db7365d48b75d67d3f70dd7b2.tar.gz |
bpo-40275: Avoid importing socket in test.support (GH-19603)
* Move socket related functions from test.support to socket_helper.
* Import socket, nntplib and urllib.error lazily in transient_internet().
* Remove importing multiprocess.
Diffstat (limited to 'Lib/test/test_nntplib.py')
-rw-r--r-- | Lib/test/test_nntplib.py | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/Lib/test/test_nntplib.py b/Lib/test/test_nntplib.py index fdd76f9e9b..2a5a0b97ee 100644 --- a/Lib/test/test_nntplib.py +++ b/Lib/test/test_nntplib.py @@ -10,6 +10,7 @@ import re import threading from test import support +from test.support import socket_helper from nntplib import NNTP, GroupInfo import nntplib from unittest.mock import patch @@ -1555,14 +1556,14 @@ class MockSslTests(MockSocketTests): class LocalServerTests(unittest.TestCase): def setUp(self): sock = socket.socket() - port = support.bind_port(sock) + port = socket_helper.bind_port(sock) sock.listen() self.background = threading.Thread( target=self.run_server, args=(sock,)) self.background.start() self.addCleanup(self.background.join) - self.nntp = NNTP(support.HOST, port, usenetrc=False).__enter__() + self.nntp = NNTP(socket_helper.HOST, port, usenetrc=False).__enter__() self.addCleanup(self.nntp.__exit__, None, None, None) def run_server(self, sock): |