diff options
| author | Brett Cannon <brett@python.org> | 2013-01-11 11:17:53 -0500 |
|---|---|---|
| committer | Brett Cannon <brett@python.org> | 2013-01-11 11:17:53 -0500 |
| commit | b463c482bf6506095f5f11c4f650b7ae356f4452 (patch) | |
| tree | e037735b4273696367e042f999f632537163b8e1 /Lib/test/test_urllibnet.py | |
| parent | 9d30698d9e0f5c96fb42b9db781d161cccb6a595 (diff) | |
| download | cpython-git-b463c482bf6506095f5f11c4f650b7ae356f4452.tar.gz | |
Issue #3583: mention that testing whether a bad address not triggering
an OSError can mean a bad DNS server and not an actual bug.
Diffstat (limited to 'Lib/test/test_urllibnet.py')
| -rw-r--r-- | Lib/test/test_urllibnet.py | 19 |
1 files changed, 9 insertions, 10 deletions
diff --git a/Lib/test/test_urllibnet.py b/Lib/test/test_urllibnet.py index e0782d2c51..896d7c93e3 100644 --- a/Lib/test/test_urllibnet.py +++ b/Lib/test/test_urllibnet.py @@ -121,16 +121,15 @@ class urlopenNetworkTests(unittest.TestCase): else: # This happens with some overzealous DNS providers such as OpenDNS self.skipTest("%r should not resolve for test to work" % bogus_domain) - self.assertRaises(OSError, - # SF patch 809915: In Sep 2003, VeriSign started - # highjacking invalid .com and .net addresses to - # boost traffic to their own site. This test - # started failing then. One hopes the .invalid - # domain will be spared to serve its defined - # purpose. - # urllib.urlopen, "http://www.sadflkjsasadf.com/") - urllib.request.urlopen, - "http://sadflkjsasf.i.nvali.d/") + failure_explanation = ('opening an invalid URL did not raise OSError; ' + 'can be caused by a broken DNS server ' + '(e.g. returns 404 or hijacks page)') + with self.assertRaises(OSError, msg=failure_explanation): + # SF patch 809915: In Sep 2003, VeriSign started highjacking + # invalid .com and .net addresses to boost traffic to their own + # site. This test started failing then. One hopes the .invalid + # domain will be spared to serve its defined purpose. + urllib.request.urlopen("http://sadflkjsasf.i.nvali.d/") class urlretrieveNetworkTests(unittest.TestCase): |