summaryrefslogtreecommitdiff
path: root/Lib/test
diff options
context:
space:
mode:
authorJohn Belmonte <john@neggie.net>2021-10-05 15:21:34 +0900
committerGitHub <noreply@github.com>2021-10-04 23:21:34 -0700
commit872b1e537e96d0dc4ff37c738031940b5d271366 (patch)
tree9eb4a7d575fda3c330123a50f9fde515bb53fc50 /Lib/test
parent1e328afb04aa5dbb396e105b1ef65a79eb394dde (diff)
downloadcpython-git-872b1e537e96d0dc4ff37c738031940b5d271366.tar.gz
[3.10] bpo-44594: fix (Async)ExitStack handling of __context__ (gh-27089) (GH-28730)
Make enter_context(foo()) / enter_async_context(foo()) equivalent to `[async] with foo()` regarding __context__ when an exception is raised. Previously exceptions would be caught and re-raised with the wrong context when explicitly overriding __context__ with None.. (cherry picked from commit e6d1aa1ac65b6908fdea2c70ec3aa8c4f1dffcb5) Co-authored-by: John Belmonte <john@neggie.net> Automerge-Triggered-By: GH:njsmith
Diffstat (limited to 'Lib/test')
-rw-r--r--Lib/test/test_contextlib.py34
-rw-r--r--Lib/test/test_contextlib_async.py35
2 files changed, 69 insertions, 0 deletions
diff --git a/Lib/test/test_contextlib.py b/Lib/test/test_contextlib.py
index 5a080654ac..fbaae2dd09 100644
--- a/Lib/test/test_contextlib.py
+++ b/Lib/test/test_contextlib.py
@@ -780,6 +780,40 @@ class TestBaseExitStack:
self.assertIsInstance(inner_exc, ValueError)
self.assertIsInstance(inner_exc.__context__, ZeroDivisionError)
+ def test_exit_exception_explicit_none_context(self):
+ # Ensure ExitStack chaining matches actual nested `with` statements
+ # regarding explicit __context__ = None.
+
+ class MyException(Exception):
+ pass
+
+ @contextmanager
+ def my_cm():
+ try:
+ yield
+ except BaseException:
+ exc = MyException()
+ try:
+ raise exc
+ finally:
+ exc.__context__ = None
+
+ @contextmanager
+ def my_cm_with_exit_stack():
+ with self.exit_stack() as stack:
+ stack.enter_context(my_cm())
+ yield stack
+
+ for cm in (my_cm, my_cm_with_exit_stack):
+ with self.subTest():
+ try:
+ with cm():
+ raise IndexError()
+ except MyException as exc:
+ self.assertIsNone(exc.__context__)
+ else:
+ self.fail("Expected IndexError, but no exception was raised")
+
def test_exit_exception_non_suppressing(self):
# http://bugs.python.org/issue19092
def raise_exc(exc):
diff --git a/Lib/test/test_contextlib_async.py b/Lib/test/test_contextlib_async.py
index 603162eaea..127d750065 100644
--- a/Lib/test/test_contextlib_async.py
+++ b/Lib/test/test_contextlib_async.py
@@ -552,6 +552,41 @@ class TestAsyncExitStack(TestBaseExitStack, unittest.TestCase):
self.assertIsInstance(inner_exc, ValueError)
self.assertIsInstance(inner_exc.__context__, ZeroDivisionError)
+ @_async_test
+ async def test_async_exit_exception_explicit_none_context(self):
+ # Ensure AsyncExitStack chaining matches actual nested `with` statements
+ # regarding explicit __context__ = None.
+
+ class MyException(Exception):
+ pass
+
+ @asynccontextmanager
+ async def my_cm():
+ try:
+ yield
+ except BaseException:
+ exc = MyException()
+ try:
+ raise exc
+ finally:
+ exc.__context__ = None
+
+ @asynccontextmanager
+ async def my_cm_with_exit_stack():
+ async with self.exit_stack() as stack:
+ await stack.enter_async_context(my_cm())
+ yield stack
+
+ for cm in (my_cm, my_cm_with_exit_stack):
+ with self.subTest():
+ try:
+ async with cm():
+ raise IndexError()
+ except MyException as exc:
+ self.assertIsNone(exc.__context__)
+ else:
+ self.fail("Expected IndexError, but no exception was raised")
+
class TestAsyncNullcontext(unittest.TestCase):
@_async_test