diff options
author | Antoine Pitrou <solipsis@pitrou.net> | 2010-12-17 17:42:16 +0000 |
---|---|---|
committer | Antoine Pitrou <solipsis@pitrou.net> | 2010-12-17 17:42:16 +0000 |
commit | 401edd69cf23f7f102aece55e05157daf1b87f9f (patch) | |
tree | 7baf64e3ca486395af74948c01124c8fb79cdf16 /Lib/threading.py | |
parent | 988dbd7bc2bb8a41cf91a12c8bff9a916651769f (diff) | |
download | cpython-git-401edd69cf23f7f102aece55e05157daf1b87f9f.tar.gz |
Issue #4188: Avoid creating dummy thread objects when logging operations
from the threading module (with the internal verbose flag activated).
Diffstat (limited to 'Lib/threading.py')
-rw-r--r-- | Lib/threading.py | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/Lib/threading.py b/Lib/threading.py index b6c1e5ddab..01c27b85e6 100644 --- a/Lib/threading.py +++ b/Lib/threading.py @@ -55,8 +55,14 @@ if __debug__: def _note(self, format, *args): if self._verbose: format = format % args - format = "%s: %s\n" % ( - current_thread().name, format) + # Issue #4188: calling current_thread() can incur an infinite + # recursion if it has to create a DummyThread on the fly. + ident = _get_ident() + try: + name = _active[ident].name + except KeyError: + name = "<OS thread %d>" % ident + format = "%s: %s\n" % (name, format) _sys.stderr.write(format) else: |