diff options
| author | Senthil Kumaran <senthil@uthcode.com> | 2016-07-30 23:24:16 -0700 |
|---|---|---|
| committer | Senthil Kumaran <senthil@uthcode.com> | 2016-07-30 23:24:16 -0700 |
| commit | 4cbb23f8f278fd1f71dcd5968aa0b3f0b4f3bd5d (patch) | |
| tree | 6b9afcfb2dbbcaba109a7b00785f711af576c538 /Lib/urllib/request.py | |
| parent | d27a7c1f22b263a3eef5d380c7058c993bd3a451 (diff) | |
| download | cpython-git-4cbb23f8f278fd1f71dcd5968aa0b3f0b4f3bd5d.tar.gz | |
Prevent HTTPoxy attack (CVE-2016-1000110)
Ignore the HTTP_PROXY variable when REQUEST_METHOD environment is set, which
indicates that the script is in CGI mode.
Issue #27568 Reported and patch contributed by Rémi Rampin.
Diffstat (limited to 'Lib/urllib/request.py')
| -rw-r--r-- | Lib/urllib/request.py | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/Lib/urllib/request.py b/Lib/urllib/request.py index ef62acc710..537b765a12 100644 --- a/Lib/urllib/request.py +++ b/Lib/urllib/request.py @@ -2366,6 +2366,13 @@ def getproxies_environment(): name = name.lower() if value and name[-6:] == '_proxy': proxies[name[:-6]] = value + + # CVE-2016-1000110 - If we are running as CGI script, forget HTTP_PROXY + # (non-all-lowercase) as it may be set from the web server by a "Proxy:" + # header from the client + if 'REQUEST_METHOD' in os.environ: + proxies.pop('http', None) + return proxies def proxy_bypass_environment(host): |