diff options
| author | arikrupnik <ari@30pins.com> | 2018-06-06 23:42:38 -0500 |
|---|---|---|
| committer | Fred Drake <fred@fdrake.net> | 2018-06-07 00:42:38 -0400 |
| commit | 5bfa058e65897567889354d7eb34af2b93a20f18 (patch) | |
| tree | fcbae0b123d4ad0a28db1bfb61bc9b77fc0452fd /Lib | |
| parent | 7c69c1c0fba8c1c8ff3969bce4c1135736a4cc58 (diff) | |
| download | cpython-git-5bfa058e65897567889354d7eb34af2b93a20f18.tar.gz | |
bpo-33274: Compliance with DOM L1: return removed attribute (#7465)
* bpo-33274: Compliance with DOM L1: return removed attribute
* Update 2018-06-06-22-01-33.bpo-33274.teYqv8.rst
Diffstat (limited to 'Lib')
| -rw-r--r-- | Lib/test/test_minidom.py | 2 | ||||
| -rw-r--r-- | Lib/xml/dom/minidom.py | 1 |
2 files changed, 2 insertions, 1 deletions
diff --git a/Lib/test/test_minidom.py b/Lib/test/test_minidom.py index a2cc882846..e91cdba1eb 100644 --- a/Lib/test/test_minidom.py +++ b/Lib/test/test_minidom.py @@ -325,7 +325,7 @@ class MinidomTest(unittest.TestCase): node = child.getAttributeNode("spam") self.assertRaises(xml.dom.NotFoundErr, child.removeAttributeNode, None) - child.removeAttributeNode(node) + self.assertIs(node, child.removeAttributeNode(node)) self.confirm(len(child.attributes) == 0 and child.getAttributeNode("spam") is None) dom2 = Document() diff --git a/Lib/xml/dom/minidom.py b/Lib/xml/dom/minidom.py index a5d813f932..e44e04a069 100644 --- a/Lib/xml/dom/minidom.py +++ b/Lib/xml/dom/minidom.py @@ -823,6 +823,7 @@ class Element(Node): # Restore this since the node is still useful and otherwise # unlinked node.ownerDocument = self.ownerDocument + return node removeAttributeNodeNS = removeAttributeNode |