diff options
| author | Bar Harel <bzvi7919@gmail.com> | 2019-06-01 12:19:09 +0300 |
|---|---|---|
| committer | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2019-06-01 02:19:09 -0700 |
| commit | 6b282e18877ec84e927b381b4ce187eaf4ba3dd7 (patch) | |
| tree | 67b8d2c67bc175ee2fcbf2d5164e4dcba6291c50 /Misc | |
| parent | 70c5f2ae6e6a07d44a8d3f3202ea01bf697e05db (diff) | |
| download | cpython-git-6b282e18877ec84e927b381b4ce187eaf4ba3dd7.tar.gz | |
bpo-36813: Fix QueueListener to call task_done() upon termination. (GH-13113)
Fixed QueueListener in order to avoid random deadlocks.
Unable to add regression tests atm due to time constraints, will add it in a bit.
Regarding implementation, although it's nested, it does not cause performance issues whatsoever, and does not call task_done() in case of an exception (which is the right thing to do IMHO).
https://bugs.python.org/issue36813
Diffstat (limited to 'Misc')
| -rw-r--r-- | Misc/NEWS.d/next/Library/2019-05-06-18-28-38.bpo-36813.NXD0KZ.rst | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/Misc/NEWS.d/next/Library/2019-05-06-18-28-38.bpo-36813.NXD0KZ.rst b/Misc/NEWS.d/next/Library/2019-05-06-18-28-38.bpo-36813.NXD0KZ.rst new file mode 100644 index 0000000000..e89358aa40 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2019-05-06-18-28-38.bpo-36813.NXD0KZ.rst @@ -0,0 +1,2 @@ +Fix :class:`~logging.handlers.QueueListener` to call ``queue.task_done()`` +upon stopping. Patch by Bar Harel. |