diff options
author | Kyle Stanley <aeros167@gmail.com> | 2020-01-12 06:02:50 -0500 |
---|---|---|
committer | Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> | 2020-01-12 03:02:50 -0800 |
commit | 0ca7cc7fc0518c24dc9b78c38418e6064e64f148 (patch) | |
tree | 58e1b54a708c63c4d26e42ebbc64cde5e45220b6 /Python/Python-ast.c | |
parent | d7c7adde003ddca5cbe4fc47cf09464ab95a066e (diff) | |
download | cpython-git-0ca7cc7fc0518c24dc9b78c38418e6064e64f148.tar.gz |
bpo-38356: Fix ThreadedChildWatcher thread leak in test_asyncio (GH-16552)
Motivation for this PR (comment from @vstinner in bpo issue):
```
Warning seen o AMD64 Ubuntu Shared 3.x buildbot:
https://buildbot.python.org/all/#/builders/141/builds/2593
test_devnull_output (test.test_a=syncio.test_subprocess.SubprocessThreadedWatcherTests) ...
Warning -- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 2)
```
The following implementation details for the new method are TBD:
1) Public vs private
2) Inclusion in `close()`
3) Name
4) Coroutine vs subroutine method
5) *timeout* parameter
If it's a private method, 3, 4, and 5 are significantly less important.
I started with the most minimal implementation that fixes the dangling threads without modifying the regression tests, which I think is particularly important. I typically try to avoid directly modifying existing tests as much as possible unless it's necessary to do so. However, I am open to changing any part of this.
https://bugs.python.org/issue38356
Diffstat (limited to 'Python/Python-ast.c')
0 files changed, 0 insertions, 0 deletions