diff options
author | Carl Friedrich Bolz-Tereick <cfbolz@gmx.de> | 2020-01-29 16:43:37 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-01-29 15:43:37 +0000 |
commit | a327677905956ae0b239ff430a1346dfe265709e (patch) | |
tree | 761a01408b75c8900ca38b7cc86e0a49a50b27bb /Python/preconfig.c | |
parent | 3cb49b62e61208efcefbc04414e769fc173f205d (diff) | |
download | cpython-git-a327677905956ae0b239ff430a1346dfe265709e.tar.gz |
bpo-39485: fix corner-case in method-detection of mock (GH-18252)
Replace check for whether something is a method in the mock module. The
previous version fails on PyPy, because there no method wrappers exist
(everything looks like a regular Python-defined function). Thus the
isinstance(getattr(result, '__get__', None), MethodWrapperTypes) check
returns True for any descriptor, not just methods.
This condition could also return erroneously True in CPython for
C-defined descriptors.
Instead to decide whether something is a method, just check directly
whether it's a function defined on the class. This passes all tests on
CPython and fixes the bug on PyPy.
Diffstat (limited to 'Python/preconfig.c')
0 files changed, 0 insertions, 0 deletions