diff options
| author | Victor Stinner <vstinner@redhat.com> | 2018-11-30 12:29:25 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-11-30 12:29:25 +0100 |
| commit | ebd5d6d6e6e4e751ba9c7534004aadfc27ba9265 (patch) | |
| tree | 2edebc8f7592365099b06147b547f683831c156a /Python | |
| parent | 55e498058faf8c97840556f6d791c2c392732dc3 (diff) | |
| download | cpython-git-ebd5d6d6e6e4e751ba9c7534004aadfc27ba9265.tar.gz | |
bpo-35347: Fix test_socket.NonBlockingTCPTests (GH-10791)
testAccept() and testRecv() of test_socket.NonBlockingTCPTests have a
race condition: time.sleep() is used as a weak synchronization
primitive and the tests fail randomly on slow buildbots.
Use a reliable threading.Event to fix these tests.
Other changes:
* Replace send() with sendall()
* Expect specific BlockingIOError rather than generic OSError
* Add a timeout to select() in testAccept() and testRecv()
* Use addCleanup() to close sockets
* Use assertRaises()
Diffstat (limited to 'Python')
0 files changed, 0 insertions, 0 deletions