summaryrefslogtreecommitdiff
path: root/Lib/subprocess.py
diff options
context:
space:
mode:
Diffstat (limited to 'Lib/subprocess.py')
-rw-r--r--Lib/subprocess.py14
1 files changed, 8 insertions, 6 deletions
diff --git a/Lib/subprocess.py b/Lib/subprocess.py
index 551aad342b..3241758452 100644
--- a/Lib/subprocess.py
+++ b/Lib/subprocess.py
@@ -778,19 +778,21 @@ class Popen(object):
self.stdin.write(input)
except BrokenPipeError:
pass # communicate() must ignore broken pipe errors.
- except OSError as e:
- if e.errno == errno.EINVAL and self.poll() is not None:
- # Issue #19612: On Windows, stdin.write() fails with EINVAL
- # if the process already exited before the write
+ except OSError as exc:
+ if exc.errno == errno.EINVAL:
+ # bpo-19612, bpo-30418: On Windows, stdin.write() fails
+ # with EINVAL if the child process exited or if the child
+ # process is still running but closed the pipe.
pass
else:
raise
+
try:
self.stdin.close()
except BrokenPipeError:
pass # communicate() must ignore broken pipe errors.
- except OSError as e:
- if e.errno == errno.EINVAL and self.poll() is not None:
+ except OSError as exc:
+ if exc.errno == errno.EINVAL:
pass
else:
raise