From 3a313e36555a3416799f3c049b8ebb41e9edeb8a Mon Sep 17 00:00:00 2001 From: Neil Schemenauer Date: Mon, 19 Jul 2004 16:29:17 +0000 Subject: Check the type of values returned by __int__, __float__, __long__, __oct__, and __hex__. Raise TypeError if an invalid type is returned. Note that PyNumber_Int and PyNumber_Long can still return ints or longs. Fixes SF bug #966618. --- Python/bltinmodule.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) (limited to 'Python') diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c index 10e59c9580..4143681b8a 100644 --- a/Python/bltinmodule.c +++ b/Python/bltinmodule.c @@ -962,6 +962,7 @@ static PyObject * builtin_hex(PyObject *self, PyObject *v) { PyNumberMethods *nb; + PyObject *res; if ((nb = v->ob_type->tp_as_number) == NULL || nb->nb_hex == NULL) { @@ -969,7 +970,15 @@ builtin_hex(PyObject *self, PyObject *v) "hex() argument can't be converted to hex"); return NULL; } - return (*nb->nb_hex)(v); + res = (*nb->nb_hex)(v); + if (res && !PyString_Check(res)) { + PyErr_Format(PyExc_TypeError, + "__hex__ returned non-string (type %.200s)", + res->ob_type->tp_name); + Py_DECREF(res); + return NULL; + } + return res; } PyDoc_STRVAR(hex_doc, @@ -1178,6 +1187,7 @@ static PyObject * builtin_oct(PyObject *self, PyObject *v) { PyNumberMethods *nb; + PyObject *res; if (v == NULL || (nb = v->ob_type->tp_as_number) == NULL || nb->nb_oct == NULL) { @@ -1185,7 +1195,15 @@ builtin_oct(PyObject *self, PyObject *v) "oct() argument can't be converted to oct"); return NULL; } - return (*nb->nb_oct)(v); + res = (*nb->nb_oct)(v); + if (res && !PyString_Check(res)) { + PyErr_Format(PyExc_TypeError, + "__oct__ returned non-string (type %.200s)", + res->ob_type->tp_name); + Py_DECREF(res); + return NULL; + } + return res; } PyDoc_STRVAR(oct_doc, -- cgit v1.2.1