delta/distcc-git.git/popt, branch python3 github.com: distcc/distcc.git Fix a couple of compiler warnings. 2011-10-21T01:26:37+00:00 fergus.henderson fergushenderson@users.noreply.github.com 2011-10-21T01:26:37+00:00 b6bf948082442071b68bd6a5330520c83b132da6 Reviewed by Craig Silverstein. 
Reviewed by Craig Silverstein.
Make handling of config.h sound. 2008-05-09T18:15:18+00:00 klarlund klarlund@gmail.com 2008-05-09T18:15:18+00:00 a31b5d6a22150bc54c93166910ba9f351081c659 (1) Correct order of -Is in Makefile. (2) remove unnessary PATH modification in configure.ac (this is fergus's suggestion -- hopefully this will do, this replaces a circumvention mechanism I had originally concocted. (3) Fix place of the include of popt in CPPFLAGS. (4) Convert quoted includes of config.h to angle bracket includes so that the build version, not the source version, of this file is picked up. The order of -Is in the build system is wrong: it contradicts the VPATH mechanism. This means that builds in a build directory different from that of the source (distribution) directory will find wrong files even after the hapless developer has issued only a 'configure' command in the source directory (but not actually 'made' any thing there). For in that case, the src/config.h will be generated in the source directory and this will be the file picked in the build directory even if that directory has it's own src/config.h. This can lead to wrong builds and it can be hard to diagnose the problem. Currently, this what CPPFLAGS end up being (as found in the generated Makefile): CPPFLAGS = -DHAVE_CONFIG_H -D_GNU_SOURCE \ -I../distcc/popt -I../distcc/src \ ${DIR_DEFS} \ -Isrc -Ilzo \ -I"$(srcdir)/src" -I"$(srcdir)/lzo" \ Here my source dir was ../distcc. The presence of '-I../distcc/popt' in front of -Isrc is the exact opposite of the semantics of VPATH mechanism, which looks for files in the build directory, then in the source directory. Also, note the remarks in: http://www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Headers (they do not quite correctly discuss the search path, btw). TESTING: I verified that with a corrupted config.h file in the source directory, building now succeeds. Also: make distcheck (it fails the same place as before: this is corrected in another change of mine --- I'll verify that with that change in place, this change makes 'make distcheck' succeed.) REVIEWERS: fergus@google.com, csilvers@google.com 
(1) Correct order of -Is in Makefile.

(2) remove unnessary PATH modification in configure.ac (this is fergus's
suggestion -- hopefully this will do, this replaces a circumvention mechanism I
had originally concocted.

(3) Fix place of the include of popt in CPPFLAGS.

(4) Convert quoted includes of config.h to angle bracket includes so that the
build version, not the source version, of this file is picked up.

The order of -Is in the build system is wrong: it contradicts the
VPATH mechanism.  

This means that builds in a build directory different from that
of the source (distribution) directory will find wrong files even
after the hapless developer has issued only a 'configure' command
in the source directory (but not actually 'made' any thing
there).  For in that case, the src/config.h will be generated in
the source directory and this will be the file picked in the
build directory even if that directory has it's own src/config.h.
This can lead to wrong builds and it can be hard to diagnose the
problem.

Currently, this what CPPFLAGS end up being (as found in the
generated Makefile):

  CPPFLAGS =  -DHAVE_CONFIG_H -D_GNU_SOURCE \
              -I../distcc/popt -I../distcc/src \
              ${DIR_DEFS} \
              -Isrc -Ilzo \
              -I"$(srcdir)/src" -I"$(srcdir)/lzo" \

Here my source dir was ../distcc.  

The presence of '-I../distcc/popt' in front of -Isrc is the exact
opposite of the semantics of VPATH mechanism, which looks for
files in the build directory, then in the source directory.  

Also, note the remarks in:

  http://www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Headers

(they do not quite correctly discuss the search path, btw).

TESTING: I verified that with a corrupted config.h file in the source directory,
building now succeeds.

Also: make distcheck (it fails the same place as before: this is corrected in
another change of mine --- I'll verify that with that change in place, this
change makes 'make distcheck' succeed.)

REVIEWERS: fergus@google.com, csilvers@google.com
Explain stamp files and remove unneeded @src_dir@ (which was misspelled?). 2008-05-02T19:54:12+00:00 klarlund klarlund@gmail.com 2008-05-02T19:54:12+00:00 9db0b8221d9e94e92b27e0ff562f3221c1d008f9 TESTED: make distcheck REVIEWED: csilvers@google.com, fergus@google.com 
TESTED: make distcheck
REVIEWED: csilvers@google.com, fergus@google.com
The first step of moving everything in the distcc directory to the top 2008-04-11T22:36:40+00:00 Craig Silverstein csilvers@khanacademy.org 2008-04-11T22:36:40+00:00 596cf4e2f019a766965ad0566495c56b7d295fe4 level. I'm doing this in two stages, because I don't understand svn enough to be confident to do it in one. This first stage just copies all the files from distcc/FOO to FOO. Now there are two copies of each file under distcc; the Makefile/etc uses the one in distcc and ignores the one at the top level. The next commit will delete everything under distcc, and rewrite the Makefile/etc to use the top-level versions instead. 
level.  I'm doing this in two stages, because I don't understand svn
enough to be confident to do it in one.  This first stage just copies
all the files from distcc/FOO to FOO.  Now there are two copies of
each file under distcc; the Makefile/etc uses the one in distcc and
ignores the one at the top level.

The next commit will delete everything under distcc, and rewrite the
Makefile/etc to use the top-level versions instead.