delta/git.git/http.c, branch jc/signed-commit

Merge branch 'jk/http-auth'

2011-10-18T04:37:15+00:00

* jk/http-auth:
  http_init: accept separate URL parameter
  http: use hostname in credential description
  http: retry authentication failures for all http requests
  remote-curl: don't retry auth failures with dumb protocol
  improve httpd auth tests
  url: decode buffers that are not NUL-terminated

http_init: accept separate URL parameter

2011-10-16T04:18:36+00:00

The http_init function takes a "struct remote". Part of its
initialization procedure is to look at the remote's url and
grab some auth-related parameters. However, using the url
included in the remote is:

  - wrong; the remote-curl helper may have a separate,
    unrelated URL (e.g., from remote.*.pushurl). Looking at
    the remote's configured url is incorrect.

  - incomplete; http-fetch doesn't have a remote, so passes
    NULL. So http_init never gets to see the URL we are
    actually going to use.

  - cumbersome; http-push has a similar problem to
    http-fetch, but actually builds a fake remote just to
    pass in the URL.

Instead, let's just add a separate URL parameter to
http_init, and all three callsites can pass in the
appropriate information.

Signed-off-by: Jeff King 
Signed-off-by: Junio C Hamano

http: use hostname in credential description

2011-10-16T04:18:20+00:00

Until now, a request for an http password looked like:

  Username:
  Password:

Now it will look like:

  Username for 'example.com':
  Password for 'example.com':

Picked-from: Jeff King 
Signed-off-by: Michael J Gruber 
Signed-off-by: Junio C Hamano

Merge branch 'jn/maint-http-error-message'

2011-10-10T22:56:17+00:00

* jn/maint-http-error-message:
  http: avoid empty error messages for some curl errors
  http: remove extra newline in error message

http: avoid empty error messages for some curl errors

2011-09-06T22:49:23+00:00

When asked to fetch over SSL without a valid
/etc/ssl/certs/ca-certificates.crt file, "git fetch" writes

	error:  while accessing https://github.com/torvalds/linux.git/info/refs

which is a little disconcerting.  Better to fall back to
curl_easy_strerror(result) when the error string is empty, like the
curl utility does:

	error: Problem with the SSL CA cert (path? access rights?) while
	accessing https://github.com/torvalds/linux.git/info/refs

Signed-off-by: Jonathan Nieder 
Signed-off-by: Junio C Hamano

http: remove extra newline in error message

2011-09-06T22:48:49+00:00

There is no need for a blank line between the detailed error message
and the later "fatal: HTTP request failed" notice.  Keep the newline
written by error() itself and eliminate the extra one.

Signed-off-by: Jonathan Nieder 
Signed-off-by: Junio C Hamano

Merge branch 'rc/maint-http-wrong-free'

2011-08-11T18:03:13+00:00

* rc/maint-http-wrong-free:
  Makefile: some changes for http-related flag documentation
  http.c: fix an invalid free()

Conflicts:
	Makefile

http.c: fix an invalid free()

2011-08-03T18:23:09+00:00

Remove a free() on the static buffer returned by sha1_file_name().

While we're at it, replace xmalloc() calls on the structs
http_(object|pack)_request with xcalloc() so that pointers in the
structs get initialized to NULL. That way, free()'s are safe - for
example, a free() on the url string member when aborting.

This fixes an invalid free().

Reported-by: Ævar Arnfjörð Bjarmason 
Helped-by: Jeff King peff@peff.net
Signed-off-by: Tay Ray Chuan 
Signed-off-by: Junio C Hamano

http: retry authentication failures for all http requests

2011-07-20T18:38:35+00:00

Commit 42653c0 (Prompt for a username when an HTTP request
401s, 2010-04-01) changed http_get_strbuf to prompt for
credentials when we receive a 401, but didn't touch
http_get_file. The latter is called only for dumb http;
while it's usually the case that people don't use
authentication on top of dumb http, there is no reason not
to allow both types of requests to use this feature.

Signed-off-by: Jeff King 
Signed-off-by: Junio C Hamano

url: decode buffers that are not NUL-terminated

2011-07-20T18:38:34+00:00

The url_decode function needs only minor tweaks to handle
arbitrary buffers. Let's do those tweaks, which cleans up an
unreadable mess of temporary strings in http.c.

Signed-off-by: Jeff King 
Signed-off-by: Junio C Hamano