delta/git.git/prompt.h, branch dw/subtree-split-do-not-drop-merge github.com: git/git.git prompt.c: remove git_getpass() nobody uses 2015-01-15T19:02:06+00:00 Junio C Hamano gitster@pobox.com 2015-01-14T23:40:48+00:00 0fb1df4af2a28bc95b26fbd9d4f172a461d88ef2 This was whittled down to a compatibility wrapper around the more flexible git_prompt() in 1cb0134f (refactor git_getpass into generic prompt function, 2011-12-10), waiting for the final callers to go away. That happened in 791643a8 (imap-send: use git-credential, 2014-04-28) when imap-send learned to use the credential interface. Reviewed-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> 
This was whittled down to a compatibility wrapper around the more
flexible git_prompt() in 1cb0134f (refactor git_getpass into generic
prompt function, 2011-12-10), waiting for the final callers to go
away.  That happened in 791643a8 (imap-send: use git-credential,
2014-04-28) when imap-send learned to use the credential interface.

Reviewed-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
prompt: use git_terminal_prompt 2011-12-13T00:09:38+00:00 Jeff King peff@peff.net 2011-12-10T10:41:08+00:00 a50902590e703878e888fd8a33ec5a22d5347481 Our custom implementation of git_terminal_prompt has many advantages over regular getpass(), as described in the prior commit. This also lets us implement a PROMPT_ECHO flag for callers who want it. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> 
Our custom implementation of git_terminal_prompt has many
advantages over regular getpass(), as described in the prior
commit.

This also lets us implement a PROMPT_ECHO flag for callers
who want it.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
refactor git_getpass into generic prompt function 2011-12-13T00:09:38+00:00 Jeff King peff@peff.net 2011-12-10T10:40:57+00:00 1cb0134f3414be187cc3eb98e9740aeeb07dcb16 This will allow callers to specify more options (e.g., leaving echo on). The original git_getpass becomes a slim wrapper around the new function. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> 
This will allow callers to specify more options (e.g.,
leaving echo on). The original git_getpass becomes a slim
wrapper around the new function.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
move git_getpass to its own source file 2011-12-13T00:09:38+00:00 Jeff King peff@peff.net 2011-12-10T10:40:54+00:00 d3c58b83aee2007ca76dc5d1242c09b6f7989c76 This is currently in connect.c, but really has nothing to do with the git protocol itself. Let's make a new source file all about prompting the user, which will make it cleaner to refactor. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> 
This is currently in connect.c, but really has nothing to
do with the git protocol itself. Let's make a new source
file all about prompting the user, which will make it
cleaner to refactor.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>