summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Haggerty <mhagger@alum.mit.edu>2015-05-01 14:25:58 +0200
committerJunio C Hamano <gitster@pobox.com>2015-05-10 11:31:33 -0700
commit01d0dd1b96d92c1d293f6c0303b6103df31209d1 (patch)
tree3f5126f203788b018fa6b0768ddf7a847c4d0b51
parent7c774c30a135a728f34a7cf0076e0e65ba28f0c3 (diff)
downloadgit-01d0dd1b96d92c1d293f6c0303b6103df31209d1.tar.gz
reflog_expire(): integrate lock_ref_sha1_basic() errors into ours
Now that lock_ref_sha1_basic() gives us back its error messages via a strbuf, incorporate its error message into our error message rather than emitting two separate error messages. Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
-rw-r--r--refs.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/refs.c b/refs.c
index 5e3e907c00..3a4597508d 100644
--- a/refs.c
+++ b/refs.c
@@ -4146,9 +4146,9 @@ int reflog_expire(const char *refname, const unsigned char *sha1,
*/
lock = lock_ref_sha1_basic(refname, sha1, NULL, NULL, 0, &type, &err);
if (!lock) {
- error("%s", err.buf);
+ error("cannot lock ref '%s': %s", refname, err.buf);
strbuf_release(&err);
- return error("cannot lock ref '%s'", refname);
+ return -1;
}
if (!reflog_exists(refname)) {
unlock_ref(lock);