summaryrefslogtreecommitdiff
path: root/Documentation/CodingGuidelines
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2012-12-21 15:18:47 -0800
committerJunio C Hamano <gitster@pobox.com>2012-12-21 15:18:47 -0800
commitc2c6a70a54d2ce51187ba6409b65f819daa55497 (patch)
treea5ced7196b2987e04a8e0a1ec6a57b3eaac514f5 /Documentation/CodingGuidelines
parent19b4520ba9c367bf562d1fe38deaa2b96be81309 (diff)
parenta26fd033af23389cd6e17d078007aaec61b5c9c1 (diff)
downloadgit-c2c6a70a54d2ce51187ba6409b65f819daa55497.tar.gz
Merge branch 'as/doc-for-devs'
It might be a better idea to move the text the bottom one adds to the extended description from the quick checklist part. * as/doc-for-devs: Documentation: move support for old compilers to CodingGuidelines SubmittingPatches: add convention of prefixing commit messages
Diffstat (limited to 'Documentation/CodingGuidelines')
-rw-r--r--Documentation/CodingGuidelines8
1 files changed, 8 insertions, 0 deletions
diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
index 57da6aadeb..69f7e9b76c 100644
--- a/Documentation/CodingGuidelines
+++ b/Documentation/CodingGuidelines
@@ -112,6 +112,14 @@ For C programs:
- We try to keep to at most 80 characters per line.
+ - We try to support a wide range of C compilers to compile git with,
+ including old ones. That means that you should not use C99
+ initializers, even if a lot of compilers grok it.
+
+ - Variables have to be declared at the beginning of the block.
+
+ - NULL pointers shall be written as NULL, not as 0.
+
- When declaring pointers, the star sides with the variable
name, i.e. "char *string", not "char* string" or
"char * string". This makes it easier to understand code