<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git, branch 25482-fix-api-sudo</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Be smarter when finding a sudoed user in API::Helpers</title>
<updated>2016-12-13T14:53:00+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2016-12-13T14:53:00+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d95b709a66a5597dced25a2b9df9a1e24fc6d49a'/>
<id>d95b709a66a5597dced25a2b9df9a1e24fc6d49a</id>
<content type='text'>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>API: Memoize the current_user so that the sudo can work properly</title>
<updated>2016-12-12T12:50:31+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2016-12-09T17:48:20+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=2f45d3bcf0f28d4cd4124b4c9722edc1d3085201'/>
<id>2f45d3bcf0f28d4cd4124b4c9722edc1d3085201</id>
<content type='text'>
The issue was arising when `#current_user` was called a second time
after a user was impersonated: the `User#is_admin?` check would be
performed on it and it would fail.

Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The issue was arising when `#current_user` was called a second time
after a user was impersonated: the `User#is_admin?` check would be
performed on it and it would fail.

Signed-off-by: Rémy Coutable &lt;remy@rymai.me&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '25294-remove-signed-out-msg' into 'master'</title>
<updated>2016-12-12T12:37:23+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@mcgivern.me.uk</email>
</author>
<published>2016-12-12T12:37:23+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=0f6964a38527e648551e981157d5489d4c301b76'/>
<id>0f6964a38527e648551e981157d5489d4c301b76</id>
<content type='text'>

fix: 25294 - remove signed_out notification

Closes #25294

See merge request !7958</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

fix: 25294 - remove signed_out notification

Closes #25294

See merge request !7958</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch '25510-fix-notifications-dropdown-alignment' into 'master'</title>
<updated>2016-12-12T09:53:02+00:00</updated>
<author>
<name>Fatih Acet</name>
<email>acetfatih@gmail.com</email>
</author>
<published>2016-12-12T09:53:02+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=db9e1635d0d17596193ecbee8e0acc1916918d1d'/>
<id>db9e1635d0d17596193ecbee8e0acc1916918d1d</id>
<content type='text'>

Fix alignment for notification settings ajax response

## What does this MR do?

Fixes a issue where an AJAX call to change your global notification settings will return an html partial which has the incorrect dropdown alignment class, in some cases causing the dropdown menu to become obscured on the left side of the screen.

## Are there points in the code the reviewer needs to double check?

## Screenshots (if relevant)

See issue #25510 for a screenshot of the problem and steps to reproduce.

## Does this MR meet the acceptance criteria?

- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~
- [ ] ~~API support added~~
- Tests
  - [ ] ~~Added for this feature/bug~~
  - [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

Closes #25510

See merge request !8024</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Fix alignment for notification settings ajax response

## What does this MR do?

Fixes a issue where an AJAX call to change your global notification settings will return an html partial which has the incorrect dropdown alignment class, in some cases causing the dropdown menu to become obscured on the left side of the screen.

## Are there points in the code the reviewer needs to double check?

## Screenshots (if relevant)

See issue #25510 for a screenshot of the problem and steps to reproduce.

## Does this MR meet the acceptance criteria?

- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~
- [ ] ~~API support added~~
- Tests
  - [ ] ~~Added for this feature/bug~~
  - [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

Closes #25510

See merge request !8024</pre>
</div>
</content>
</entry>
<entry>
<title>fix: removed signed_out notification</title>
<updated>2016-12-12T09:34:48+00:00</updated>
<author>
<name>jnoortheen</name>
<email>jnoortheen@gmail.com</email>
</author>
<published>2016-12-06T17:02:30+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3c36d9dc9b3c2db45df6dce19357e9c4bdde366f'/>
<id>3c36d9dc9b3c2db45df6dce19357e9c4bdde366f</id>
<content type='text'>
test: replaced signed_out message check with check for sign_in button

fixes #25294
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
test: replaced signed_out message check with check for sign_in button

fixes #25294
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'features/api-snippets' into 'master'</title>
<updated>2016-12-12T08:58:13+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@mcgivern.me.uk</email>
</author>
<published>2016-12-12T08:58:13+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=87f3a66c32f8cab6c814f81ec9dfea69f64d79cc'/>
<id>87f3a66c32f8cab6c814f81ec9dfea69f64d79cc</id>
<content type='text'>

Adding support for personal snippet endpoint on the API

Closes #22042

See merge request !6373</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Adding support for personal snippet endpoint on the API

Closes #22042

See merge request !6373</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'patch-8' into 'master'</title>
<updated>2016-12-12T08:23:34+00:00</updated>
<author>
<name>Sean McGivern</name>
<email>sean@mcgivern.me.uk</email>
</author>
<published>2016-12-12T08:23:34+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=221a461c1e917e816e30c213d48ad0ff87170527'/>
<id>221a461c1e917e816e30c213d48ad0ff87170527</id>
<content type='text'>

Fix typo

See merge request !8029</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Fix typo

See merge request !8029</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'patch-8' into 'master'</title>
<updated>2016-12-11T21:38:19+00:00</updated>
<author>
<name>Robert Schilling</name>
<email>rschilling@student.tugraz.at</email>
</author>
<published>2016-12-11T21:38:19+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1879613a997ae587d3c478b97c925631727a6222'/>
<id>1879613a997ae587d3c478b97c925631727a6222</id>
<content type='text'>

Fix typo in curl example request

See the general Documentation guidelines http://docs.gitlab.com/ce/development/doc_styleguide.html

## What does this MR do?

Fix a typo in a curl example
Closes #23834 

## Moving docs to a new location?

See the guidelines: http://docs.gitlab.com/ce/development/doc_styleguide.html#changing-document-location

- [ x] Make sure the old link is not removed and has its contents replaced with a link to the new location.
- [ x] Make sure internal links pointing to the document in question are not broken.
- [ x] Search and replace any links referring to old docs in GitLab Rails app, specifically under the `app/views/` directory.
- [ x] If working on CE, submit an MR to EE with the changes as well.

See merge request !8030</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>

Fix typo in curl example request

See the general Documentation guidelines http://docs.gitlab.com/ce/development/doc_styleguide.html

## What does this MR do?

Fix a typo in a curl example
Closes #23834 

## Moving docs to a new location?

See the guidelines: http://docs.gitlab.com/ce/development/doc_styleguide.html#changing-document-location

- [ x] Make sure the old link is not removed and has its contents replaced with a link to the new location.
- [ x] Make sure internal links pointing to the document in question are not broken.
- [ x] Search and replace any links referring to old docs in GitLab Rails app, specifically under the `app/views/` directory.
- [ x] If working on CE, submit an MR to EE with the changes as well.

See merge request !8030</pre>
</div>
</content>
</entry>
<entry>
<title>Fix typo in curl example request</title>
<updated>2016-12-11T19:36:01+00:00</updated>
<author>
<name>Georg Hartmann</name>
<email>mail@georg-hartmann.com</email>
</author>
<published>2016-12-11T19:36:01+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=36c24de5da7feb6392e8250e2d9e11e602d3e527'/>
<id>36c24de5da7feb6392e8250e2d9e11e602d3e527</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix typo</title>
<updated>2016-12-11T14:14:59+00:00</updated>
<author>
<name>Ismail S</name>
<email>astroman3d@gmail.com</email>
</author>
<published>2016-12-11T14:14:59+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=d6a1a3e6bee6417d02a2095bce479f494460ce17'/>
<id>d6a1a3e6bee6417d02a2095bce479f494460ce17</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
