<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/gitlab/gitlab-ce.git, branch fix-counts-caching</title>
<subtitle>gitlab.com: gitlab-org/gitlab-ce.git
</subtitle>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/'/>
<entry>
<title>Fix refreshing of issues/MR count caches</title>
<updated>2017-09-19T15:16:45+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2017-09-19T11:55:56+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=57b96eb6db9b860991b035714e65ffd557327b6f'/>
<id>57b96eb6db9b860991b035714e65ffd557327b6f</id>
<content type='text'>
This ensures the open issues/MR count caches are refreshed properly when
creating new issues or MRs. This MR also includes a change to the cache
keys to ensure all caches are rebuilt on the fly.

This particular problem was not caught in the test suite due to a null
cache being used, resulting in all calls that would use a cache using
the underlying data directly. In production the code would fail because
a newly saved record returns an empty hash in #changes meaning checks
such as `state_changed? || confidential_changed?` would return false for
new rows, thus never updating the counters.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/38061
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This ensures the open issues/MR count caches are refreshed properly when
creating new issues or MRs. This MR also includes a change to the cache
keys to ensure all caches are rebuilt on the fly.

This particular problem was not caught in the test suite due to a null
cache being used, resulting in all calls that would use a cache using
the underlying data directly. In production the code would fail because
a newly saved record returns an empty hash in #changes meaning checks
such as `state_changed? || confidential_changed?` would return false for
new rows, thus never updating the counters.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/38061
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'dev_time_failure_on_haml_to_gitaly' into 'master'</title>
<updated>2017-09-19T10:55:38+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2017-09-19T10:55:38+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=404a56235f86a69b05991efcf4cc5d7c5f5c4567'/>
<id>404a56235f86a69b05991efcf4cc5d7c5f5c4567</id>
<content type='text'>
Detect n+1 issues involving Gitaly

See merge request gitlab-org/gitlab-ce!13996</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Detect n+1 issues involving Gitaly

See merge request gitlab-org/gitlab-ce!13996</pre>
</div>
</content>
</entry>
<entry>
<title>Detect n+1 issues involving Gitaly</title>
<updated>2017-09-19T10:55:37+00:00</updated>
<author>
<name>Andrew Newdigate</name>
<email>andrew@gitlab.com</email>
</author>
<published>2017-09-19T10:55:37+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=64d7ec0a9e3ffd6233ccfbe9100f8a9391c648e5'/>
<id>64d7ec0a9e3ffd6233ccfbe9100f8a9391c648e5</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'sh-project-feature-eager-load' into 'master'</title>
<updated>2017-09-19T10:45:34+00:00</updated>
<author>
<name>Yorick Peterse</name>
<email>yorickpeterse@gmail.com</email>
</author>
<published>2017-09-19T10:45:34+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=39dd7736585d3e35d5c6f391e6a94c312da09056'/>
<id>39dd7736585d3e35d5c6f391e6a94c312da09056</id>
<content type='text'>
Eliminate N+1 queries referencing issues

Closes #38033

See merge request gitlab-org/gitlab-ce!14349</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Eliminate N+1 queries referencing issues

Closes #38033

See merge request gitlab-org/gitlab-ce!14349</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'backstage/gb/qa/fix-admin-area-selector' into 'master'</title>
<updated>2017-09-19T10:27:09+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2017-09-19T10:27:09+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=bfca22b825df2b3f113c91f7ddb0c145934790f2'/>
<id>bfca22b825df2b3f113c91f7ddb0c145934790f2</id>
<content type='text'>
Fix admin area selector in GitLab QA

Closes gitlab-qa#66

See merge request gitlab-org/gitlab-ce!14356</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix admin area selector in GitLab QA

Closes gitlab-qa#66

See merge request gitlab-org/gitlab-ce!14356</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'rc/improve-users-api-specs' into 'master'</title>
<updated>2017-09-19T08:58:18+00:00</updated>
<author>
<name>Grzegorz Bizon</name>
<email>grzegorz@gitlab.com</email>
</author>
<published>2017-09-19T08:58:18+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=cd61d6e6904547c709a78b8404077bab2abfa92a'/>
<id>cd61d6e6904547c709a78b8404077bab2abfa92a</id>
<content type='text'>
Improve the Users API specs by asserting against the response schema

See merge request gitlab-org/gitlab-ce!14334</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Improve the Users API specs by asserting against the response schema

See merge request gitlab-org/gitlab-ce!14334</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'bvl-port-of-ee-translations' into 'master'</title>
<updated>2017-09-19T08:52:54+00:00</updated>
<author>
<name>Douwe Maan</name>
<email>douwe@gitlab.com</email>
</author>
<published>2017-09-19T08:52:54+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=ec370adbe615cd1bd12c31a5fda887e2664ab28d'/>
<id>ec370adbe615cd1bd12c31a5fda887e2664ab28d</id>
<content type='text'>
Port of EE translations

Closes #37914

See merge request gitlab-org/gitlab-ce!14340</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Port of EE translations

Closes #37914

See merge request gitlab-org/gitlab-ce!14340</pre>
</div>
</content>
</entry>
<entry>
<title>Fix admin area selector in GitLab QA</title>
<updated>2017-09-19T08:51:19+00:00</updated>
<author>
<name>Grzegorz Bizon</name>
<email>grzesiek.bizon@gmail.com</email>
</author>
<published>2017-09-19T08:51:19+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=3fdd52bcd18a872267114d5d7a1c40d16fa32335'/>
<id>3fdd52bcd18a872267114d5d7a1c40d16fa32335</id>
<content type='text'>
Fixes gitlab-org/gitlab-qa#66
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes gitlab-org/gitlab-qa#66
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'issue_32215' into 'master'</title>
<updated>2017-09-19T07:35:27+00:00</updated>
<author>
<name>Rémy Coutable</name>
<email>remy@rymai.me</email>
</author>
<published>2017-09-19T07:35:27+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=1f4911541d03a257c38a63c6aa36a1c7ca4c3b43'/>
<id>1f4911541d03a257c38a63c6aa36a1c7ca4c3b43</id>
<content type='text'>
Allow DEVELOPER role to admin milestones

Closes #32215

See merge request gitlab-org/gitlab-ce!14257</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Allow DEVELOPER role to admin milestones

Closes #32215

See merge request gitlab-org/gitlab-ce!14257</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'standardise-small-button-classnames' into 'master'</title>
<updated>2017-09-19T07:05:32+00:00</updated>
<author>
<name>Tim Zallmann</name>
<email>tzallmann@gitlab.com</email>
</author>
<published>2017-09-19T07:05:32+00:00</published>
<link rel='alternate' type='text/html' href='http://91.123.203.49/cgit/delta/gitlab/gitlab-ce.git/commit/?id=c5c62bddef54d77ec032a9b4ff7bd3448ff26595'/>
<id>c5c62bddef54d77ec032a9b4ff7bd3448ff26595</id>
<content type='text'>
Change all instances of btn-sm to btn-small to keep things consistent

See merge request gitlab-org/gitlab-ce!14113</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change all instances of btn-sm to btn-small to keep things consistent

See merge request gitlab-org/gitlab-ce!14113</pre>
</div>
</content>
</entry>
</feed>
